From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Jan Kara <jack@suse.cz>
Cc: Winston Wen <wentao@uniontech.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: linux-next: build failure after merge of the ext3 tree
Date: Thu, 7 Mar 2024 11:07:17 +1100 [thread overview]
Message-ID: <20240307110717.50b64fe9@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 1741 bytes --]
Hi all,
After merging the ext3 tree, today's linux-next build (x86_64
allmodconfig) failed like this:
In file included from include/linux/sysctl.h:27,
from include/linux/fanotify.h:5,
from fs/notify/fanotify/fanotify.c:2:
fs/notify/fanotify/fanotify.c: In function 'fanotify_get_response':
fs/notify/fanotify/fanotify.c:233:48: error: suggest parentheses around arithmetic in operand of '|' [-Werror=parentheses]
233 | TASK_KILLABLE|TASK_FREEZABLE);
| ^
include/linux/wait.h:283:11: note: in definition of macro '___wait_is_interruptible'
283 | (state & (TASK_INTERRUPTIBLE | TASK_WAKEKILL)))
| ^~~~~
include/linux/wait.h:935:9: note: in expansion of macro '___wait_event'
935 | ___wait_event(wq, condition, state, 0, 0, schedule())
| ^~~~~~~~~~~~~
include/linux/wait.h:958:25: note: in expansion of macro '__wait_event_state'
958 | __ret = __wait_event_state(wq_head, condition, state); \
| ^~~~~~~~~~~~~~~~~~
fs/notify/fanotify/fanotify.c:231:15: note: in expansion of macro 'wait_event_state'
231 | ret = wait_event_state(group->fanotify_data.access_waitq,
| ^~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
Caused by commit
3440e7e55ced ("fanotify: allow freeze when waiting response for permission events")
Though, I guess, you could argue that the ___wait_is_interruptible macro
should parenthesise the use of its "state" argument.
I have used the ext3 tree from next-20240306 for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2024-03-07 0:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 0:07 Stephen Rothwell [this message]
2024-03-07 6:18 ` linux-next: build failure after merge of the ext3 tree Winston Wen
2024-03-07 12:03 ` Jan Kara
-- strict thread matches above, loose matches on Subject: below --
2023-08-16 0:37 Stephen Rothwell
2020-11-12 23:47 Stephen Rothwell
2020-11-13 10:33 ` Jan Kara
2019-01-31 4:14 Stephen Rothwell
2019-01-31 10:11 ` Jan Kara
2019-01-31 22:09 ` Stephen Rothwell
2014-08-08 1:52 Stephen Rothwell
2014-08-08 9:22 ` Jan Kara
2011-12-28 0:22 Stephen Rothwell
2012-01-02 22:40 ` Jan Kara
2010-03-02 0:36 Stephen Rothwell
2010-03-02 9:07 ` Christoph Hellwig
2010-03-02 17:27 ` Jan Kara
2010-03-03 0:42 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240307110717.50b64fe9@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=wentao@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.