All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kory Maincent <kory.maincent@bootlin.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Luis Chamberlain <mcgrof@kernel.org>,
	Russ Weight <russ.weight@linux.dev>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Frank Rowand <frowand.list@gmail.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org, devicetree@vger.kernel.org,
	Dent Project <dentproject@linuxfoundation.org>
Subject: Re: [PATCH net-next v5 13/17] net: pse-pd: Use regulator framework within PSE framework
Date: Fri, 22 Mar 2024 11:39:50 +0100	[thread overview]
Message-ID: <20240322113950.27d35376@kmaincent-XPS-13-7390> (raw)
In-Reply-To: <ZfxjosqPMo0ECBmx@pengutronix.de>

Hello Oleksij,

On Thu, 21 Mar 2024 17:43:14 +0100
Oleksij Rempel <o.rempel@pengutronix.de> wrote:

> On Thu, Mar 21, 2024 at 05:15:24PM +0100, Kory Maincent wrote:
> > Hello Oleksij,
> > Sorry, I forgot to reply about this.
> > This is specific to pse_regulator driver. Could we tackle this change in
> > another patch series when the current patch series got applied?
> > Also I don't have the hardware to test it.  
> 
> ACK, no problem.

I have a question unrelated to this.
Why do you add refcount on the pse_control struct?
The pse control is related to the RJ45 port. Each port is exclusively related
to one pse control.
Shouldn't we return an error in case of two get of the same pse control index?
Do you see use cases where a pse control could be get two times?

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

  reply	other threads:[~2024-03-22 10:39 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-27 14:42 [PATCH net-next v5 00/17] net: Add support for Power over Ethernet (PoE) Kory Maincent
2024-02-27 14:42 ` [PATCH net-next v5 01/17] MAINTAINERS: net: Add Oleksij to pse-pd maintainers Kory Maincent
2024-02-27 14:42 ` [PATCH net-next v5 02/17] of: property: Add fw_devlink support for pse parent Kory Maincent
2024-02-27 14:42 ` [PATCH net-next v5 03/17] net: pse-pd: Rectify and adapt the naming of admin_cotrol member of struct pse_control_config Kory Maincent
2024-02-27 14:42 ` [PATCH net-next v5 04/17] ethtool: Expand Ethernet Power Equipment with c33 (PoE) alongside PoDL Kory Maincent
2024-02-27 14:42 ` [PATCH net-next v5 05/17] net: pse-pd: Introduce PSE types enumeration Kory Maincent
2024-02-27 14:42 ` [PATCH net-next v5 06/17] net: ethtool: pse-pd: Expand pse commands with the PSE PoE interface Kory Maincent
2024-02-27 14:42 ` [PATCH net-next v5 07/17] netlink: specs: Modify pse attribute prefix Kory Maincent
2024-02-27 14:42 ` [PATCH net-next v5 08/17] netlink: specs: Expand the pse netlink command with PoE interface Kory Maincent
2024-02-27 14:42 ` [PATCH net-next v5 09/17] MAINTAINERS: Add myself to pse networking maintainer Kory Maincent
2024-02-27 14:42 ` [PATCH net-next v5 10/17] net: pse-pd: Add support for PSE PIs Kory Maincent
2024-03-01 14:24   ` Oleksij Rempel
2024-03-01 16:10     ` Köry Maincent
2024-03-01 16:48       ` Oleksij Rempel
2024-02-27 14:42 ` [PATCH net-next v5 11/17] dt-bindings: net: pse-pd: Add another way of describing several " Kory Maincent
2024-02-28 16:42   ` Rob Herring
2024-02-27 14:42 ` [PATCH net-next v5 12/17] net: pse-pd: Add support for setup_pi_matrix callback Kory Maincent
2024-02-27 14:42 ` [PATCH net-next v5 13/17] net: pse-pd: Use regulator framework within PSE framework Kory Maincent
2024-02-28  0:56   ` Jakub Kicinski
2024-02-29 10:19     ` Köry Maincent
2024-02-28 12:48   ` Simon Horman
2024-02-29  9:41     ` Köry Maincent
2024-03-02 21:35   ` Oleksij Rempel
2024-03-04  9:27     ` Köry Maincent
2024-03-04 10:31       ` Oleksij Rempel
2024-03-21 16:15         ` Kory Maincent
2024-03-21 16:43           ` Oleksij Rempel
2024-03-22 10:39             ` Kory Maincent [this message]
2024-03-22 14:07               ` Oleksij Rempel
2024-03-22 14:22                 ` Kory Maincent
2024-03-04 13:32       ` Andrew Lunn
2024-03-04 13:39         ` Oleksij Rempel
2024-03-04 13:53           ` Andrew Lunn
2024-03-04 14:23             ` Oleksij Rempel
2024-02-27 14:42 ` [PATCH net-next v5 14/17] dt-bindings: net: pse-pd: Add bindings for PD692x0 PSE controller Kory Maincent
2024-02-27 14:42 ` [PATCH net-next v5 15/17] net: pse-pd: Add PD692x0 PSE controller driver Kory Maincent
2024-02-27 14:42 ` [PATCH net-next v5 16/17] dt-bindings: net: pse-pd: Add bindings for TPS23881 PSE controller Kory Maincent
2024-02-27 14:42 ` [PATCH net-next v5 17/17] net: pse-pd: Add TI TPS23881 PSE controller driver Kory Maincent
2024-02-28 12:53   ` Simon Horman
2024-02-29 11:09     ` Köry Maincent
2024-02-27 15:31 ` [PATCH net-next v5 00/17] net: Add support for Power over Ethernet (PoE) Jamal Hadi Salim
2024-03-08 13:54   ` Köry Maincent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240322113950.27d35376@kmaincent-XPS-13-7390 \
    --to=kory.maincent@bootlin.com \
    --cc=andrew@lunn.ch \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=dentproject@linuxfoundation.org \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=frowand.list@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hkallweit1@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mcgrof@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=pabeni@redhat.com \
    --cc=rafael@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=russ.weight@linux.dev \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.