From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5DAA210840; Sun, 24 Mar 2024 23:08:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711321694; cv=none; b=bs1yw72CPLXMXCnXD3QHzphwDZVLBe2oBjCVbRNGQBhrqOqYNo+zRhP1f4OnfNDZvYFcfR8i7BdUNX36vQGOfiI97Fqeh/Z05ddK5/WGuO55sQB3LxzXJcL3KfMZY9D0bgy1eCCxA1rbmNpLVCkbnl9ncxx88oQfBUacTRhPG0M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711321694; c=relaxed/simple; bh=BApVoZr1HWgG77uIAlP5say5xUHr6e9CzMP/GXvg8hE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iq/D/5zF6xKGfohMKd6U0ZhDY3kiloSRZ7scaC0sHUCigU+Sxh0AeNj6MX/Vv4P/AzoN7v8dIUtRqtMn5yeDYjPbqbK0+EUvaK8u2+qGE43oCOBUR7bDiq2zMS2EACXTdscLXqhYHMuOGW/HwHlPh1jAeNJiDms6WOwoXFgnwuo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kioQo2xL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kioQo2xL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23F3FC43399; Sun, 24 Mar 2024 23:08:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711321693; bh=BApVoZr1HWgG77uIAlP5say5xUHr6e9CzMP/GXvg8hE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kioQo2xLJhfzScD//eGYOlJbWd5y6b9k7y5x0dcrsa1xFmfcYsY185JZnBRSDrqJI DD7rg9XSvsTXCD8GgWd1/7m5yMFbnEVDl7jklXHymTmd8YZz30HuclGuzYLX/mrhWi FH6vP7yIAXlUbho/EAwAXoz7UdiDRZerBJnzn4THcVooro1zO22DQZNy84yODCcEof YmjHOzYcdmE2bzSTS4a4n7/AQZ7OBWxh0LRDgONpA2uCAX+0r2GwlgLXls7+n4v25r a4bVsS1Xn1us/7AkcnVXq2Nafx/Cvn9Jc/1B+CUYyh805PW+OecuubLZwbWdvEkkGt /zrNg2Z7j67RQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Daniil Dulov , Hans Verkuil , Sasha Levin Subject: [PATCH 6.6 422/638] media: go7007: add check of return value of go7007_read_addr() Date: Sun, 24 Mar 2024 18:57:39 -0400 Message-ID: <20240324230116.1348576-423-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240324230116.1348576-1-sashal@kernel.org> References: <20240324230116.1348576-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Daniil Dulov [ Upstream commit 0b70530ee740861f4776ff724fcc25023df1799a ] If go7007_read_addr() returns error channel is not assigned a value. In this case go to allocfail. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 866b8695d67e ("Staging: add the go7007 video driver") Signed-off-by: Daniil Dulov Signed-off-by: Hans Verkuil Signed-off-by: Sasha Levin --- drivers/media/usb/go7007/go7007-usb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/go7007/go7007-usb.c b/drivers/media/usb/go7007/go7007-usb.c index eeb85981e02b6..762c13e49bfa5 100644 --- a/drivers/media/usb/go7007/go7007-usb.c +++ b/drivers/media/usb/go7007/go7007-usb.c @@ -1201,7 +1201,9 @@ static int go7007_usb_probe(struct usb_interface *intf, u16 channel; /* read channel number from GPIO[1:0] */ - go7007_read_addr(go, 0x3c81, &channel); + if (go7007_read_addr(go, 0x3c81, &channel)) + goto allocfail; + channel &= 0x3; go->board_id = GO7007_BOARDID_ADLINK_MPG24; usb->board = board = &board_adlink_mpg24; -- 2.43.0