From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3478812DDA7; Wed, 27 Mar 2024 16:28:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711556934; cv=none; b=qxuArM3L5N1ghR0nfpnk6Ts1yv92JlvNUGLFYvraFR2n2oCHspNLbSIQDDqa/jeY8F55yg84iuO4kjz8rrbEeRWgwvZdeeiHbKHD7zjBX+7qaNl7ChWb7bEZpdQcyMwhDD6tVXipH6fjEM3YHryaIvWjQa1l9R+PgbUk1rCamt0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711556934; c=relaxed/simple; bh=d9DnxmW+a4P+dEszAOdKuPFSCcl7qq/W+ZbL07RwEwA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cBvHU7PAyI9g61hXT07Px+HsJonVOMnJ/w03rjUzV7xZrKz5iGHCjkeQ4gYkpf4erq43R9n5lyT1r1Qh6k9tkTD89Im7mqAP2Icrgu8YCt5S3woFK9uD858/btOzrVtCoEYqF7oksS3wyC+7ChLJo7SHLsXYoSQuFnRfD/9QssM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VMxbb0Y3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VMxbb0Y3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34858C433C7; Wed, 27 Mar 2024 16:28:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711556933; bh=d9DnxmW+a4P+dEszAOdKuPFSCcl7qq/W+ZbL07RwEwA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VMxbb0Y3Qa/NNHrKY4OquYcNBThaVfbyHU61upgpTbCcFHlnFasflMqCeESKgyQ4A tSWfpWgupdbSS8VRsWTXgrUI2cRfVODARZzRVNqQoZl5Izn/lnhpbboebnIBN8fxbv InDRbXQFjTkFrPvEbUVQM940TJYOd3FxArh/rRuoN/G59hkw1eHpLjXLh0b+MeWh9A WxMGg8Tv5ReJlytHfW6AtCTbcWSocuF4cnSatbUoF4mf488EL6i+8cYxi9OMVGn5vT m4pvBPDiuT6fsBMZVvvnS/gJe7egoynptZ1ue20fS32a+ZIRPps2cGtCMBzyj8BIKg NtqzAhYhauw8A== Date: Wed, 27 Mar 2024 16:28:49 +0000 From: Conor Dooley To: Mihai Sain Cc: robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, claudiu.beznea@tuxon.dev, lgirdwood@gmail.com, broonie@kernel.org, andrei.simion@microchip.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/7] regulator: mcp16502: Update the names from buck regulators Message-ID: <20240327-agreed-routine-0cc60186876b@spud> References: <20240327101724.2982-1-mihai.sain@microchip.com> <20240327101724.2982-8-mihai.sain@microchip.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lqf7Y/CEqKPOGaGb" Content-Disposition: inline In-Reply-To: <20240327101724.2982-8-mihai.sain@microchip.com> --lqf7Y/CEqKPOGaGb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 27, 2024 at 12:17:24PM +0200, Mihai Sain wrote: > Use generic names for buck regulators to avoid any confusion. > Update the names from buck regulators in order to match > the datasheet block diagram for the buck regulators. >=20 > Signed-off-by: Mihai Sain I know the regulator core will create dummy regulators when they are not provided in the devicetree, so I am not 100% on how backwards compatibility works here. You'll end up with a bunch of dummies and therefore the regulator-names and constraints on the regulator will be lost, no? Can you explain how is this backwards compatible with the old devicetrees? Thanks, Conor. > --- > drivers/regulator/mcp16502.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/regulator/mcp16502.c b/drivers/regulator/mcp16502.c > index 0c15a19fe83a..d6fc9f1afaef 100644 > --- a/drivers/regulator/mcp16502.c > +++ b/drivers/regulator/mcp16502.c > @@ -468,13 +468,13 @@ static const struct linear_range b234_ranges[] =3D { > =20 > static const struct regulator_desc mcp16502_desc[] =3D { > /* MCP16502_REGULATOR(_name, _id, ranges, regulator_ops, ramp_table) */ > - MCP16502_REGULATOR("VDD_IO", BUCK1, b1l12_ranges, mcp16502_buck_ops, > + MCP16502_REGULATOR("BUCK1", BUCK1, b1l12_ranges, mcp16502_buck_ops, > mcp16502_ramp_b1l12), > - MCP16502_REGULATOR("VDD_DDR", BUCK2, b234_ranges, mcp16502_buck_ops, > + MCP16502_REGULATOR("BUCK2", BUCK2, b234_ranges, mcp16502_buck_ops, > mcp16502_ramp_b234), > - MCP16502_REGULATOR("VDD_CORE", BUCK3, b234_ranges, mcp16502_buck_ops, > + MCP16502_REGULATOR("BUCK3", BUCK3, b234_ranges, mcp16502_buck_ops, > mcp16502_ramp_b234), > - MCP16502_REGULATOR("VDD_OTHER", BUCK4, b234_ranges, mcp16502_buck_ops, > + MCP16502_REGULATOR("BUCK4", BUCK4, b234_ranges, mcp16502_buck_ops, > mcp16502_ramp_b234), > MCP16502_REGULATOR("LDO1", LDO1, b1l12_ranges, mcp16502_ldo_ops, > mcp16502_ramp_b1l12), > --=20 > 2.44.0 >=20 --lqf7Y/CEqKPOGaGb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZgRJQAAKCRB4tDGHoIJi 0jMkAQC28sZ5rt1TFDBpNnI9RQ9dzDj+9bBym/hmm2MyRGVBHAEA6VY1HcwfphJM UohqJE1s3Smp5X8Ku6nzNEe7i/s5Kwk= =CGed -----END PGP SIGNATURE----- --lqf7Y/CEqKPOGaGb-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD9E1C47DD9 for ; Wed, 27 Mar 2024 16:29:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lCD6UYedlxdk2N9DP9FfAbZWBFlMbyRVzZUb9bN4a98=; b=B/Acozhm1K2nKHpYGAkKUpdi66 GiCzSByExZB5xZHXmF+9AAznTqpyYyYUOA+Ev0FgADUqqojmfKeNrkmiSz+nM4gQPE0tiOryXMT71 wKmHxiIttc94GGWfa/YqyS2UDcb2rNT6W19qVfrTE3mBJGdURTFsM7BHQog0QP8opIvch5Jl6JA5Y 81N+ngUlkrvyVH7MTHhTfYjXsruZzjRp1SDEnux1RqDOM4droCp1nIWGCQ9Kv1o4BMi7SlyaME+fI /2xCLMHCX6ip++cbuD5he/1VfjTPVofNgN1MDsE2Sf9Bd9gtz/1j7moOcaDhTWP4iCIXueXHX3aAU QWs6Jujw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpW95-0000000A5Kp-25zE; Wed, 27 Mar 2024 16:28:59 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpW92-0000000A5K0-1Tb3 for linux-arm-kernel@lists.infradead.org; Wed, 27 Mar 2024 16:28:57 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 87D4CCE1B37; Wed, 27 Mar 2024 16:28:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34858C433C7; Wed, 27 Mar 2024 16:28:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711556933; bh=d9DnxmW+a4P+dEszAOdKuPFSCcl7qq/W+ZbL07RwEwA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VMxbb0Y3Qa/NNHrKY4OquYcNBThaVfbyHU61upgpTbCcFHlnFasflMqCeESKgyQ4A tSWfpWgupdbSS8VRsWTXgrUI2cRfVODARZzRVNqQoZl5Izn/lnhpbboebnIBN8fxbv InDRbXQFjTkFrPvEbUVQM940TJYOd3FxArh/rRuoN/G59hkw1eHpLjXLh0b+MeWh9A WxMGg8Tv5ReJlytHfW6AtCTbcWSocuF4cnSatbUoF4mf488EL6i+8cYxi9OMVGn5vT m4pvBPDiuT6fsBMZVvvnS/gJe7egoynptZ1ue20fS32a+ZIRPps2cGtCMBzyj8BIKg NtqzAhYhauw8A== Date: Wed, 27 Mar 2024 16:28:49 +0000 From: Conor Dooley To: Mihai Sain Subject: Re: [PATCH 7/7] regulator: mcp16502: Update the names from buck regulators Message-ID: <20240327-agreed-routine-0cc60186876b@spud> References: <20240327101724.2982-1-mihai.sain@microchip.com> <20240327101724.2982-8-mihai.sain@microchip.com> MIME-Version: 1.0 In-Reply-To: <20240327101724.2982-8-mihai.sain@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240327_092856_829111_98CB38FC X-CRM114-Status: GOOD ( 19.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robh@kernel.org, conor+dt@kernel.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, alexandre.belloni@bootlin.com, devicetree@vger.kernel.org, broonie@kernel.org, krzysztof.kozlowski+dt@linaro.org, claudiu.beznea@tuxon.dev, andrei.simion@microchip.com, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============7732655462111877603==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7732655462111877603== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lqf7Y/CEqKPOGaGb" Content-Disposition: inline --lqf7Y/CEqKPOGaGb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 27, 2024 at 12:17:24PM +0200, Mihai Sain wrote: > Use generic names for buck regulators to avoid any confusion. > Update the names from buck regulators in order to match > the datasheet block diagram for the buck regulators. >=20 > Signed-off-by: Mihai Sain I know the regulator core will create dummy regulators when they are not provided in the devicetree, so I am not 100% on how backwards compatibility works here. You'll end up with a bunch of dummies and therefore the regulator-names and constraints on the regulator will be lost, no? Can you explain how is this backwards compatible with the old devicetrees? Thanks, Conor. > --- > drivers/regulator/mcp16502.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/regulator/mcp16502.c b/drivers/regulator/mcp16502.c > index 0c15a19fe83a..d6fc9f1afaef 100644 > --- a/drivers/regulator/mcp16502.c > +++ b/drivers/regulator/mcp16502.c > @@ -468,13 +468,13 @@ static const struct linear_range b234_ranges[] =3D { > =20 > static const struct regulator_desc mcp16502_desc[] =3D { > /* MCP16502_REGULATOR(_name, _id, ranges, regulator_ops, ramp_table) */ > - MCP16502_REGULATOR("VDD_IO", BUCK1, b1l12_ranges, mcp16502_buck_ops, > + MCP16502_REGULATOR("BUCK1", BUCK1, b1l12_ranges, mcp16502_buck_ops, > mcp16502_ramp_b1l12), > - MCP16502_REGULATOR("VDD_DDR", BUCK2, b234_ranges, mcp16502_buck_ops, > + MCP16502_REGULATOR("BUCK2", BUCK2, b234_ranges, mcp16502_buck_ops, > mcp16502_ramp_b234), > - MCP16502_REGULATOR("VDD_CORE", BUCK3, b234_ranges, mcp16502_buck_ops, > + MCP16502_REGULATOR("BUCK3", BUCK3, b234_ranges, mcp16502_buck_ops, > mcp16502_ramp_b234), > - MCP16502_REGULATOR("VDD_OTHER", BUCK4, b234_ranges, mcp16502_buck_ops, > + MCP16502_REGULATOR("BUCK4", BUCK4, b234_ranges, mcp16502_buck_ops, > mcp16502_ramp_b234), > MCP16502_REGULATOR("LDO1", LDO1, b1l12_ranges, mcp16502_ldo_ops, > mcp16502_ramp_b1l12), > --=20 > 2.44.0 >=20 --lqf7Y/CEqKPOGaGb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZgRJQAAKCRB4tDGHoIJi 0jMkAQC28sZ5rt1TFDBpNnI9RQ9dzDj+9bBym/hmm2MyRGVBHAEA6VY1HcwfphJM UohqJE1s3Smp5X8Ku6nzNEe7i/s5Kwk= =CGed -----END PGP SIGNATURE----- --lqf7Y/CEqKPOGaGb-- --===============7732655462111877603== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7732655462111877603==--