From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B1C7374F9;
	Thu, 28 Mar 2024 11:37:31 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1711625852; cv=none; b=CRWn6pskGkRZugffrCI+9a6dQMNkh6xDlZpybe+t31xly7Sy7vQDLKvCjEOUDfTC34kk2CwB3wcB9+IVrItkkZUWjmP9Qmxro5tl8IVKbIEmxwhX+EZ0nVYYq6Am84OhoQmn/tp5O6PomhSPakgM4WXcsgVoMtQPNKcrei5p+3E=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1711625852; c=relaxed/simple;
	bh=PVbCQcBD9CWn/gNAbIGipQTz8wnyniImrlBgL0zkhjw=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=IfFrn9ZK28RrjQ/fWbiWPbnlLCrRnOiRzoWhS9kqkatJKuvxnSbcZKlBzJYcSaHIHlLcGsGNEcH75x038S8E2mdmSc29iZRH4k8VED5sIM/xyJ694PjWW5kk9QJlGfLWxrjo+cjhEVHuzVfsbRDX8m8IirCdnQ8/5vdjhjm++fk=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=J7uMJjyR; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="J7uMJjyR"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2206EC433C7;
	Thu, 28 Mar 2024 11:37:27 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1711625851;
	bh=PVbCQcBD9CWn/gNAbIGipQTz8wnyniImrlBgL0zkhjw=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=J7uMJjyRckdKZmMRdYNjQ7wUziTu9fqjJYx9lm0PzzjjqYb3/imPJtrkbwmxHidrs
	 2pqpPaAvH/1mJ22XEtyQxLKt/GJyZd+tuOHleveFBqrp5wUEdZVpYfnTt9iXDkUBBj
	 P+WXZaWVYJOlR0qVK5RZPP1KH3SY8dAzLpZxROH9gRFr0ZqPf7yBj43v6qoAyqU5Pw
	 K8TXc6il04eknWpAT7jnwaYHAi3qTXBEnAOWIyzzUGHK3I7w0bVKU93UVzNU82DPKu
	 yizSp53bq538s9z6mUtDCFCuk/83Tu7T8qeVzN73hYU5B9jvFgvtHRQAeUW9uIeGVz
	 DV+8ZifBpt+DQ==
Date: Thu, 28 Mar 2024 11:37:25 +0000
From: Lee Jones <lee@kernel.org>
To: Bhargav Raviprakash <bhargav.r@ltts.com>
Cc: linux-kernel@vger.kernel.org, m.nirmaladevi@ltts.com,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, jpanis@baylibre.com,
	devicetree@vger.kernel.org, arnd@arndb.de,
	gregkh@linuxfoundation.org, lgirdwood@gmail.com, broonie@kernel.org,
	linus.walleij@linaro.org, linux-gpio@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, nm@ti.com, vigneshr@ti.com,
	kristo@kernel.org, eblanc@baylibre.com
Subject: Re: [PATCH v4 03/11] mfd: tps6594: add regmap config in match data
Message-ID: <20240328113725.GA13211@google.com>
References: <20240320102559.464981-1-bhargav.r@ltts.com>
 <20240320102559.464981-4-bhargav.r@ltts.com>
Precedence: bulk
X-Mailing-List: linux-gpio@vger.kernel.org
List-Id: <linux-gpio.vger.kernel.org>
List-Subscribe: <mailto:linux-gpio+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-gpio+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240320102559.464981-4-bhargav.r@ltts.com>

On Wed, 20 Mar 2024, Bhargav Raviprakash wrote:

> Introduces a new struct tps6594_match_data. This struct holds fields for
> chip id and regmap config. Using this struct in of_device_id data field.
> This helps in adding support for TPS65224 PMIC.
> 
> Signed-off-by: Bhargav Raviprakash <bhargav.r@ltts.com>
> Acked-by: Julien Panis <jpanis@baylibre.com>
> ---
>  drivers/mfd/tps6594-i2c.c   | 24 ++++++++++++++++--------
>  drivers/mfd/tps6594-spi.c   | 24 ++++++++++++++++--------
>  include/linux/mfd/tps6594.h | 11 +++++++++++
>  3 files changed, 43 insertions(+), 16 deletions(-)

Mostly fine, just a couple of nits.

Firstly the subject lines for the entire set are inconsistent.

Please use the style set by the subsystem:

  `git log --oneline -- <subsystem>` is your friend.

> diff --git a/drivers/mfd/tps6594-i2c.c b/drivers/mfd/tps6594-i2c.c
> index c125b474b..9e2ed48b7 100644
> --- a/drivers/mfd/tps6594-i2c.c
> +++ b/drivers/mfd/tps6594-i2c.c
> @@ -192,10 +192,16 @@ static const struct regmap_config tps6594_i2c_regmap_config = {
>  	.write = tps6594_i2c_write,
>  };
>  
> +static const struct tps6594_match_data match_data[] = {
> +	[TPS6594] = {TPS6594, &tps6594_i2c_regmap_config},
> +	[TPS6593] = {TPS6593, &tps6594_i2c_regmap_config},
> +	[LP8764] = {LP8764, &tps6594_i2c_regmap_config},

Spaces after the '{' and before the '}' please.
> +};
> +
>  static const struct of_device_id tps6594_i2c_of_match_table[] = {
> -	{ .compatible = "ti,tps6594-q1", .data = (void *)TPS6594, },
> -	{ .compatible = "ti,tps6593-q1", .data = (void *)TPS6593, },
> -	{ .compatible = "ti,lp8764-q1",  .data = (void *)LP8764,  },
> +	{ .compatible = "ti,tps6594-q1", .data = &match_data[TPS6594], },
> +	{ .compatible = "ti,tps6593-q1", .data = &match_data[TPS6593], },
> +	{ .compatible = "ti,lp8764-q1",  .data = &match_data[LP8764], },
>  	{}
>  };
>  MODULE_DEVICE_TABLE(of, tps6594_i2c_of_match_table);
> @@ -205,6 +211,7 @@ static int tps6594_i2c_probe(struct i2c_client *client)
>  	struct device *dev = &client->dev;
>  	struct tps6594 *tps;
>  	const struct of_device_id *match;
> +	const struct tps6594_match_data *mdata;
>  
>  	tps = devm_kzalloc(dev, sizeof(*tps), GFP_KERNEL);
>  	if (!tps)
> @@ -216,14 +223,15 @@ static int tps6594_i2c_probe(struct i2c_client *client)
>  	tps->reg = client->addr;
>  	tps->irq = client->irq;
>  
> -	tps->regmap = devm_regmap_init(dev, NULL, client, &tps6594_i2c_regmap_config);
> -	if (IS_ERR(tps->regmap))
> -		return dev_err_probe(dev, PTR_ERR(tps->regmap), "Failed to init regmap\n");
> -
>  	match = of_match_device(tps6594_i2c_of_match_table, dev);
>  	if (!match)
>  		return dev_err_probe(dev, -EINVAL, "Failed to find matching chip ID\n");
> -	tps->chip_id = (unsigned long)match->data;
> +	mdata = (struct tps6594_match_data *)match->data;

What happens when you drop this case?

I was under the impression this was not required when casting from (void *)

> +	tps->chip_id = mdata->chip_id;
> +
> +	tps->regmap = devm_regmap_init(dev, NULL, client, mdata->config);
> +	if (IS_ERR(tps->regmap))
> +		return dev_err_probe(dev, PTR_ERR(tps->regmap), "Failed to init regmap\n");

"initialise"

>  
>  	crc8_populate_msb(tps6594_i2c_crc_table, TPS6594_CRC8_POLYNOMIAL);
>  
> diff --git a/drivers/mfd/tps6594-spi.c b/drivers/mfd/tps6594-spi.c
> index 5afb1736f..82a1c02e3 100644
> --- a/drivers/mfd/tps6594-spi.c
> +++ b/drivers/mfd/tps6594-spi.c
> @@ -77,10 +77,16 @@ static const struct regmap_config tps6594_spi_regmap_config = {
>  	.use_single_write = true,
>  };
>  
> +static const struct tps6594_match_data match_data[] = {
> +	[TPS6594] = {TPS6594, &tps6594_spi_regmap_config},
> +	[TPS6593] = {TPS6593, &tps6594_spi_regmap_config},
> +	[LP8764] = {LP8764, &tps6594_spi_regmap_config},

As above.

> +};
> +
>  static const struct of_device_id tps6594_spi_of_match_table[] = {
> -	{ .compatible = "ti,tps6594-q1", .data = (void *)TPS6594, },
> -	{ .compatible = "ti,tps6593-q1", .data = (void *)TPS6593, },
> -	{ .compatible = "ti,lp8764-q1",  .data = (void *)LP8764,  },
> +	{ .compatible = "ti,tps6594-q1", .data = &match_data[TPS6594], },
> +	{ .compatible = "ti,tps6593-q1", .data = &match_data[TPS6593], },
> +	{ .compatible = "ti,lp8764-q1",  .data = &match_data[LP8764], },
>  	{}
>  };
>  MODULE_DEVICE_TABLE(of, tps6594_spi_of_match_table);
> @@ -90,6 +96,7 @@ static int tps6594_spi_probe(struct spi_device *spi)
>  	struct device *dev = &spi->dev;
>  	struct tps6594 *tps;
>  	const struct of_device_id *match;
> +	const struct tps6594_match_data *mdata;
>  
>  	tps = devm_kzalloc(dev, sizeof(*tps), GFP_KERNEL);
>  	if (!tps)
> @@ -101,14 +108,15 @@ static int tps6594_spi_probe(struct spi_device *spi)
>  	tps->reg = spi_get_chipselect(spi, 0);
>  	tps->irq = spi->irq;
>  
> -	tps->regmap = devm_regmap_init(dev, NULL, spi, &tps6594_spi_regmap_config);
> -	if (IS_ERR(tps->regmap))
> -		return dev_err_probe(dev, PTR_ERR(tps->regmap), "Failed to init regmap\n");
> -
>  	match = of_match_device(tps6594_spi_of_match_table, dev);
>  	if (!match)
>  		return dev_err_probe(dev, -EINVAL, "Failed to find matching chip ID\n");
> -	tps->chip_id = (unsigned long)match->data;
> +	mdata = (struct tps6594_match_data *)match->data;
> +	tps->chip_id = mdata->chip_id;
> +
> +	tps->regmap = devm_regmap_init(dev, NULL, spi, mdata->config);
> +	if (IS_ERR(tps->regmap))
> +		return dev_err_probe(dev, PTR_ERR(tps->regmap), "Failed to init regmap\n");
>  
>  	crc8_populate_msb(tps6594_spi_crc_table, TPS6594_CRC8_POLYNOMIAL);
>  
> diff --git a/include/linux/mfd/tps6594.h b/include/linux/mfd/tps6594.h
> index 16543fd4d..d781e0fe3 100644
> --- a/include/linux/mfd/tps6594.h
> +++ b/include/linux/mfd/tps6594.h
> @@ -1337,6 +1337,17 @@ struct tps6594 {
>  	struct regmap_irq_chip_data *irq_data;
>  };
>  
> +/**
> + * struct tps6594_match_data - of match data of PMIC
> + *
> + * @chip_id: chip ID of PMIC
> + * @config: regmap config of PMIC
> + */
> +struct tps6594_match_data {
> +	unsigned long chip_id;
> +	const struct regmap_config *config;
> +};
> +
>  extern const struct regmap_access_table tps6594_volatile_table;
>  extern const struct regmap_access_table tps65224_volatile_table;
>  
> -- 
> 2.25.1
> 

-- 
Lee Jones [李琼斯]

From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.lore.kernel.org (Postfix) with ESMTPS id 568A8C54E64
	for <linux-arm-kernel@archiver.kernel.org>; Thu, 28 Mar 2024 11:37:47 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=lists.infradead.org; s=bombadil.20210309; h=Sender:
	Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:
	List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:
	Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:
	Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:
	List-Owner; bh=whPH86hwyjOBOn7BKwMvvtwxO5FgOWFosk14WbllkCs=; b=o1rVB8YSgzw/Yv
	E7/RZiGFEpB19RdQo+074wPALGdrVAl3q/JMjgcBkyXVGoxZUJqmBgMWNhbBxOvkcsuVHedqlK+0x
	MhrakNBbxnwvZmWRV17QKXicdyXIwzo7X6LuvG6SFeYZNRZ85tOVsSWEeZpY1kCT1QPt5sGoGwh1Q
	Wf5nmcCAJ2wIshOUlW9P1rY04ny5ax2oK1yNbbKBf1YxB83BTuTSwJ25O09QUZbiQJAK5pSZkU/Kq
	AjEfRCM+4ChpnbUmHAG8R55pZw0ogKwdjh+uXxfQYeLgXqpVXGwoCqQ7rY5iZbDYyBjZoCwmzYKRD
	aN1+XMH3QBjzn64lgEbw==;
Received: from localhost ([::1] helo=bombadil.infradead.org)
	by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux))
	id 1rpo4d-0000000Dldn-41Nh;
	Thu, 28 Mar 2024 11:37:35 +0000
Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1])
	by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux))
	id 1rpo4b-0000000Dld2-1BsK
	for linux-arm-kernel@lists.infradead.org;
	Thu, 28 Mar 2024 11:37:34 +0000
Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])
	by dfw.source.kernel.org (Postfix) with ESMTP id 22A8660EB3;
	Thu, 28 Mar 2024 11:37:32 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2206EC433C7;
	Thu, 28 Mar 2024 11:37:27 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1711625851;
	bh=PVbCQcBD9CWn/gNAbIGipQTz8wnyniImrlBgL0zkhjw=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=J7uMJjyRckdKZmMRdYNjQ7wUziTu9fqjJYx9lm0PzzjjqYb3/imPJtrkbwmxHidrs
	 2pqpPaAvH/1mJ22XEtyQxLKt/GJyZd+tuOHleveFBqrp5wUEdZVpYfnTt9iXDkUBBj
	 P+WXZaWVYJOlR0qVK5RZPP1KH3SY8dAzLpZxROH9gRFr0ZqPf7yBj43v6qoAyqU5Pw
	 K8TXc6il04eknWpAT7jnwaYHAi3qTXBEnAOWIyzzUGHK3I7w0bVKU93UVzNU82DPKu
	 yizSp53bq538s9z6mUtDCFCuk/83Tu7T8qeVzN73hYU5B9jvFgvtHRQAeUW9uIeGVz
	 DV+8ZifBpt+DQ==
Date: Thu, 28 Mar 2024 11:37:25 +0000
From: Lee Jones <lee@kernel.org>
To: Bhargav Raviprakash <bhargav.r@ltts.com>
Cc: linux-kernel@vger.kernel.org, m.nirmaladevi@ltts.com,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, jpanis@baylibre.com,
	devicetree@vger.kernel.org, arnd@arndb.de,
	gregkh@linuxfoundation.org, lgirdwood@gmail.com, broonie@kernel.org,
	linus.walleij@linaro.org, linux-gpio@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, nm@ti.com, vigneshr@ti.com,
	kristo@kernel.org, eblanc@baylibre.com
Subject: Re: [PATCH v4 03/11] mfd: tps6594: add regmap config in match data
Message-ID: <20240328113725.GA13211@google.com>
References: <20240320102559.464981-1-bhargav.r@ltts.com>
 <20240320102559.464981-4-bhargav.r@ltts.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20240320102559.464981-4-bhargav.r@ltts.com>
X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 
X-CRM114-CacheID: sfid-20240328_043733_459908_DF479591 
X-CRM114-Status: GOOD (  22.03  )
X-BeenThere: linux-arm-kernel@lists.infradead.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: <linux-arm-kernel.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>,
 <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/>
List-Post: <mailto:linux-arm-kernel@lists.infradead.org>
List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,
 <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org>
Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org

T24gV2VkLCAyMCBNYXIgMjAyNCwgQmhhcmdhdiBSYXZpcHJha2FzaCB3cm90ZToKCj4gSW50cm9k
dWNlcyBhIG5ldyBzdHJ1Y3QgdHBzNjU5NF9tYXRjaF9kYXRhLiBUaGlzIHN0cnVjdCBob2xkcyBm
aWVsZHMgZm9yCj4gY2hpcCBpZCBhbmQgcmVnbWFwIGNvbmZpZy4gVXNpbmcgdGhpcyBzdHJ1Y3Qg
aW4gb2ZfZGV2aWNlX2lkIGRhdGEgZmllbGQuCj4gVGhpcyBoZWxwcyBpbiBhZGRpbmcgc3VwcG9y
dCBmb3IgVFBTNjUyMjQgUE1JQy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBCaGFyZ2F2IFJhdmlwcmFr
YXNoIDxiaGFyZ2F2LnJAbHR0cy5jb20+Cj4gQWNrZWQtYnk6IEp1bGllbiBQYW5pcyA8anBhbmlz
QGJheWxpYnJlLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9tZmQvdHBzNjU5NC1pMmMuYyAgIHwgMjQg
KysrKysrKysrKysrKysrKy0tLS0tLS0tCj4gIGRyaXZlcnMvbWZkL3RwczY1OTQtc3BpLmMgICB8
IDI0ICsrKysrKysrKysrKysrKystLS0tLS0tLQo+ICBpbmNsdWRlL2xpbnV4L21mZC90cHM2NTk0
LmggfCAxMSArKysrKysrKysrKwo+ICAzIGZpbGVzIGNoYW5nZWQsIDQzIGluc2VydGlvbnMoKyks
IDE2IGRlbGV0aW9ucygtKQoKTW9zdGx5IGZpbmUsIGp1c3QgYSBjb3VwbGUgb2Ygbml0cy4KCkZp
cnN0bHkgdGhlIHN1YmplY3QgbGluZXMgZm9yIHRoZSBlbnRpcmUgc2V0IGFyZSBpbmNvbnNpc3Rl
bnQuCgpQbGVhc2UgdXNlIHRoZSBzdHlsZSBzZXQgYnkgdGhlIHN1YnN5c3RlbToKCiAgYGdpdCBs
b2cgLS1vbmVsaW5lIC0tIDxzdWJzeXN0ZW0+YCBpcyB5b3VyIGZyaWVuZC4KCj4gZGlmZiAtLWdp
dCBhL2RyaXZlcnMvbWZkL3RwczY1OTQtaTJjLmMgYi9kcml2ZXJzL21mZC90cHM2NTk0LWkyYy5j
Cj4gaW5kZXggYzEyNWI0NzRiLi45ZTJlZDQ4YjcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9tZmQv
dHBzNjU5NC1pMmMuYwo+ICsrKyBiL2RyaXZlcnMvbWZkL3RwczY1OTQtaTJjLmMKPiBAQCAtMTky
LDEwICsxOTIsMTYgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCByZWdtYXBfY29uZmlnIHRwczY1OTRf
aTJjX3JlZ21hcF9jb25maWcgPSB7Cj4gIAkud3JpdGUgPSB0cHM2NTk0X2kyY193cml0ZSwKPiAg
fTsKPiAgCj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgdHBzNjU5NF9tYXRjaF9kYXRhIG1hdGNoX2Rh
dGFbXSA9IHsKPiArCVtUUFM2NTk0XSA9IHtUUFM2NTk0LCAmdHBzNjU5NF9pMmNfcmVnbWFwX2Nv
bmZpZ30sCj4gKwlbVFBTNjU5M10gPSB7VFBTNjU5MywgJnRwczY1OTRfaTJjX3JlZ21hcF9jb25m
aWd9LAo+ICsJW0xQODc2NF0gPSB7TFA4NzY0LCAmdHBzNjU5NF9pMmNfcmVnbWFwX2NvbmZpZ30s
CgpTcGFjZXMgYWZ0ZXIgdGhlICd7JyBhbmQgYmVmb3JlIHRoZSAnfScgcGxlYXNlLgo+ICt9Owo+
ICsKPiAgc3RhdGljIGNvbnN0IHN0cnVjdCBvZl9kZXZpY2VfaWQgdHBzNjU5NF9pMmNfb2ZfbWF0
Y2hfdGFibGVbXSA9IHsKPiAtCXsgLmNvbXBhdGlibGUgPSAidGksdHBzNjU5NC1xMSIsIC5kYXRh
ID0gKHZvaWQgKilUUFM2NTk0LCB9LAo+IC0JeyAuY29tcGF0aWJsZSA9ICJ0aSx0cHM2NTkzLXEx
IiwgLmRhdGEgPSAodm9pZCAqKVRQUzY1OTMsIH0sCj4gLQl7IC5jb21wYXRpYmxlID0gInRpLGxw
ODc2NC1xMSIsICAuZGF0YSA9ICh2b2lkICopTFA4NzY0LCAgfSwKPiArCXsgLmNvbXBhdGlibGUg
PSAidGksdHBzNjU5NC1xMSIsIC5kYXRhID0gJm1hdGNoX2RhdGFbVFBTNjU5NF0sIH0sCj4gKwl7
IC5jb21wYXRpYmxlID0gInRpLHRwczY1OTMtcTEiLCAuZGF0YSA9ICZtYXRjaF9kYXRhW1RQUzY1
OTNdLCB9LAo+ICsJeyAuY29tcGF0aWJsZSA9ICJ0aSxscDg3NjQtcTEiLCAgLmRhdGEgPSAmbWF0
Y2hfZGF0YVtMUDg3NjRdLCB9LAo+ICAJe30KPiAgfTsKPiAgTU9EVUxFX0RFVklDRV9UQUJMRShv
ZiwgdHBzNjU5NF9pMmNfb2ZfbWF0Y2hfdGFibGUpOwo+IEBAIC0yMDUsNiArMjExLDcgQEAgc3Rh
dGljIGludCB0cHM2NTk0X2kyY19wcm9iZShzdHJ1Y3QgaTJjX2NsaWVudCAqY2xpZW50KQo+ICAJ
c3RydWN0IGRldmljZSAqZGV2ID0gJmNsaWVudC0+ZGV2Owo+ICAJc3RydWN0IHRwczY1OTQgKnRw
czsKPiAgCWNvbnN0IHN0cnVjdCBvZl9kZXZpY2VfaWQgKm1hdGNoOwo+ICsJY29uc3Qgc3RydWN0
IHRwczY1OTRfbWF0Y2hfZGF0YSAqbWRhdGE7Cj4gIAo+ICAJdHBzID0gZGV2bV9remFsbG9jKGRl
diwgc2l6ZW9mKCp0cHMpLCBHRlBfS0VSTkVMKTsKPiAgCWlmICghdHBzKQo+IEBAIC0yMTYsMTQg
KzIyMywxNSBAQCBzdGF0aWMgaW50IHRwczY1OTRfaTJjX3Byb2JlKHN0cnVjdCBpMmNfY2xpZW50
ICpjbGllbnQpCj4gIAl0cHMtPnJlZyA9IGNsaWVudC0+YWRkcjsKPiAgCXRwcy0+aXJxID0gY2xp
ZW50LT5pcnE7Cj4gIAo+IC0JdHBzLT5yZWdtYXAgPSBkZXZtX3JlZ21hcF9pbml0KGRldiwgTlVM
TCwgY2xpZW50LCAmdHBzNjU5NF9pMmNfcmVnbWFwX2NvbmZpZyk7Cj4gLQlpZiAoSVNfRVJSKHRw
cy0+cmVnbWFwKSkKPiAtCQlyZXR1cm4gZGV2X2Vycl9wcm9iZShkZXYsIFBUUl9FUlIodHBzLT5y
ZWdtYXApLCAiRmFpbGVkIHRvIGluaXQgcmVnbWFwXG4iKTsKPiAtCj4gIAltYXRjaCA9IG9mX21h
dGNoX2RldmljZSh0cHM2NTk0X2kyY19vZl9tYXRjaF90YWJsZSwgZGV2KTsKPiAgCWlmICghbWF0
Y2gpCj4gIAkJcmV0dXJuIGRldl9lcnJfcHJvYmUoZGV2LCAtRUlOVkFMLCAiRmFpbGVkIHRvIGZp
bmQgbWF0Y2hpbmcgY2hpcCBJRFxuIik7Cj4gLQl0cHMtPmNoaXBfaWQgPSAodW5zaWduZWQgbG9u
ZyltYXRjaC0+ZGF0YTsKPiArCW1kYXRhID0gKHN0cnVjdCB0cHM2NTk0X21hdGNoX2RhdGEgKilt
YXRjaC0+ZGF0YTsKCldoYXQgaGFwcGVucyB3aGVuIHlvdSBkcm9wIHRoaXMgY2FzZT8KCkkgd2Fz
IHVuZGVyIHRoZSBpbXByZXNzaW9uIHRoaXMgd2FzIG5vdCByZXF1aXJlZCB3aGVuIGNhc3Rpbmcg
ZnJvbSAodm9pZCAqKQoKPiArCXRwcy0+Y2hpcF9pZCA9IG1kYXRhLT5jaGlwX2lkOwo+ICsKPiAr
CXRwcy0+cmVnbWFwID0gZGV2bV9yZWdtYXBfaW5pdChkZXYsIE5VTEwsIGNsaWVudCwgbWRhdGEt
PmNvbmZpZyk7Cj4gKwlpZiAoSVNfRVJSKHRwcy0+cmVnbWFwKSkKPiArCQlyZXR1cm4gZGV2X2Vy
cl9wcm9iZShkZXYsIFBUUl9FUlIodHBzLT5yZWdtYXApLCAiRmFpbGVkIHRvIGluaXQgcmVnbWFw
XG4iKTsKCiJpbml0aWFsaXNlIgoKPiAgCj4gIAljcmM4X3BvcHVsYXRlX21zYih0cHM2NTk0X2ky
Y19jcmNfdGFibGUsIFRQUzY1OTRfQ1JDOF9QT0xZTk9NSUFMKTsKPiAgCj4gZGlmZiAtLWdpdCBh
L2RyaXZlcnMvbWZkL3RwczY1OTQtc3BpLmMgYi9kcml2ZXJzL21mZC90cHM2NTk0LXNwaS5jCj4g
aW5kZXggNWFmYjE3MzZmLi44MmExYzAyZTMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9tZmQvdHBz
NjU5NC1zcGkuYwo+ICsrKyBiL2RyaXZlcnMvbWZkL3RwczY1OTQtc3BpLmMKPiBAQCAtNzcsMTAg
Kzc3LDE2IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgcmVnbWFwX2NvbmZpZyB0cHM2NTk0X3NwaV9y
ZWdtYXBfY29uZmlnID0gewo+ICAJLnVzZV9zaW5nbGVfd3JpdGUgPSB0cnVlLAo+ICB9Owo+ICAK
PiArc3RhdGljIGNvbnN0IHN0cnVjdCB0cHM2NTk0X21hdGNoX2RhdGEgbWF0Y2hfZGF0YVtdID0g
ewo+ICsJW1RQUzY1OTRdID0ge1RQUzY1OTQsICZ0cHM2NTk0X3NwaV9yZWdtYXBfY29uZmlnfSwK
PiArCVtUUFM2NTkzXSA9IHtUUFM2NTkzLCAmdHBzNjU5NF9zcGlfcmVnbWFwX2NvbmZpZ30sCj4g
KwlbTFA4NzY0XSA9IHtMUDg3NjQsICZ0cHM2NTk0X3NwaV9yZWdtYXBfY29uZmlnfSwKCkFzIGFi
b3ZlLgoKPiArfTsKPiArCj4gIHN0YXRpYyBjb25zdCBzdHJ1Y3Qgb2ZfZGV2aWNlX2lkIHRwczY1
OTRfc3BpX29mX21hdGNoX3RhYmxlW10gPSB7Cj4gLQl7IC5jb21wYXRpYmxlID0gInRpLHRwczY1
OTQtcTEiLCAuZGF0YSA9ICh2b2lkICopVFBTNjU5NCwgfSwKPiAtCXsgLmNvbXBhdGlibGUgPSAi
dGksdHBzNjU5My1xMSIsIC5kYXRhID0gKHZvaWQgKilUUFM2NTkzLCB9LAo+IC0JeyAuY29tcGF0
aWJsZSA9ICJ0aSxscDg3NjQtcTEiLCAgLmRhdGEgPSAodm9pZCAqKUxQODc2NCwgIH0sCj4gKwl7
IC5jb21wYXRpYmxlID0gInRpLHRwczY1OTQtcTEiLCAuZGF0YSA9ICZtYXRjaF9kYXRhW1RQUzY1
OTRdLCB9LAo+ICsJeyAuY29tcGF0aWJsZSA9ICJ0aSx0cHM2NTkzLXExIiwgLmRhdGEgPSAmbWF0
Y2hfZGF0YVtUUFM2NTkzXSwgfSwKPiArCXsgLmNvbXBhdGlibGUgPSAidGksbHA4NzY0LXExIiwg
IC5kYXRhID0gJm1hdGNoX2RhdGFbTFA4NzY0XSwgfSwKPiAgCXt9Cj4gIH07Cj4gIE1PRFVMRV9E
RVZJQ0VfVEFCTEUob2YsIHRwczY1OTRfc3BpX29mX21hdGNoX3RhYmxlKTsKPiBAQCAtOTAsNiAr
OTYsNyBAQCBzdGF0aWMgaW50IHRwczY1OTRfc3BpX3Byb2JlKHN0cnVjdCBzcGlfZGV2aWNlICpz
cGkpCj4gIAlzdHJ1Y3QgZGV2aWNlICpkZXYgPSAmc3BpLT5kZXY7Cj4gIAlzdHJ1Y3QgdHBzNjU5
NCAqdHBzOwo+ICAJY29uc3Qgc3RydWN0IG9mX2RldmljZV9pZCAqbWF0Y2g7Cj4gKwljb25zdCBz
dHJ1Y3QgdHBzNjU5NF9tYXRjaF9kYXRhICptZGF0YTsKPiAgCj4gIAl0cHMgPSBkZXZtX2t6YWxs
b2MoZGV2LCBzaXplb2YoKnRwcyksIEdGUF9LRVJORUwpOwo+ICAJaWYgKCF0cHMpCj4gQEAgLTEw
MSwxNCArMTA4LDE1IEBAIHN0YXRpYyBpbnQgdHBzNjU5NF9zcGlfcHJvYmUoc3RydWN0IHNwaV9k
ZXZpY2UgKnNwaSkKPiAgCXRwcy0+cmVnID0gc3BpX2dldF9jaGlwc2VsZWN0KHNwaSwgMCk7Cj4g
IAl0cHMtPmlycSA9IHNwaS0+aXJxOwo+ICAKPiAtCXRwcy0+cmVnbWFwID0gZGV2bV9yZWdtYXBf
aW5pdChkZXYsIE5VTEwsIHNwaSwgJnRwczY1OTRfc3BpX3JlZ21hcF9jb25maWcpOwo+IC0JaWYg
KElTX0VSUih0cHMtPnJlZ21hcCkpCj4gLQkJcmV0dXJuIGRldl9lcnJfcHJvYmUoZGV2LCBQVFJf
RVJSKHRwcy0+cmVnbWFwKSwgIkZhaWxlZCB0byBpbml0IHJlZ21hcFxuIik7Cj4gLQo+ICAJbWF0
Y2ggPSBvZl9tYXRjaF9kZXZpY2UodHBzNjU5NF9zcGlfb2ZfbWF0Y2hfdGFibGUsIGRldik7Cj4g
IAlpZiAoIW1hdGNoKQo+ICAJCXJldHVybiBkZXZfZXJyX3Byb2JlKGRldiwgLUVJTlZBTCwgIkZh
aWxlZCB0byBmaW5kIG1hdGNoaW5nIGNoaXAgSURcbiIpOwo+IC0JdHBzLT5jaGlwX2lkID0gKHVu
c2lnbmVkIGxvbmcpbWF0Y2gtPmRhdGE7Cj4gKwltZGF0YSA9IChzdHJ1Y3QgdHBzNjU5NF9tYXRj
aF9kYXRhICopbWF0Y2gtPmRhdGE7Cj4gKwl0cHMtPmNoaXBfaWQgPSBtZGF0YS0+Y2hpcF9pZDsK
PiArCj4gKwl0cHMtPnJlZ21hcCA9IGRldm1fcmVnbWFwX2luaXQoZGV2LCBOVUxMLCBzcGksIG1k
YXRhLT5jb25maWcpOwo+ICsJaWYgKElTX0VSUih0cHMtPnJlZ21hcCkpCj4gKwkJcmV0dXJuIGRl
dl9lcnJfcHJvYmUoZGV2LCBQVFJfRVJSKHRwcy0+cmVnbWFwKSwgIkZhaWxlZCB0byBpbml0IHJl
Z21hcFxuIik7Cj4gIAo+ICAJY3JjOF9wb3B1bGF0ZV9tc2IodHBzNjU5NF9zcGlfY3JjX3RhYmxl
LCBUUFM2NTk0X0NSQzhfUE9MWU5PTUlBTCk7Cj4gIAo+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2xp
bnV4L21mZC90cHM2NTk0LmggYi9pbmNsdWRlL2xpbnV4L21mZC90cHM2NTk0LmgKPiBpbmRleCAx
NjU0M2ZkNGQuLmQ3ODFlMGZlMyAxMDA2NDQKPiAtLS0gYS9pbmNsdWRlL2xpbnV4L21mZC90cHM2
NTk0LmgKPiArKysgYi9pbmNsdWRlL2xpbnV4L21mZC90cHM2NTk0LmgKPiBAQCAtMTMzNyw2ICsx
MzM3LDE3IEBAIHN0cnVjdCB0cHM2NTk0IHsKPiAgCXN0cnVjdCByZWdtYXBfaXJxX2NoaXBfZGF0
YSAqaXJxX2RhdGE7Cj4gIH07Cj4gIAo+ICsvKioKPiArICogc3RydWN0IHRwczY1OTRfbWF0Y2hf
ZGF0YSAtIG9mIG1hdGNoIGRhdGEgb2YgUE1JQwo+ICsgKgo+ICsgKiBAY2hpcF9pZDogY2hpcCBJ
RCBvZiBQTUlDCj4gKyAqIEBjb25maWc6IHJlZ21hcCBjb25maWcgb2YgUE1JQwo+ICsgKi8KPiAr
c3RydWN0IHRwczY1OTRfbWF0Y2hfZGF0YSB7Cj4gKwl1bnNpZ25lZCBsb25nIGNoaXBfaWQ7Cj4g
Kwljb25zdCBzdHJ1Y3QgcmVnbWFwX2NvbmZpZyAqY29uZmlnOwo+ICt9Owo+ICsKPiAgZXh0ZXJu
IGNvbnN0IHN0cnVjdCByZWdtYXBfYWNjZXNzX3RhYmxlIHRwczY1OTRfdm9sYXRpbGVfdGFibGU7
Cj4gIGV4dGVybiBjb25zdCBzdHJ1Y3QgcmVnbWFwX2FjY2Vzc190YWJsZSB0cHM2NTIyNF92b2xh
dGlsZV90YWJsZTsKPiAgCj4gLS0gCj4gMi4yNS4xCj4gCgotLSAKTGVlIEpvbmVzIFvmnY7nkLzm
lq9dCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51
eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVh
ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1h
cm0ta2VybmVsCg==