From: Jakub Kicinski <kuba@kernel.org>
To: Jijie Shao <shaojijie@huawei.com>
Cc: <yisen.zhuang@huawei.com>, <salil.mehta@huawei.com>,
<davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<jiri@resnulli.us>, <horms@kernel.org>, <rkannoth@marvell.com>,
<shenjian15@huawei.com>, <wangjie125@huawei.com>,
<liuyonglong@huawei.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V6 net-next 3/4] net: hns3: dump more reg info based on ras mod
Date: Thu, 28 Mar 2024 19:11:30 -0700 [thread overview]
Message-ID: <20240328191130.47242c8f@kernel.org> (raw)
In-Reply-To: <20240327114330.1826631-4-shaojijie@huawei.com>
On Wed, 27 Mar 2024 19:43:29 +0800 Jijie Shao wrote:
> + }, {
> + .reg_name = "MIB_TX/RX_BAD_PKTS",
> + .reg_offset_group = {19, 18, 29, 28},
> + .group_size = 4
> + }, {
> + .reg_name = "MIB_TX/RX_GOOD_PKTS",
> + .reg_offset_group = {21, 20, 31, 30},
> + .group_size = 4
> + }, {
> + .reg_name = "MIB_TX/RX_TOTAL_PKTS",
> + .reg_offset_group = {23, 22, 33, 32},
> + .group_size = 4
> + }, {
> + .reg_name = "MIB_TX/RX_PAUSE_PKTS",
> + .reg_offset_group = {25, 24, 35, 34},
> + .group_size = 4
> + }, {
> + .reg_name = "MIB_TX_ERR_ALL_PKTS",
> + .reg_offset_group = {27, 26},
> + .group_size = 2
> + }, {
> + .reg_name = "MIB_RX_FCS_ERR_PKTS",
> + .reg_offset_group = {37, 36},
> + .group_size = 2
These seem to be duplicating standard stats from rtnl_link_stats64,
ethtool_pause_stats, ethtool_eth_mac_stats, etc.
You can add device specific stats, but please don't duplicate
stats for which we have standard APIs.
next prev parent reply other threads:[~2024-03-29 2:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 11:43 [PATCH V6 net-next 0/4] Support some features for the HNS3 ethernet driver Jijie Shao
2024-03-27 11:43 ` [PATCH V6 net-next 1/4] net: hns3: add command queue trace for hns3 Jijie Shao
2024-03-27 11:43 ` [PATCH V6 net-next 2/4] net: hns3: move constants from hclge_debugfs.h to hclge_debugfs.c Jijie Shao
2024-03-27 11:43 ` [PATCH V6 net-next 3/4] net: hns3: dump more reg info based on ras mod Jijie Shao
2024-03-29 2:11 ` Jakub Kicinski [this message]
2024-03-29 10:34 ` Jijie Shao
2024-03-29 15:15 ` Jakub Kicinski
2024-03-30 2:35 ` Jijie Shao
2024-03-30 2:35 ` Jijie Shao
2024-03-30 2:35 ` Jijie Shao
2024-04-02 3:39 ` Jakub Kicinski
2024-03-27 11:43 ` [PATCH V6 net-next 4/4] net: hns3: add support to query scc version by devlink info Jijie Shao
2024-03-29 2:07 ` Jakub Kicinski
2024-03-30 2:30 ` Jijie Shao
2024-03-30 2:30 ` Jijie Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240328191130.47242c8f@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rkannoth@marvell.com \
--cc=salil.mehta@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=wangjie125@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.