From: Jakub Kicinski <kuba@kernel.org>
To: "Paweł Dembicki" <paweldembicki@gmail.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Stefan Eichenberger <eichest@gmail.com>,
Dimitri Fedrau <dima.fedrau@gmail.com>,
Kory Maincent <kory.maincent@bootlin.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Shay Agroskin <shayagr@amazon.com>,
Ahmed Zaki <ahmed.zaki@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/3] net: ethtool: Add impedance mismatch result code to cable test
Date: Fri, 29 Mar 2024 08:10:58 -0700 [thread overview]
Message-ID: <20240329081058.15ee0f1d@kernel.org> (raw)
In-Reply-To: <CAJN1KkxcX9dfhMVvQCFLosTgO5U2tAjvHEO-prViSacOB6DQRg@mail.gmail.com>
On Fri, 29 Mar 2024 10:31:10 +0100 Paweł Dembicki wrote:
> > I'm not a cable expert but going purely by the language
> > abnormal != mismatch. Mismatch indicates there are two
> > values we are comparing.
>
> Impedance mismatch can be detected because some parts of the cable may
> have different (abnormal) impedance, causing reflections at those
> points. Ethernet cables should have a characteristic impedance of 100
> Ohms, so any mismatch from this value is considered abnormal.
I see, makes sense.
> I can provide a rephrased version if the commit description was not
> detailed enough.
That'd be great. Or maybe even better a short comment above the enum
entry?
next prev parent reply other threads:[~2024-03-29 15:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 16:29 [PATCH net-next v2 1/3] net: phy: marvell: add basic support of 88E308X/88E609X family Pawel Dembicki
2024-03-27 16:29 ` [PATCH net-next v2 2/3] net: ethtool: Add impedance mismatch result code to cable test Pawel Dembicki
2024-03-29 2:02 ` Jakub Kicinski
2024-03-29 9:31 ` Paweł Dembicki
2024-03-29 15:10 ` Jakub Kicinski [this message]
2024-03-27 16:29 ` [PATCH net-next v2 3/3] net: phy: marvell: implement cable-test for 88E308X/88E609X family Pawel Dembicki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240329081058.15ee0f1d@kernel.org \
--to=kuba@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dima.fedrau@gmail.com \
--cc=edumazet@google.com \
--cc=eichest@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kory.maincent@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paweldembicki@gmail.com \
--cc=shayagr@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.