All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Mars <paul.mars@canonical.com>
To: linux-trace-devel@vger.kernel.org
Cc: Paul Mars <paul.mars@canonical.com>
Subject: [PATCH] libtraceevent: Fix tests running on big endian arch
Date: Fri, 29 Mar 2024 15:25:45 +0100	[thread overview]
Message-ID: <20240329142544.845408-1-paul.mars@canonical.com> (raw)

Tests running on big endian arch (tested on s390x) where failing due to:

- a typo in CPUMASK_BYTEPN.
- a missing call to tep_set_file_bigendian when initializing the test
  suite.

Thanks to Mate Kukri <mate.kukri@canonical.com>.

---
 utest/traceevent-utest.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/utest/traceevent-utest.c b/utest/traceevent-utest.c
index 041843e..b95e478 100644
--- a/utest/traceevent-utest.c
+++ b/utest/traceevent-utest.c
@@ -216,7 +216,7 @@ DECL_CPUMASK_EVENT_DATA(bytep2, 0x00, 0x00, 0x00, 0x00, 0x00, 0x80, 0x00, 0x01);
 #define CPUMASK_BYTEP2_FMT "cpumask=0,23"
 
 DECL_CPUMASK_EVENT_DATA(bytepn, 0x80, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01);
-#define CPUMASK_BYTEPN     "ARRAY[80, 00, 00, 00, 00, 00, 80, 01]"
+#define CPUMASK_BYTEPN     "ARRAY[80, 00, 00, 00, 00, 00, 00, 01]"
 #define CPUMASK_BYTEPN_FMT "cpumask=0,63"
 #endif
 
@@ -392,6 +392,9 @@ static int test_suite_init(void)
 	test_tep = tep_alloc();
 	if (!test_tep)
 		return 1;
+#if __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__
+	tep_set_file_bigendian(test_tep, TEP_BIG_ENDIAN);
+#endif
 	return 0;
 }
 
-- 
2.34.1


             reply	other threads:[~2024-03-29 14:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-29 14:25 Paul Mars [this message]
2024-03-29 16:58 ` [PATCH] libtraceevent: Fix tests running on big endian arch Steven Rostedt
2024-04-02  8:34   ` [PATCH] " Paul Mars

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240329142544.845408-1-paul.mars@canonical.com \
    --to=paul.mars@canonical.com \
    --cc=linux-trace-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.