All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Alexis Lothoré via buildroot" <buildroot@buildroot.org>
Cc: "Bernd Kuhls" <bernd@kuhls.net>,
	"Alexis Lothoré" <alexis.lothore@bootlin.com>,
	"Nicolas Carrier" <nicolas.carrier@nav-timing.safrangroup.com>
Subject: Re: [Buildroot] [PATCH 0/3] package/pppd: fix pppd startup with upstream patches
Date: Wed, 10 Apr 2024 23:20:20 +0200	[thread overview]
Message-ID: <20240410232020.623f20ed@windsurf> (raw)
In-Reply-To: <20240329143138.214780-1-alexis.lothore@bootlin.com>

Hello Alexis,

On Fri, 29 Mar 2024 15:31:35 +0100
Alexis Lothoré via buildroot <buildroot@buildroot.org> wrote:

> The issue has already been detected and fixed upstream (see [1]) and is
> expected to be released on a v2.5.1, but this release seems to be stalled
> for now (see [2]). A mere bump of the package is then not currently
> possible, so I am proposing a pick of the 3 relevant patches to fix this
> startup issue, both for master and 2024.02.x

Thanks for this set of patches. However, the way you formatted the
patches is not quite what we expect.

We expect you to:

 (1) git cherry-pick the commits

 (2) Add an Upstream: tag at the end of the commit message, following
     by your Signed-off-by line

 (3) Use "git format-patch -N" to format the 3 patches

Right now you have more or less "wrapped" the patches into commits you
are the author of, and your Signed-off-by line is missing.

Look at package/waylandpp/0001-add-missing-cstdint-include.patch for an
example of a properly formatted patch. Sergei Trofimovich is the
original author, Bernd Kuhls is the person who brought the patch into
Buildroot.

Could you rework your patch series accordingly?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2024-04-10 21:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-29 14:31 [Buildroot] [PATCH 0/3] package/pppd: fix pppd startup with upstream patches Alexis Lothoré via buildroot
2024-03-29 14:31 ` [Buildroot] [PATCH 1/3] package/pppd: revert lock path Alexis Lothoré via buildroot
2024-03-29 14:31 ` [Buildroot] [PATCH 2/3] package/pppd: add mkdir recursive Alexis Lothoré via buildroot
2024-03-29 14:31 ` [Buildroot] [PATCH 3/3] package/pppd: create rundir when it is missing Alexis Lothoré via buildroot
2024-04-10 21:20 ` Thomas Petazzoni via buildroot [this message]
2024-04-11  8:49   ` [Buildroot] [PATCH 0/3] package/pppd: fix pppd startup with upstream patches Alexis Lothoré via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240410232020.623f20ed@windsurf \
    --to=buildroot@buildroot.org \
    --cc=alexis.lothore@bootlin.com \
    --cc=bernd@kuhls.net \
    --cc=nicolas.carrier@nav-timing.safrangroup.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.