All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: Shresth Prasad <shresthprasad7@gmail.com>
Cc: vincenzo.mezzela@gmail.com, gregkh@linuxfoundation.org,
	Javier Carrasco <javier.carrasco.cruz@gmail.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Julia Lawall <julia.lawall@inria.fr>,
	linux-kernel@vger.kernel.org, rafael@kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] drivers: use __free attribute instead of of_node_put()
Date: Fri, 19 Apr 2024 19:26:42 +0100	[thread overview]
Message-ID: <20240419182642.b7li4mlnvryephhg@bogus> (raw)
In-Reply-To: <CAE8VWiLErhCkD9w+Rbh8mTnRQs-4iJDBrWdVXXFFFDQ3yeTaLg@mail.gmail.com>

On Fri, Apr 19, 2024 at 11:16:37PM +0530, Shresth Prasad wrote:
> > Please fix the subject line to be "backlight: <driver>: ...". I came
> > very close to deleting this patch without reading it ;-) .
> 
> Really sorry about that, I'll fix it.
> 
> > Do we need to get dev->of_node at all? The device, which we are
> > borrowing, already owns a reference to the node so I don't see
> > any point in this function taking an extra one.
> >
> > So why not simply make this:
> >
> >     struct device_node *np = dev->of_node;
> 
> Looking at it again, I'm not sure why the call to of_node_put is there in
> the first place. I think removing it would be fine.
> 
> I'll fix both of these issues and send a patch v2.

I assume you are using lore "Reply using the --to, --cc, and..." option
or something similar.

You seem to have mixed up 2 different message ID. I was not able to make
any sense of this email.

You have wrongly used [1] but you really want [2]. I think both have
very similar $subject and hence the confusion. Another reason
why getting subject right is very important on the mailing list.

--
Regards,
Sudeep

[1] 20240419131956.665769-1-vincenzo.mezzela@gmail.com
(https://lore.kernel.org/all/20240419131956.665769-1-vincenzo.mezzela@gmail.com/)
[2] 20240419111613.GA12884@aspen.lan
https://lore.kernel.org/all/20240419111613.GA12884@aspen.lan/

  reply	other threads:[~2024-04-19 18:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-19 17:46 [PATCH] drivers: use __free attribute instead of of_node_put() Shresth Prasad
2024-04-19 18:26 ` Sudeep Holla [this message]
2024-04-19 18:39   ` Shresth Prasad
  -- strict thread matches above, loose matches on Subject: below --
2024-04-19 13:19 Vincenzo Mezzela
2024-04-19 14:01 ` Sudeep Holla
2024-04-22  8:27   ` Vincenzo Mezzela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240419182642.b7li4mlnvryephhg@bogus \
    --to=sudeep.holla@arm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=javier.carrasco.cruz@gmail.com \
    --cc=julia.lawall@inria.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=shresthprasad7@gmail.com \
    --cc=skhan@linuxfoundation.org \
    --cc=vincenzo.mezzela@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.