From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 00/35] mempool: rework memory allocation Date: Fri, 20 May 2016 11:09:08 +0200 Message-ID: <2024350.zjYMIZz45a@xps13> References: <1460629199-32489-1-git-send-email-olivier.matz@6wind.com> <36612895.rbhkJEDisP@xps13> <9d61a426-f580-b39e-1e38-7a30a4937324@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Olivier Matz , dev@dpdk.org To: Panu Matilainen Return-path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 5A178ADD8 for ; Fri, 20 May 2016 11:09:10 +0200 (CEST) Received: by mail-wm0-f48.google.com with SMTP id n129so262770068wmn.1 for ; Fri, 20 May 2016 02:09:10 -0700 (PDT) In-Reply-To: <9d61a426-f580-b39e-1e38-7a30a4937324@redhat.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-05-20 11:42, Panu Matilainen: > Just noticed this series "breaks" --no-huge as a regular user, commit > 593a084afc2b to be exact: > > mmap(NULL, 4194304, PROT_READ|PROT_WRITE, > MAP_PRIVATE|MAP_ANONYMOUS|MAP_LOCKED, 0, 0) = -1 EAGAIN (Resource > temporarily unavailable) > write(1, "EAL: rte_eal_hugepage_init: mmap"..., 76EAL: > rte_eal_hugepage_init: mmap() failed: Resource temporarily unavailable > > "Breaks" in quotes because I guess it always was broken (as the > non-locked pages might not be in physical memory) and because its > possible to adjust resourse limits to allow the operation to succeed. > If you're root, that is. > > I was just looking into making the test-suite runnable by a regular user > with no special privileges, I have the same dream, to make sure every developer can run the unit tests easily and quickly. > primarily to make it possible to run the > testsuite as part of rpm package builds (in %check), and no special > setup or extra privileges can be assumed there. Such tests are of course > of limited coverage but still better than nothing, and --no-huge was my > ticket there. Talk about bad timing :) > > It'd be fine to have limited subset of tests to run when non-privileged > but since this one lives inside rte_eal_init() it practically prevents > everything, unless I'm missing some other magic switch or such. Thoughts? This change was done for mbuf allocation because they are passed to the hardware. We should not have any hardware constraint in the unit tests. So I'd say it is a requirement for the memory rework. We must be capable to allocate some locked pages if required, and some standard pages for other usages. Please jump in this thread: http://dpdk.org/ml/archives/dev/2016-April/037444.html