All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] gfs2: Don't pack struct lm_lockname
Date: Thu, 16 Mar 2017 10:11:53 -0400 (EDT)	[thread overview]
Message-ID: <2024769933.2970459.1489673513304.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1489603738-27603-1-git-send-email-agruenba@redhat.com>

----- Original Message -----
| As per a suggestion by Linus, don't pack struct lm_lockname: we did that
| because the struct used as a rhashtable key, but packing tells the
| compiler that the 64-bit fields in the struct may be unaligned, causing
| it to generate worse code on some architectures.  Instead, rearrange the
| fields in the struct so that there is no padding between fields, and
| exclude any tail padding from the hash key size.
| 
| Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
| ---

Hi,

Thanks. This is now applied to the for-next branch of the linux-gfs2 tree:
https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/?h=for-next&id=972b044eeca582ef173d063773e292bd9e8633d6

Regards,

Bob Peterson
Red Hat File Systems



      parent reply	other threads:[~2017-03-16 14:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-15 18:48 [Cluster-devel] [PATCH] gfs2: Don't pack struct lm_lockname Andreas Gruenbacher
2017-03-16 12:18 ` Andrew Price
2017-03-16 14:11 ` Bob Peterson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024769933.2970459.1489673513304.JavaMail.zimbra@redhat.com \
    --to=rpeterso@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.