From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3943AC433E9 for ; Fri, 12 Mar 2021 09:02:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0E1AD65007 for ; Fri, 12 Mar 2021 09:02:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232638AbhCLJBp (ORCPT ); Fri, 12 Mar 2021 04:01:45 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:26823 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232616AbhCLJBm (ORCPT ); Fri, 12 Mar 2021 04:01:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615539701; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kZgi8ac9iRjWqxn6NnFC7WOkmA3vCT3GJ0uAoFy454Y=; b=NEgCV/pHoSgDm4BYpy0p1mTjKYY/Jp0wVR5GswzvG/VBM/IDP1wNHbadmghqTGlxvgFLw+ /MbByJ7/rCdX18VGPSwnfTAwlSs9hckcZTBjwBr9iHv5XyPmWLlgpkgo7wXzeEl4DCUeh9 8uLtU/vpR+aiWh4oXLNFKJx2RGOxc+Q= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-580-3rk5lSl7O5qjq-AoOjETww-1; Fri, 12 Mar 2021 04:01:39 -0500 X-MC-Unique: 3rk5lSl7O5qjq-AoOjETww-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6C7A518397A1; Fri, 12 Mar 2021 09:01:38 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-118-152.rdu2.redhat.com [10.10.118.152]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7A96F5C234; Fri, 12 Mar 2021 09:01:37 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <134696.1615510534@turing-police> References: <134696.1615510534@turing-police> <109018.1615463088@turing-police> <91190.1615444370@turing-police> <972381.1615459754@warthog.procyon.org.uk> <1486567.1615464259@warthog.procyon.org.uk> To: =?us-ascii?Q?Valdis_Kl=3D=3Futf-8=3FQ=3F=3Dc4=3D93=3F=3Dtnieks?= Cc: dhowells@redhat.com, David Woodhouse , keyrings@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: 'make O=' indigestion with module signing MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 12 Mar 2021 09:01:36 +0000 Message-ID: <2026575.1615539696@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Precedence: bulk List-ID: X-Mailing-List: keyrings@vger.kernel.org Valdis Kl=C4=93tnieks wrote: > So the root cause was: 'make mrproper doesn't clean certs/' out enough, > and this chunk of certs/Makefile > ... > I admit not being sure how (or if) this should be fixed It's tricky because CONFIG_MODULE_SIG_KEY may not point to a file, let alon= e a file that was autogenerated - it can be given a PKCS#11 URI, for instance. = I had to put in the autogeneration based on a magic config string value to st= op randconfig blowing up - but it only does the autogeneration if you don't put in your own file there before building. Possibly I can add something like: clean-files :=3D signing_key.pem x509.genkey inside the ifeq ($(CONFIG_MODULE_SIG_KEY),"certs/signing_key.pem") ... endif section. David