From: Peter Krystad <peter.krystad at linux.intel.com>
To: mptcp at lists.01.org
Subject: [MPTCP] Re: [PATCH 0/6] IPv6 support
Date: Mon, 04 Nov 2019 16:52:15 -0800 [thread overview]
Message-ID: <202dae18a2f0e594d468772c874107fac0ddccdd.camel@linux.intel.com> (raw)
In-Reply-To: 89ee912f38069b1a757de76b71fcf5f8a8eb6caa.camel@redhat.com
[-- Attachment #1: Type: text/plain, Size: 1488 bytes --]
Hi Paolo -
On Thu, 2019-10-31 at 10:02 +0100, Paolo Abeni wrote:
> On Wed, 2019-10-30 at 16:38 -0700, Peter Krystad wrote:
> > Implemented support for IPv6. selftests pass with ipv6=true,
>
> Nice!
>
> > but they take twice as long to run...
>
> Yep, that is expected, right? ;)
Right.
>
> > With re-factoring the addition of IPv6 is very clean but I did not
> > split files yet as it will be hard to squash any changes after the
> > such a split.
>
> We still need the Kconfig boilerplate, right? something alike:
>
> ---
> diff --git a/net/mptcp/Kconfig b/net/mptcp/Kconfig
> index f21190a4f7e9..3fa6d91f57ee 100644
> --- a/net/mptcp/Kconfig
> +++ b/net/mptcp/Kconfig
> @@ -9,3 +9,8 @@ config MPTCP
> uses the TCP protocol, and TCP options carry header
> information for
> MPTCP.
>
> +config MPTCP_IPV6
> + bool "IPv6 support form Multipath TCP"
> + depends on MPTCP
> + select IPV6
> + default y
> ---
>
> and than replace IS_ENABLED(IPV6) with CONFIG_MPTCP_IPV6.
Indeed we do, I will submit a patchset that does that will need to
be merged before the v2 IPv6 patchset (coming tomorrow).
> Additinal question: what happens if ipv6 is disabled at boot time
> (ipv6.disable=1 on the kernel command line)?
I believe the initialization in inet6_init() will not run and it will
not be possible to create a socket in the AF_INET6 domain.
Peter.
> Thanks,
>
> Paolo
>
next reply other threads:[~2019-11-05 0:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 0:52 Peter Krystad [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-10-31 9:02 [MPTCP] Re: [PATCH 0/6] IPv6 support Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202dae18a2f0e594d468772c874107fac0ddccdd.camel@linux.intel.com \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.