All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Cc: dev@dpdk.org, konstantin.ananyev@intel.com,
	andrey.chilikin@intel.com, ray.kinsella@intel.com,
	yipeng1.wang@intel.com, sameh.gobriel@intel.com,
	bruce.richardson@intel.com, david.marchand@redhat.com,
	kda@semihalf.com
Subject: Re: [dpdk-dev] [PATCH v3] hash: fix tuple adjustment
Date: Mon, 10 May 2021 15:25:46 +0200	[thread overview]
Message-ID: <2033179.CKzPTzZ2rV@thomas> (raw)
In-Reply-To: <1620301222-209584-1-git-send-email-vladimir.medvedkin@intel.com>

06/05/2021 13:40, Vladimir Medvedkin:
> rte_thash_adjust_tuple() uses random to generate a new subtuple if
> fn() callback reports about collision. In some cases random changes
> the subtuple in a way that after complementary bits are applied the
> original tuple is obtained. This patch replaces random with subtuple
> increment.
> 
> Fixes: 28ebff11c2dc ("hash: add predictable RSS")
> Cc: vladimir.medvedkin@intel.com
> 
> Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> Acked-by: Yipeng Wang <yipeng1.wang@intel.com>
> Tested-by: Stanislaw Kardach <kda@semihalf.com>
> Reviewed-by: Stanislaw Kardach <kda@semihalf.com>

Applied, thanks




      reply	other threads:[~2021-05-10 13:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-04 14:07 [dpdk-dev] [PATCH] hash: fix tuple adjustment Vladimir Medvedkin
2021-05-04 14:25 ` [dpdk-dev] [PATCH v2] " Vladimir Medvedkin
2021-05-05 10:16   ` Thomas Monjalon
2021-05-05 17:57   ` Wang, Yipeng1
2021-05-05 19:13   ` Stanislaw Kardach
2021-05-06 11:40   ` [dpdk-dev] [PATCH v3] " Vladimir Medvedkin
2021-05-10 13:25     ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2033179.CKzPTzZ2rV@thomas \
    --to=thomas@monjalon.net \
    --cc=andrey.chilikin@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=kda@semihalf.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=ray.kinsella@intel.com \
    --cc=sameh.gobriel@intel.com \
    --cc=vladimir.medvedkin@intel.com \
    --cc=yipeng1.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.