From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH 2/6] libxl: introduce libxl__device_generic_add_t
Date: Mon, 2 Apr 2012 17:18:20 +0100 [thread overview]
Message-ID: <20345.53580.464371.690500@mariner.uk.xensource.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1203301144510.15151@kaball-desktop>
Stefano Stabellini writes ("Re: [Xen-devel] [PATCH 2/6] libxl: introduce libxl__device_generic_add_t"):
> On Tue, 27 Mar 2012, Ian Jackson wrote:
> > Can we avoid introducing more of these transaction loops using goto ?
>
> I am afraid I actually prefer the simple goto scheme than the convoluted
> code below.
I really can't stomach any more of these gotos. If you don't want to
abstract it away, can't you at least write the loop as a loop with
for() or while() ?
Ian.
next prev parent reply other threads:[~2012-04-02 16:18 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 13:58 [PATCH 0/6] qdisk local attach Stefano Stabellini
2012-03-27 13:59 ` [PATCH 1/6] libxl: libxl_device_disk_local_attach return a new libxl_device_disk Stefano Stabellini
2012-03-27 14:07 ` Ian Campbell
2012-03-30 10:42 ` Stefano Stabellini
2012-03-27 16:21 ` Ian Jackson
2012-03-30 10:43 ` Stefano Stabellini
2012-03-27 13:59 ` [PATCH 2/6] libxl: introduce libxl__device_generic_add_t Stefano Stabellini
2012-03-27 14:04 ` Ian Campbell
2012-03-30 10:44 ` Stefano Stabellini
2012-03-27 16:50 ` Ian Jackson
2012-03-30 10:46 ` Stefano Stabellini
2012-04-02 16:18 ` Ian Jackson [this message]
2012-04-03 12:03 ` Stefano Stabellini
2012-03-27 13:59 ` [PATCH 3/6] libxl: add an xs_transaction_t parameter to two libxl functions Stefano Stabellini
2012-03-27 14:17 ` Ian Campbell
2012-03-27 16:50 ` Ian Jackson
2012-03-27 13:59 ` [PATCH 4/6] libxl: introduce libxl__device_disk_add_t Stefano Stabellini
2012-03-27 13:59 ` [PATCH 5/6] libxl: introduce libxl__alloc_vdev Stefano Stabellini
2012-03-27 14:21 ` Ian Campbell
2012-03-27 17:21 ` Ian Jackson
2012-03-30 11:43 ` Stefano Stabellini
2012-03-30 12:14 ` Ian Campbell
2012-03-30 12:57 ` Stefano Stabellini
2012-03-27 17:19 ` Ian Jackson
2012-03-30 11:57 ` Stefano Stabellini
2012-03-30 14:17 ` Ian Jackson
2012-03-30 15:23 ` Stefano Stabellini
2012-04-02 16:15 ` Ian Jackson
2012-04-03 13:15 ` Stefano Stabellini
2012-04-03 13:17 ` Ian Jackson
2012-04-03 14:19 ` Stefano Stabellini
2012-04-03 14:24 ` Ian Jackson
2012-04-10 17:37 ` Stefano Stabellini
2012-04-11 15:49 ` Stefano Stabellini
2012-03-27 13:59 ` [PATCH 6/6] xl/libxl: implement QDISK libxl_device_disk_local_attach Stefano Stabellini
2012-03-27 17:20 ` Ian Jackson
2012-03-30 10:50 ` Stefano Stabellini
2012-03-30 13:47 ` Ian Jackson
2012-03-30 14:55 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20345.53580.464371.690500@mariner.uk.xensource.com \
--to=ian.jackson@eu.citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.