From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH 04/20] autoconf: New test for openpty et al.
Date: Mon, 16 Apr 2012 11:35:14 +0100
Message-ID: <20363.62946.40242.576539@mariner.uk.xensource.com>
References: <1334342414-10289-1-git-send-email-ian.jackson@eu.citrix.com>
	<1334342414-10289-5-git-send-email-ian.jackson@eu.citrix.com>
	<B3BE1540-C11A-4403-8909-3FB4F7135F14@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <B3BE1540-C11A-4403-8909-3FB4F7135F14@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

Roger Pau Monne writes ("Re: [Xen-devel] [PATCH 04/20] autoconf: New test for openpty et al."):
> > +#ifdef INCLUDE_LIBUTIL_H
> > +#include INCLUDE_LIBUTIL_H
> > +#endif
> > +
> 
> Maybe I'm missing something, because this autoconf macros are hard to read, but shouldn't you add something like
> 
> #undef INCLUDE_LIBUTIL_H
> 
> to tools/config.h.in, so the generated config.h contains this define?

Yes.  This is normally done by autoheader, which is normally done by
autogen.sh.  But I see that we aren't running autoheader.  I will see
about fixing that.

Ian.