From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3 2/2] eal: restrict ctrl threads to startup cpu affinity Date: Thu, 07 Mar 2019 19:23:02 +0100 Message-ID: <2037140.URYxlzVuUZ@xps> References: <1550151042-9764-1-git-send-email-david.marchand@redhat.com> <20190225083359.uzvwejkej3elyqdh@platinum> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Olivier Matz , "Burakov, Anatoly" , ktraynor@redhat.com, stable@dpdk.org To: David Marchand Return-path: In-Reply-To: <20190225083359.uzvwejkej3elyqdh@platinum> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 25/02/2019 09:33, Olivier Matz: > On Wed, Feb 20, 2019 at 04:01:33PM +0000, Burakov, Anatoly wrote: > > On 19-Feb-19 8:41 PM, David Marchand wrote: > > > Spawning the ctrl threads on anything that is not part of the eal > > > coremask is not that polite to the rest of the system, especially > > > when you took good care to pin your processes on cpu resources with > > > tools like taskset (linux) / cpuset (freebsd). > > > > > > Rather than introduce yet another eal options to control on which cpu > > > those ctrl threads are created, let's take the startup cpu affinity > > > as a reference and remove the eal coremask from it. > > > If no cpu is left, then we default to the master core. > > > > > > The cpuset is computed once at init before the original cpu affinity > > > is lost. > > > [...] > > > > > > Fixes: d651ee4919cd ("eal: set affinity for control threads") > > > Cc: stable@dpdk.org > > > Signed-off-by: David Marchand > > > --- > > > > Reviewed-by: Anatoly Burakov > > Reviewed-by: Olivier Matz Replaced cpu by uppercase CPU, and applied, thanks