From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 00/10] eal: rte_tailq api cleanup Date: Tue, 10 Mar 2015 12:20:02 +0100 Message-ID: <2038190.P10mg0IX0N@xps13> References: <1425505810-9269-1-git-send-email-david.marchand@6wind.com> <20150306002636.GA6785@neilslaptop.think-freely.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: David Marchand Return-path: In-Reply-To: <20150306002636.GA6785-0o1r3XBGOEbbgkc5XkKeNuvMHUBZFtU3YPYVAmT7z5s@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2015-03-05 19:26, Neil Horman: > On Wed, Mar 04, 2015 at 10:50:00PM +0100, David Marchand wrote: > > This is a first cleanup at trying to remove references to other dpdk libraries > > from eal. > > > > This cleanup is focused on rte_tailq api which has been marked as "for internal > > use" for quite some time now. > > Rather than have a static list in eal for all users of rte_tailq, a new register > > system is introduced. > > This register system uses constructors which have no access to dpdk shared > > memory, so a two step registration is done: first step inserts the requested > > tailq in a local list ("local" in multi process context), then in second step, > > eal init allocates/looks up for a real tailq from shared memory for all elements > > of this local list. > > > > I have tried to think of different cases (libraries loaded before/after eal > > init...). The unit tests have been updated accordingly. > > > > > This all seems pretty reasonable. > > It might make sense to add a deprecation notice for this, since its removing > public macros, but since we're not really doing that until the 2.0 release is > out, I think we can skip it > > For the series > Acked-by: Neil Horman Applied, thanks