From mboxrd@z Thu Jan 1 00:00:00 1970 From: LW@KARO-electronics.de (=?utf-8?Q?Lothar_Wa=C3=9Fmann?=) Date: Wed, 16 May 2012 16:03:51 +0200 Subject: [PATCH] gpio/generic: initialize the shadow of direction register In-Reply-To: <20120516140717.GB3764@S2100-06.ap.freescale.net> References: <1337054198-24674-1-git-send-email-shawn.guo@linaro.org> <20402.798.622618.263780@ipc1.ka-ro> <20120516053301.GB21517@S2100-06.ap.freescale.net> <20403.20214.297216.188300@ipc1.ka-ro> <20120516072859.GE21517@S2100-06.ap.freescale.net> <20403.22671.800713.334846@ipc1.ka-ro> <20403.41495.610333.670008@ipc1.ka-ro> <20120516133850.GA3764@S2100-06.ap.freescale.net> <20403.44198.671025.83880@ipc1.ka-ro> <20120516140717.GB3764@S2100-06.ap.freescale.net> Message-ID: <20403.46023.772833.889330@ipc1.ka-ro> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, Shawn Guo writes: > On Wed, May 16, 2012 at 03:33:26PM +0200, Lothar Wa?mann wrote: > > > I'm not fixing a gpio-mxs problem but a gpio-generic one. Can you help > > > > > Yes, I know. And that's exaclty why you should make sure that you > > don't break other platforms by fixing yours! > > > > > me understand what the new problems could possibly be introduced for > > > other gpio-generic users by the changes? > > > > > Another platform using might be working just _because_ of the "broken" > > behaviour. By fixing that brokenness for your driver you may break > > that other platform. > > > Can you point me any such platform? > _You_ want to introduce a change that will change the behaviour of existing code, so it's _your_ responsibility to make sure that your change doesn't break other users. Those are the current users of bgpio: ./drivers/gpio/gpio-sodaville.c: ret = bgpio_init(&sd->bgpio, &pdev->dev, 4, ./drivers/gpio/gpio-ep93xx.c: err = bgpio_init(bgc, dev, 1, data, NULL, NULL, dir, NULL, false); ./drivers/gpio/gpio-mxc.c: err = bgpio_init(&port->bgc, &pdev->dev, 4, ./drivers/gpio/gpio-mxs.c: err = bgpio_init(&port->bgc, &pdev->dev, 4, You should at least CC: their maintainers to inform them that the code they are relying on will change its behaviour. Lothar Wa?mann -- ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstra?e 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Gesch?ftsf?hrer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info at karo-electronics.de ___________________________________________________________