From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v15 1/4] ethdev: add apis to support access device info Date: Wed, 15 Jul 2015 14:06:48 +0200 Message-ID: <2041754.gAIZiEM3Hs@xps13> References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com> <1436962741.PL5XZBfjSs@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "Wang, Liang-min" Return-path: Received: from mail-wg0-f45.google.com (mail-wg0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 54C68595E for ; Wed, 15 Jul 2015 14:08:01 +0200 (CEST) Received: by wgmn9 with SMTP id n9so31920443wgm.0 for ; Wed, 15 Jul 2015 05:08:01 -0700 (PDT) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-07-15 11:36, Wang, Liang-min: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2015-07-15 10:48, Wang, Liang-min: > > > > > > What means magic? Is it always a device id? > > > > > This field is the same as defined in kernel ethtool data structure. > > > > > > > > Not an excellent argument :) > > > > Actually you didn't answer. > > > > > > > I could not speak for other devices. For igb and ixgbe, it's device id. > > > Based upon literature search, this field is used by device driver to provide > > extra information. > > > What would be your suggestion? > > > > I don't have any suggestion. > > You are defining a new API in DPDK, so our concern must be to check > > that it will be easily understood by users and PMD developers. > > If you don't really know what this field will be for, others won't know. > No, I meant it's device driver dependent. > If I keep the same naming convention following kernel ethtool defined, > and adding comment like "device-specific magic key, such as device-id". > Would that be acceptable from you? OK > This data structure is defined to be compatible with kernel ethtool API, > and magic key is device specific and known to ethtool API users.