Re: [PATCH 1/2] platform: x86: dell-smo8800: Dell Latitude freefall driver (ACPI SMO8800/SMO8810)

From: Valdis.Kletnieks@vt.edu
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: Matthew Garrett <matthew.garrett@nebula.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	linux-kernel@vger.kernel.org,
	platform-driver-x86@vger.kernel.org, linux-doc@vger.kernel.org,
	Sonal Santan <sonal.santan@gmail.com>
Subject: Re: [PATCH 1/2] platform: x86: dell-smo8800: Dell Latitude freefall driver (ACPI SMO8800/SMO8810)
Date: Tue, 20 May 2014 14:02:41 -0400	[thread overview]
Message-ID: <20424.1400608961@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Tue, 20 May 2014 10:56:47 +0200." <201405201056.47726@pali>

[-- Attachment #1: Type: text/plain, Size: 2026 bytes --]

On Tue, 20 May 2014 10:56:47 +0200, Pali Rohár said:

> Hm? Which errors? Here is output from checkpacth:
>
> total: 0 errors, 0 warnings, 276 lines checked
>
> 0001-platform-x86-dell-smo8800-Dell-Latitude-freefall-dri.patch
> has no obvious style problems and is ready for submission.
>
> total: 0 errors, 0 warnings, 181 lines checked
>
> 0002-Documentation-Rename-hpfall.c-freefall.c-fixes-for-D.patch
> has no obvious style problems and is ready for submission.

Hmm.. what tree are you building against?  I wonder if your checkpatch is
a different version than mine (next-20140519).  What I see:

[/usr/src/linux-next] scripts/checkpatch.pl patches/freefall.1
WARNING: Missing a blank line after declarations
#135: FILE: drivers/platform/x86/dell-smo8800.c:41:
+       struct smo8800_device *smo8800 = data;
+       atomic_inc(&smo8800->count);

WARNING: Missing a blank line after declarations
#143: FILE: drivers/platform/x86/dell-smo8800.c:49:
+       struct smo8800_device *smo8800 = data;
+       dev_info(smo8800->dev, "detected free fall\n");

WARNING: Missing a blank line after declarations
#318: FILE: drivers/platform/x86/dell-smo8800.c:224:
+       struct smo8800_device *smo8800 = device->driver_data;
+       free_irq(smo8800->irq, smo8800);

total: 0 errors, 3 warnings, 276 lines checked

patches/freefall.1 has style problems, please review.

[/usr/src/linux-next] scripts/checkpatch.pl patches/freefall.2
WARNING: Missing a blank line after declarations
#126: FILE: Documentation/laptops/freefall.c:47:
+       int fd = open(unload_heads_path, O_RDONLY);
+       if (fd < 0) {

WARNING: Missing a blank line after declarations
#139: FILE: Documentation/laptops/freefall.c:60:
+       int fd = open(path, O_RDWR);
+       if (fd < 0) {

WARNING: Missing a blank line after declarations
#161: FILE: Documentation/laptops/freefall.c:82:
+       const char *str = (seconds == 0) ? "Unparked" : "Parked";
+       write_int(unload_heads_path, seconds*1000);

total: 0 errors, 3 warnings, 181 lines checked

[-- Attachment #2: Type: application/pgp-signature, Size: 848 bytes --]