From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53453)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1b5st7-0003LI-Il
	for qemu-devel@nongnu.org; Thu, 26 May 2016 06:51:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1b5st1-0007vr-MD
	for qemu-devel@nongnu.org; Thu, 26 May 2016 06:51:36 -0400
References: <1463024905-28401-1-git-send-email-bharata@linux.vnet.ibm.com>
	<1463024905-28401-4-git-send-email-bharata@linux.vnet.ibm.com>
	<09a5f97d-8362-80b4-4623-5d125169b0a1@redhat.com>
	<201605261048.u4QAibq4039252@mx0a-001b2d01.pphosted.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <2043b878-3403-1046-6b64-f322a87ff259@redhat.com>
Date: Thu, 26 May 2016 12:51:23 +0200
MIME-Version: 1.0
In-Reply-To: <201605261048.u4QAibq4039252@mx0a-001b2d01.pphosted.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [for-2.7 PATCH v3 03/15] cpu: Reclaim vCPU objects
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: bharata@linux.vnet.ibm.com
Cc: qemu-devel@nongnu.org, mjrosato@linux.vnet.ibm.com, thuth@redhat.com, pkrempa@redhat.com, Zhu Guihua <zhugh.fnst@cn.fujitsu.com>, ehabkost@redhat.com, aik@ozlabs.ru, armbru@redhat.com, agraf@suse.de, borntraeger@de.ibm.com, qemu-ppc@nongnu.org, Chen Fan <chen.fan.fnst@cn.fujitsu.com>, Gu Zheng <guz.fnst@cn.fujitsu.com>, imammedo@redhat.com, mdroth@linux.vnet.ibm.com, afaerber@suse.de, david@gibson.dropbear.id.au



On 26/05/2016 12:47, Bharata B Rao wrote:
>>> > >          } else if (cpu->stop || cpu->stopped) {
>>> > > +            if (cpu->unplug) {
>> > 
>> > This "if" is unnecessary.  next_cpu is not used anymore after the
>> > "break", so the store is dead.
> next_cpu is a global here. Won't tcg_exec_all() continue with running the
> next_cpu when it is called the next time ?

You're right, sorry!

Thanks,

Paolo