From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: Re: [PATCH 02/19] libxl: domain save: rename variables etc. Date: Thu, 14 Jun 2012 16:09:15 +0100 Message-ID: <20441.65179.818633.507704@mariner.uk.xensource.com> References: <1339176870-32652-1-git-send-email-ian.jackson@eu.citrix.com> <1339176870-32652-3-git-send-email-ian.jackson@eu.citrix.com> <1339514677.24104.84.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1339514677.24104.84.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org Ian Campbell writes ("Re: [Xen-devel] [PATCH 02/19] libxl: domain save: rename variables etc."): > On Fri, 2012-06-08 at 18:34 +0100, Ian Jackson wrote: > > Preparatory work for making domain suspend asynchronous: > [...] > > No functional change whatsoever. > > Given that and a quick skim of the changes: > > Acked-by: Ian Campbell Thanks. > Although in general I find it easier to review patches which contain > only one particular class of "mostly automatic" cleanup (e.g. renames > separate from "pointerization" separate from local variable removal > etc). OK, I will split it up more next time I do something like this. I thought I already had rather too many pre- and post-patches, but I'm happy to make more of them in future. Thanks, Ian.