From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934388AbcATPSh (ORCPT ); Wed, 20 Jan 2016 10:18:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44819 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933132AbcATPSe (ORCPT ); Wed, 20 Jan 2016 10:18:34 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20160104221658.19818.56223.stgit@warthog.procyon.org.uk> <20160104221705.19818.67138.stgit@warthog.procyon.org.uk> To: Rudolf Polzer Cc: dhowells@redhat.com, keyrings@vger.kernel.org, David Woodhouse , linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [RFC PATCH 1/4] X.509: Fix leap year handling again MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <20451.1453303112.1@warthog.procyon.org.uk> Date: Wed, 20 Jan 2016 15:18:32 +0000 Message-ID: <20452.1453303112@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Rudolf Polzer wrote: > A small nit: could it be that the month_lengths array also exists elsewhere > in the kernel? Can it possibly be shared? A quick glance around didn't pop > up anything that's not static, so, looks like it's okay to add yet another > one... Fair point, but outside of the scope of this patch. The array already exists that I'm fixing. It's definitely material for a future patch though. Note that the following: git grep 'month.*[[]' trawls up a few candidates. David