From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755466AbcA2IqZ (ORCPT ); Fri, 29 Jan 2016 03:46:25 -0500 Received: from mout.kundenserver.de ([212.227.126.134]:50562 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753868AbcA2IqW (ORCPT ); Fri, 29 Jan 2016 03:46:22 -0500 From: Arnd Bergmann To: "Zengtao (B)" Cc: Thomas Gleixner , LKML , Frederic Weisbecker Subject: Re: [PATCH] cputime: Fix timeval-->cputime conversion Date: Fri, 29 Jan 2016 09:46:03 +0100 Message-ID: <2048669.ftH2CRoGds@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <678F3D1BB717D949B966B68EAEB446ED0A6B4B94@SZXEMA509-MBX.china.huawei.com> References: <1453964546-111074-1-git-send-email-prime.zeng@huawei.com> <2202801.VajSj19nWd@wuerfel> <678F3D1BB717D949B966B68EAEB446ED0A6B4B94@SZXEMA509-MBX.china.huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:rZFYqiYQP6u4ekKNhhPCuuJaRbh5wzjQjLMk5LBS3JNjuQ+a86G zBEf4MAoO1yAkvptgMfDjkrea1j7lXsNPS+IHTOJ6AHWLspe/H4W5HAE1kKPZoDwS0OClig +ugBym4W+3ijGst7+507bt32kjLRu1fpI9qHKEcgzhQcXyIS12ngue17tkw5r5Vnb6w9r6Y OBR5TQqaHQ+VtLhgyWsvg== X-UI-Out-Filterresults: notjunk:1;V01:K0:K0m6qDnw0Ec=:Q/Rfa5lSZ4kU3Czw5jXTPJ IrQYI+umcoQ8GmuIQcOvNQ++lfU89gxxe+sBNk4MOlup/jSN8WMkt9DJo+zBf8An8RY0MOkbn +E7yjjjeZAO+cLM2irlxrksh6ve55jiOxgttMC+r1PhWk+NDKH4N2MZhyKlXATGHbS9Kp88Gm VPzobuRX+ytfyGf/FHnpYRVyoIqVvBylK9hyMEYOkbEavaTkG15784RIbNP1WYL1yuJkDEbTT d4+dWAJMyR5g5cbE7GZ5tvHV+ICdMqbbuuS+cE0W4CPSNgqaUBx3Xr4BYPHDVxm6X1etsfA4b YuHnACrXnSFyJ2dI3Yr+UYsbmGDA9d0B4QFPdirMIIe8Bd+aaubfyYiB4EQ1o+CWvWaPWE/L5 ZhgdnHhFTvyQqjzL/v1KcUnZkumMKzzzVbMc52kO47MeIpGo/qqpMb/LwsjjKmboJstUZc8mI UONwIIvXYs6GaQS+RswOtz7khib+XbYSMhzM8BXsiUtrOnixwJXjHkuYD36M1tRa6sud7MaPl 5anJW3NzvkCRV1WAyZ7cBTqrzyVlsGVmEV65xIPTDzNtQk0fVOJA7CsI5tPuyeuPhJo7dV1Iq 0xzYFL87RuG3Y5uhoJzCsJG5lIRHWV80GDnyw+HZbLruB+yqR+vOGdZ5Vryp2P2F7A9+5RS+K tE+gbPUNtDrngfVFqLcoL9aWd9XVtmSdnUdH6xwWsCFUpe7uDGHKKBp7hLm9U4euwjgBVLpqf YkaSVZvwQWKlWDga Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 29 January 2016 03:12:37 Zengtao wrote: > > -----Original Message----- > > From: Arnd Bergmann [mailto:arnd@arndb.de] > > Sent: Thursday, January 28, 2016 7:52 PM > > To: Thomas Gleixner > > Cc: Zengtao (B); LKML; Frederic Weisbecker > > Subject: Re: [PATCH] cputime: Fix timeval-->cputime conversion > > > > On Thursday 28 January 2016 09:22:04 Thomas Gleixner wrote: > > > Cc'ing Arnd > > > > > > On Thu, 28 Jan 2016, zengtao wrote: > > > > > > > The structure: > > > > struct timeval { > > > > __kernel_time_t tv_sec; /* seconds */ > > > > __kernel_suseconds_t tv_usec; /* microseconds */ > > > > }; > > > > both __kernel_time_t and __kernel_suseconds_t are short than u64 > > > > when it is 32bit platform, so force u64 conversion here. > > > > > > > > Signed-off-by: zengtao > > > > > > Reviewed-by: Thomas Gleixner > > > > This seems to miss timespec_to_cputime(), which has the same problem, > > so only setitimer() is fixed, but not nanosleep() or timer_settime(). > Yes, I have checked the code just now, the timespec_to_cputime() has the > same problem.I found the origin issue through setitimer().And I think the > timespec_to_cputime() only affects timer_settime(),by which means it affects > nanosleep? Reading that code again, I think it does not affect sys_nanosleep, but it does affect sys_clock_nanosleep(CLOCK_PROCESS_CPUTIME_ID, ...) along with timer_create/timer_settime with CLOCK_PROCESS_CPUTIME_ID. Arnd