From: valdis.kletnieks@vt.edu
To: Nicolas Pitre <nicolas.pitre@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dave Mielke <Dave@mielke.cc>,
Samuel Thibault <samuel.thibault@ens-lyon.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] vt: preserve unicode values corresponding to screen characters
Date: Sun, 17 Jun 2018 19:23:35 -0400 [thread overview]
Message-ID: <204888.1529277815@turing-police.cc.vt.edu> (raw)
In-Reply-To: <nycvar.YSQ.7.76.1806171909250.16670@knanqh.ubzr>
[-- Attachment #1: Type: text/plain, Size: 731 bytes --]
On Sun, 17 Jun 2018 19:17:51 -0400, Nicolas Pitre said:
> On Sun, 17 Jun 2018, valdis.kletnieks@vt.edu wrote:
> > This preprocessor variable seems to be dangling in the breeze, with
> > no way for it to get set? As a result, we pick up the #else define by
> > default.
>
> That's actually what's intended here.
>
> If vc_screen.c ever becomes configurable then this could be used to
> compile out this code. Or if someone wants to disable it for some
> debugging reasons. For now it is just a self-explanatory placeholder
> with very little chance of being set by mistake for any other purpose.
Oh, OK. It's code that makes sense if it's intentional - but could just as
easily been an unintended debugging/whatever leftover...
[-- Attachment #2: Type: application/pgp-signature, Size: 486 bytes --]
next prev parent reply other threads:[~2018-06-17 23:23 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-17 19:07 [PATCH v2 0/4] have the vt console preserve unicode characters Nicolas Pitre
2018-06-17 19:07 ` [PATCH v2 1/4] vt: preserve unicode values corresponding to screen characters Nicolas Pitre
2018-06-17 22:59 ` valdis.kletnieks
2018-06-17 23:17 ` Nicolas Pitre
2018-06-17 23:23 ` valdis.kletnieks [this message]
2018-06-17 19:07 ` [PATCH v2 2/4] vt: introduce unicode mode for /dev/vcs Nicolas Pitre
2018-06-17 19:07 ` [PATCH v2 3/4] vt: unicode fallback for scrollback Nicolas Pitre
2018-06-17 19:07 ` [PATCH v2 4/4] vt: coherence validation code for the unicode screen buffer Nicolas Pitre
2018-06-18 22:01 ` Andy Shevchenko
2018-06-19 1:50 ` Nicolas Pitre
2018-06-19 4:52 ` Joe Perches
2018-06-19 12:14 ` Nicolas Pitre
2018-06-19 13:09 ` [PATCH v2 0/4] have the vt console preserve unicode characters Adam Borowski
2018-06-19 13:52 ` Dave Mielke
2018-06-19 15:14 ` Adam Borowski
2018-06-19 15:30 ` Dave Mielke
2018-06-19 15:34 ` Nicolas Pitre
2018-06-21 1:43 ` Adam Borowski
2018-06-21 2:21 ` Dave Mielke
2018-06-21 3:03 ` Nicolas Pitre
2018-06-22 1:54 ` Adam Borowski
2018-06-22 6:41 ` Samuel Thibault
2018-06-22 15:59 ` Alan Cox
2018-06-22 16:28 ` Nicolas Pitre
2018-06-22 17:51 ` Alan Cox
2018-06-21 2:59 ` Nicolas Pitre
2018-06-25 0:33 ` Adam Borowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=204888.1529277815@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=Dave@mielke.cc \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.