All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Javier Viguera <javier.viguera@digi.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: gst-plugins-base tremor build time dependence?
Date: Wed, 05 Jun 2013 17:16:03 +0100	[thread overview]
Message-ID: <2054359.tVZUoD7RsO@helios> (raw)
In-Reply-To: <519A1B6A.8080600@digi.com>

Hi Javier,

On Monday 20 May 2013 14:47:38 Javier Viguera wrote:
> In gst-plugins-base package there is a patch that explicitly removes the
> '-DTREMOR' symbol so the package compiles without that support:
> 
> <http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-multimedia
> /gstreamer/gst-plugins-base-0.10.36/gst-plugins-base-tremor.patch>
> 
> But then the gst-plugins-base bitbake recipe has a build-time dependence
> on tremor:
> 
> <http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-multimedia
> /gstreamer/gst-plugins-base_0.10.36.bb>
> 
> DEPENDS += "alsa-lib freetype liboil libogg libvorbis libtheora
> util-linux *tremor*"
> 
> Is this expected?
> Can tremor build-time dependence be removed?
> 
> If this is the case i can cook up a patch, but I'm not sure if I'm
> missing something else.

I just had a look at this. It's not at all clear from the commit message that 
added this patch (which was quite a long time ago) but I don't think it can be 
removed outright; without tremor the ivorbisdec plugin won't be built, so 
despite the removal of -DTREMOR, tremor still appears to be being used. If 
this is something you don't want then it's probably more a case of needing to 
introduce a PACKAGECONFIG option to disable it.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre


      reply	other threads:[~2013-06-05 16:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-20 12:47 gst-plugins-base tremor build time dependence? Javier Viguera
2013-06-05 16:16 ` Paul Eggleton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2054359.tVZUoD7RsO@helios \
    --to=paul.eggleton@linux.intel.com \
    --cc=javier.viguera@digi.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.