From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v2] testpmd: fix build on FreeBSD
Date: Wed, 23 Mar 2016 16:17:12 +0100
Message-ID: <2055843.IvPtHn5Ksq@xps13>
References: <1458524684-13539-1-git-send-email-yong.liu@intel.com>
 <1458629413-24771-1-git-send-email-yong.liu@intel.com>
 <9BB6961774997848B5B42BEC655768F8DDB9F2@SHSMSX104.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: "Wu, Jingjing" <jingjing.wu@intel.com>, "Liu, Yong" <yong.liu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46])
 by dpdk.org (Postfix) with ESMTP id 813092B96
 for <dev@dpdk.org>; Wed, 23 Mar 2016 16:18:55 +0100 (CET)
Received: by mail-wm0-f46.google.com with SMTP id l68so238578503wml.0
 for <dev@dpdk.org>; Wed, 23 Mar 2016 08:18:55 -0700 (PDT)
In-Reply-To: <9BB6961774997848B5B42BEC655768F8DDB9F2@SHSMSX104.ccr.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-03-23 02:17, Wu, Jingjing:
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Marvin Liu
> > Build log:
> > /root/dpdk/app/test-pmd/cmdline.c:6687:45: error: no member named
> > 's6_addr32' in 'struct in6_addr'
> >     rte_be_to_cpu_32(res->ip_value.addr.ipv6.s6_addr32[i]);
> > 
> > This is caused by macro "s6_addr32" not defined on FreeBSD and testpmd
> > swap big endian parameter to host endian. Move the swap action to i40e
> > ethdev will fix this issue.
> > 
> > Fixes: 7b1312891b69 ("ethdev: add IP in GRE tunnel")
> > 
> > Signed-off-by: Marvin Liu <yong.liu@intel.com>
> Acked-by: Jingjing Wu <jingjing.wu@intel.com>

It looks good but something is missing to decide that it is the right fix:
the API do not state wether these fields (and others) are big endian or
something else.

Please Jingjing, fix the ethdev comments for these fields and others
rte_eth_ipv*_flow in a separate patch.