From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH 8 of 8] xl: add node-affinity to the output
 of `xl list`
Date: Tue, 9 Oct 2012 16:03:28 +0100
Message-ID: <20596.15552.595313.80971@mariner.uk.xensource.com>
References: <patchbomb.1349446098@Solace>
	<7fba2d9044e720770c25.1349446106@Solace>
	<20591.3218.46221.931473@mariner.uk.xensource.com>
	<1349780874.3610.89.camel@Abyss>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1349780874.3610.89.camel@Abyss>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Dario Faggioli <dario.faggioli@citrix.com>
Cc: Marcus Granado <Marcus.Granado@eu.citrix.com>, Andre Przywara <andre.przywara@amd.com>, Ian Campbell <Ian.Campbell@citrix.com>, Anil Madhavapeddy <anil@recoil.org>, George Dunlap <George.Dunlap@eu.citrix.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>, Juergen Gross <juergen.gross@ts.fujitsu.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>, Jan Beulich <JBeulich@suse.com>, Daniel De Graaf <dgdegra@tycho.nsa.gov>, Matt Wilson <msw@amazon.com>
List-Id: xen-devel@lists.xenproject.org

Dario Faggioli writes ("Re: [Xen-devel] [PATCH 8 of 8] xl: add node-affinity to the output of `xl list`"):
> Honestly, despite the fact that the function is called print_bitmap(),
> it contains the following code:
> 
>         case 1:
>             if (firstset == 0) {
>                 fprintf(stream, "any cpu");
>                 break;
>             }
>         case 3:

Uh, yes, I see what you mean.

> Which is what made me thinking that opacity was not its first concern in
> the first place, and that turning it into being opaque was none of this
> change's business. :-)

You are right that since you're just moving the code, it's not a
problem for this patch.

> However, I see your point... Perhaps I can add two functions (something
> like print_{cpumap,nodemap}()), both calling the original
> print_bitmap(), and deal with the "any {cpu,node}" case within them... 
> 
> Do you like that better?

That would indeed be an improvement.

Ian.