From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C96A7C433F5 for ; Thu, 29 Sep 2022 15:08:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235584AbiI2PIT (ORCPT ); Thu, 29 Sep 2022 11:08:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235546AbiI2PHx (ORCPT ); Thu, 29 Sep 2022 11:07:53 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33B34139F60 for ; Thu, 29 Sep 2022 08:07:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664464068; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OGdnN2Y2CEduI2udMkp9UJyXzBOPpQyA7MhhZbQEIv8=; b=OCfDlJy2nIDHlpPq/VujolNpKS6ZbPhIeRH4jglbuYTyD6GVAukJRLXEobRYDljtz61O+P iTCbJhTWVJSGVzw40aEkpg+wtbTuCRICsrv9syW/J5oNGzrCPOkHR8zJ+IG38YzhyaqCnN /zp0ogtPht/8Iz+Aoa+CSTBDQ8Ggmwo= Received: from mail-ed1-f72.google.com (209.85.208.72 [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-383-iCspnCbGPPCiWD8K2-Ps5A-1; Thu, 29 Sep 2022 11:07:22 -0400 X-MC-Unique: iCspnCbGPPCiWD8K2-Ps5A-1 Received: by mail-ed1-f72.google.com with SMTP id w17-20020a056402269100b0045249bc17a9so1493643edd.9 for ; Thu, 29 Sep 2022 08:07:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=OGdnN2Y2CEduI2udMkp9UJyXzBOPpQyA7MhhZbQEIv8=; b=Xo4v2eZozDczIm4bXOIM6ZL16c+w+YtzH7wfWbUWueqap48GPh3aacXO8LtgFV1eCN wET+0invmnPoniTDAPHheXnBLrLFfzVu0kOkDWucfqf9fZ2cHajVYlEjuOWuRnaT2ArX pftmsYpY75jXFkmfnj3QNXQNnz0uf/pfmchT4k4fCspzNG/rxmB1Qiz4Kvkqhfh0+b0B A7XQfOAPudfsN4VJ43mr4uk+K6Hh7zwQ0vfbFWoj863wjsLiZzoq57sRFyKDomSuthSG aSzrUGT950tz/ZyP8MdAmMkNywWgygncOACg+xNMF/dI2xUqazgHY8YwSyn2herqpxjn MHaw== X-Gm-Message-State: ACrzQf0tZ6trKfK5szN/SWeC1NPcvZBSAtOkqBw4T1+/bzQdaZ5wJf52 j8a+FFvQhHdoi06e6gssi1eAi0haFodsme+y1MbndWeEICwjCqk9nm5g/CmAW2bCAtbTwG6cr0a zzFpnH6Fz8Fa5kuLmzlONornx X-Received: by 2002:a05:6402:50ca:b0:451:a711:1389 with SMTP id h10-20020a05640250ca00b00451a7111389mr3687651edb.239.1664464029034; Thu, 29 Sep 2022 08:07:09 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4ISURrSfTuSflltACTcSX5Z6C3i1L6pHsD0+urKfUK+e9R4Ev1pnbTSa08jsymair1cZluhw== X-Received: by 2002:a05:6402:50ca:b0:451:a711:1389 with SMTP id h10-20020a05640250ca00b00451a7111389mr3687628edb.239.1664464028760; Thu, 29 Sep 2022 08:07:08 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:1c09:f536:3de6:228c? ([2001:b07:6468:f312:1c09:f536:3de6:228c]) by smtp.googlemail.com with ESMTPSA id ch15-20020a0564021bcf00b004585a21df62sm507478edb.0.2022.09.29.08.07.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Sep 2022 08:07:08 -0700 (PDT) Message-ID: <205b4d01-db86-6662-7906-24a8ca765e4f@redhat.com> Date: Thu, 29 Sep 2022 17:07:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Content-Language: en-US To: Maxim Levitsky , Sean Christopherson Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <20220926165112.603078-1-pbonzini@redhat.com> <15291c3f-d55c-a206-9261-253a1a33dce1@redhat.com> <08dab49f-9ca4-4978-4482-1815cf168e74@redhat.com> From: Paolo Bonzini Subject: Re: [PATCH] KVM: x86: disable on 32-bit unless CONFIG_BROKEN In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/29/22 15:52, Maxim Levitsky wrote: > On Thu, 2022-09-29 at 15:26 +0200, Paolo Bonzini wrote: >> On 9/28/22 19:55, Sean Christopherson wrote: >>>> As far as my opinion goes I do volunteer to test this code more often, >>>> and I do not want to see the 32 bit KVM support be removed*yet*. >>> >>> Yeah, I 100% agree that it shouldn't be removed until we have equivalent test >>> coverage. But I do think it should an "off-by-default" sort of thing. Maybe >>> BROKEN is the wrong dependency though? E.g. would EXPERT be a better option? >> >> Yeah, maybe EXPERT is better but I'm not sure of the equivalent test >> coverage. 32-bit VMX/SVM kvm-unit-tests are surely a good idea, but >> what's wrong with booting an older guest? > > From my point of view, using the same kernel source for host and the guest > is easier because you know that both kernels behave the same. It is certainly easier, but it is less correct. You don't cover anything that KVM doesn't use. > About EXPERT, IMHO these days most distros already dropped 32 bit suport thus anyway > one needs to compile a recent 32 bit kernel manually - thus IMHO whoever > these days compiles a 32 bit kernel, knows what they are doing. > > I personally would wait few more releases when there is a pressing reason to remove > this support. > > AFAIK, it is not really possible to remove most of the legacy direct mmu > because shadowing mmu still can use it (I think Sean told me that once). Yeah, it won't let us remove a lot of code but there are several logic cleanups that become possible if the TDP case can just assume the TDP MMU is there. For example, there is no reason to have a cpu_role (as opposed to an mmu_page_role for the root) if you are building HPA->GPA page tables. (Which reminds me that toggling CR0.WP is still a hog with the TDP MMU). Paolo