From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1980C47082 for ; Thu, 3 Jun 2021 08:28:57 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 0787E6024A for ; Thu, 3 Jun 2021 08:28:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0787E6024A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 347E04069F; Thu, 3 Jun 2021 10:28:56 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id DBBA040689 for ; Thu, 3 Jun 2021 10:28:54 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 8BD8E5C0115; Thu, 3 Jun 2021 04:28:53 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 03 Jun 2021 04:28:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= P7szjqyYOqfl9/AgBIXXB35TlcYrWzk2D3rV8JSsADM=; b=DlmKgFgts0/6dOgy qdL+9ihxgcA7a7PH64X9eDyfUdYtoCm/1XGoUNIC2X3oWYGiA0ODHpGO4sJzu5Dk 3hmsbHaUfHgASfSVJc/TpvpuC/H8stOmL/0e08KyHyJNYkO+4Am8awd/szjzPgeJ IQ4CsHDbsJqmgScl4IWJ992AVVRknasEJ3lrWbNPteTTlG8dO/JSaxMT2s9Gcjuy OYjYzXmECRRcWGkZPTaC04NTOTWuqe6Boguw3xuOsvCMqYT4bUjwrc9Us4daZ3CO FhuEm7Gj5prHTSlIfM9p1B9FP37kwqpVY6Fw37Jc7blOwz+JaoGA0QaxOd3SF0R6 OKX2TA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=P7szjqyYOqfl9/AgBIXXB35TlcYrWzk2D3rV8JSsA DM=; b=pq6fTqjbcCAuxmGBoPkdV+c2vw02IJJWpT+LXXoYdxnnYaPJw/ENlutR+ npG4+ZIzMc61TRRlftvhwhkq8fKLNpHgtxm/p+kfWszGFLdBemfc1e3B0rRUTYkd YEImXJSQjoLDNw3giPKgsW2gPwidvsG64ja7OS5Uia8PB/H27s5szZ51tmH7DomW xpa4sKJFPOx0o8HrkIkbAbAaW4N/tEd0PW4DWzPvzVARbqOe25LWmP9juI9VIWNl 1eEaZI6VEnKtidd4fjlwgYOacu13h7HXF6XQyRDmdgZ5sWLQ4ltl8Ou6h2AHrYUC iMj7bahvIekO7bcyWynDVoPvX9fHQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdelledgtddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 3 Jun 2021 04:28:51 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob Cc: dpdk-dev , Elena Agostini Date: Thu, 03 Jun 2021 10:28:50 +0200 Message-ID: <2066767.2bDh9DmJd4@thomas> In-Reply-To: References: <20210602203531.2288645-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] gpudev: introduce memory API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 03/06/2021 09:47, Jerin Jacob: > On Thu, Jun 3, 2021 at 2:05 AM Thomas Monjalon wrote: > > --- a/doc/api/doxy-api-index.md > > +++ b/doc/api/doxy-api-index.md > > @@ -21,6 +21,7 @@ The public API headers are grouped by topics: > > [compressdev] (@ref rte_compressdev.h), > > [compress] (@ref rte_comp.h), > > [regexdev] (@ref rte_regexdev.h), > > + [gpudev] (@ref rte_gpudev.h), > > Since this device does not have a queue etc? Shouldn't make it a > library like mempool with vendor-defined ops? > Any specific reason for making it a device? The reason why I am asking > this is, as other DPDK devices as symmetry in queue(s), configure, > start, stop operation etc. > > > > + > > +struct rte_gpu_dev { > > + /* Backing device. */ > > + struct rte_device *device; > > See above? There is a PCI device probed. I don't understand why it would not be represented as a device.