From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: Jim Fehlig <jfehlig@suse.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>,
Ian Campbell <Ian.Campbell@citrix.com>,
Bamvor Jian Zhang <bjzhang@suse.com>
Subject: Re: [PATCH 2/2] libxl: fix stale timeout event callback race
Date: Wed, 12 Dec 2012 17:16:04 +0000 [thread overview]
Message-ID: <20680.48084.559983.299246@mariner.uk.xensource.com> (raw)
In-Reply-To: <20680.47971.962603.851882@mariner.uk.xensource.com>
Ian Jackson writes ("Re: [Xen-devel] [PATCH 2/2] libxl: fix stale timeout event callback race"):
> Jim Fehlig writes ("Re: [Xen-devel] [PATCH 2/2] libxl: fix stale timeout event callback race"):
> > - gettimeofday(&now, NULL);
> > - timeout = (abs_t.tv_usec - now.tv_usec) / 1000;
> > - timeout += (abs_t.tv_sec - now.tv_sec) * 1000;
>
> Specifically, this code has an integer arithmetic overflow.
If you look at beforepoll_internal in libxl_event.c, near line 859,
you can see how I tackled this same problem there.
Ian.
next prev parent reply other threads:[~2012-12-12 17:16 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 7:16 [PATCH] fix race condition between libvirtd event handling and libxl fd deregister Bamvor Jian Zhang
2012-11-23 9:43 ` Ian Campbell
2012-11-26 23:22 ` Jim Fehlig
2012-11-27 10:03 ` Ian Campbell
2012-11-27 19:08 ` Ian Jackson
2012-11-28 11:25 ` Ian Campbell
2012-12-06 16:11 ` 答复： " Bamvor Jian Zhang
2012-12-07 19:11 ` Ian Jackson
2012-12-07 19:15 ` [PATCH 1/2] libxl: fix stale fd event callback race Ian Jackson
2012-12-07 19:22 ` Ian Jackson
2012-12-07 19:15 ` [PATCH 2/2] libxl: fix stale timeout " Ian Jackson
2012-12-07 19:21 ` [PATCH 1/2] libxl: fix stale fd " Ian Jackson
2012-12-07 19:21 ` [PATCH 2/2] libxl: fix stale timeout " Ian Jackson
2012-12-10 10:19 ` [PATCH] fix race condition between libvirtd event handling and libxl fd deregister Ian Campbell
2012-12-10 10:37 ` Ian Jackson
2012-12-10 16:56 ` Ian Jackson
2012-12-10 16:57 ` [PATCH 1/2] libxl: fix stale fd event callback race Ian Jackson
2012-12-11 22:35 ` Jim Fehlig
2012-12-12 17:04 ` Ian Jackson
2012-12-12 17:20 ` Jim Fehlig
2012-12-10 16:57 ` [PATCH 2/2] libxl: fix stale timeout " Ian Jackson
2012-12-11 22:53 ` Jim Fehlig
2012-12-12 17:14 ` Ian Jackson
2012-12-12 17:16 ` Ian Jackson [this message]
2012-12-12 17:26 ` Jim Fehlig
2012-12-12 17:37 ` Ian Jackson
2012-12-12 18:01 ` Jim Fehlig
2012-12-13 10:29 ` Ian Campbell
2012-12-13 13:12 ` Ian Jackson
2012-12-13 15:53 ` Jim Fehlig
2012-12-13 15:58 ` Ian Jackson
2012-12-13 16:53 ` Jim Fehlig
2012-12-13 13:07 ` Ian Jackson
2012-12-13 15:41 ` Jim Fehlig
2012-12-13 15:51 ` Ian Jackson
2012-12-13 15:57 ` Jim Fehlig
2012-12-11 10:19 ` [PATCH] fix race condition between libvirtd event handling and libxl fd deregister Bamvor Jian Zhang
2012-12-11 11:20 ` Ian Jackson
2013-01-11 11:41 ` Ian Campbell
2013-01-11 17:51 ` Jim Fehlig
2013-01-15 10:40 ` Ian Campbell
2013-01-15 17:02 ` Jim Fehlig
2013-01-21 19:37 ` Jim Fehlig
2013-01-22 10:21 ` Ian Campbell
2012-12-10 23:56 ` Jim Fehlig
2012-12-11 11:18 ` Ian Jackson
2012-12-06 16:06 ` 答复： " Bamvor Jian Zhang
2013-01-23 16:08 [PATCH 0/2 v4] libxl: fix event races exposed by libvirt Ian Jackson
2013-01-23 16:08 ` [PATCH 2/2] libxl: fix stale timeout event callback race Ian Jackson
2013-01-23 17:48 ` Jim Fehlig
2013-01-23 18:21 [PATCH 0/2 v4.1] libxl: fix event races exposed by libvirt Ian Jackson
2013-01-23 18:21 ` [PATCH 2/2] libxl: fix stale timeout event callback race Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20680.48084.559983.299246@mariner.uk.xensource.com \
--to=ian.jackson@eu.citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=bjzhang@suse.com \
--cc=jfehlig@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.