From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sinan Kaya Subject: Re: [PATCH] ACPI / GED: unregister interrupts during shutdown Date: Thu, 7 Dec 2017 12:18:57 -0500 Message-ID: <20707334-001e-f138-59af-a23cdee05737@codeaurora.org> References: <1512507705-2411-1-git-send-email-okaya@codeaurora.org> <20171207082958.GA11882@kroah.com> <2960222.F3CtrQ5k26@aspire.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:35210 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751709AbdLGRTA (ORCPT ); Thu, 7 Dec 2017 12:19:00 -0500 In-Reply-To: Content-Language: en-US Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: "Rafael J. Wysocki" Cc: "Rafael J. Wysocki" , Greg Kroah-Hartman , ACPI Devel Maling List , Timur Tabi , linux-arm-msm@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , Linux Kernel Mailing List On 12/7/2017 12:10 PM, Rafael J. Wysocki wrote: >> My take away from the discussion is: >> 1. don't use devm family of functions for IRQ registration/free >> 2. still keep track of the events >> 3. call free_irq on shutdown. > Yes. And on remove too. OK, will make the changes and post a newer version. Thanks for the confirmation. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756562AbdLGRTD (ORCPT ); Thu, 7 Dec 2017 12:19:03 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:35210 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751709AbdLGRTA (ORCPT ); Thu, 7 Dec 2017 12:19:00 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 6BF7B6085C Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH] ACPI / GED: unregister interrupts during shutdown To: "Rafael J. Wysocki" Cc: "Rafael J. Wysocki" , Greg Kroah-Hartman , ACPI Devel Maling List , Timur Tabi , linux-arm-msm@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , Linux Kernel Mailing List References: <1512507705-2411-1-git-send-email-okaya@codeaurora.org> <20171207082958.GA11882@kroah.com> <2960222.F3CtrQ5k26@aspire.rjw.lan> From: Sinan Kaya Message-ID: <20707334-001e-f138-59af-a23cdee05737@codeaurora.org> Date: Thu, 7 Dec 2017 12:18:57 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/7/2017 12:10 PM, Rafael J. Wysocki wrote: >> My take away from the discussion is: >> 1. don't use devm family of functions for IRQ registration/free >> 2. still keep track of the events >> 3. call free_irq on shutdown. > Yes. And on remove too. OK, will make the changes and post a newer version. Thanks for the confirmation. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. From mboxrd@z Thu Jan 1 00:00:00 1970 From: okaya@codeaurora.org (Sinan Kaya) Date: Thu, 7 Dec 2017 12:18:57 -0500 Subject: [PATCH] ACPI / GED: unregister interrupts during shutdown In-Reply-To: References: <1512507705-2411-1-git-send-email-okaya@codeaurora.org> <20171207082958.GA11882@kroah.com> <2960222.F3CtrQ5k26@aspire.rjw.lan> Message-ID: <20707334-001e-f138-59af-a23cdee05737@codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 12/7/2017 12:10 PM, Rafael J. Wysocki wrote: >> My take away from the discussion is: >> 1. don't use devm family of functions for IRQ registration/free >> 2. still keep track of the events >> 3. call free_irq on shutdown. > Yes. And on remove too. OK, will make the changes and post a newer version. Thanks for the confirmation. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.