From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Date: Tue, 01 Aug 2017 15:43:15 +0000 Subject: Re: [PATCH 1/4] fbcon: Make fbcon a built-time depency for fbdev Message-Id: <2072598.i2ta92yxCh@amdc3058> List-Id: References: <20170706125735.28299-1-daniel.vetter@ffwll.ch> <20170706125735.28299-2-daniel.vetter@ffwll.ch> <1829417.jhVqBZyytf@amdc3058> In-Reply-To: <1829417.jhVqBZyytf@amdc3058> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Daniel Vetter Cc: linux-fbdev@vger.kernel.org, Sergey Senozhatsky , Intel Graphics Development , Steven Rostedt , DRI Development , Daniel Vetter , Alan Cox On Wednesday, July 12, 2017 12:40:45 PM Bartlomiej Zolnierkiewicz wrote: > On Thursday, July 06, 2017 02:57:32 PM Daniel Vetter wrote: > > There's a bunch of folks who're trying to make printk less > > contended and faster, but there's a problem: printk uses the > > console_lock, and the console lock has become the BKL for all things > > fbdev/fbcon, which in turn pulled in half the drm subsystem under that > > lock. That's awkward. > > > > There reasons for that is probably just a historical accident: > > > > - fbcon is a runtime option of fbdev, i.e. at runtime you can pick > > whether your fbdev driver instances are used as kernel consoles. > > Unfortunately this wasn't implemented with some module option, but > > through some module loading magic: As long as you don't load > > fbcon.ko, there's no fbdev console support, but loading it (in any > > order wrt fbdev drivers) will create console instances for all fbdev > > drivers. > > > > - This was implemented through a notifier chain. fbcon.ko enumerates > > all fbdev instances at load time and also registers itself as > > listener in the fbdev notifier. The fbdev core tries to register new > > fbdev instances with fbcon using the notifier. > > > > - On top of that the modifier chain is also used at runtime by the > > fbdev subsystem to e.g. control backlights for panels. > > > > - The problem is that the notifier puts a mutex locking context > > between fbdev and fbcon, which mixes up the locking contexts for > > both the runtime usage and the register time usage to notify fbcon. > > And at runtime fbcon (through the fbdev core) might call into the > > notifier from a printk critical section while console_lock is held. > > > > - This means console_lock must be an outer lock for the entire fbdev > > subsystem, which also means it must be acquired when registering a > > new framebuffer driver as the outermost lock since we might call > > into fbcon (through the notifier) which would result in a locking > > inversion if fbcon would acquire the console_lock from its notifier > > callback (which it needs to register the console). > > > > - console_lock can be held anywhere, since printk can be called > > anywhere, and through the above story, plus drm/kms being an fbdev > > driver, we pull in a shocking amount of locking hiercharchy > > underneath the console_lock. Which makes cleaning up printk really > > hard (not even splitting console_lock into an rwsem is all that > > useful due to this). > > > > There's various ways to address this, but the cleanest would be to > > make fbcon a compile-time option, where fbdev directly calls the fbcon > > register functions from register_framebuffer, or dummy static inline > > versions if fbcon is disabled. Maybe augmented with a runtime knob to > > disable fbcon, if that's needed (for debugging perhaps). > > > > But this could break some users who rely on the magic "loading > > fbcon.ko enables/disables fbdev framebuffers at runtime" thing, even > > if that's unlikely. Hence we must be careful: > > > > 1. Create a compile-time dependency between fbcon and fbdev in the > > least minimal way. This is what this patch does. > > > > 2. Wait at least 1 year to give possible users time to scream about > > how we broke their setup. Unlikely, since all distros make fbcon > > compile-in, and embedded platforms only compile stuff they know they > > need anyway. But still. > > > > 3. Convert the notifier to direct functions calls, with dummy static > > inlines if fbcon is disabled. We'll still need the fb notifier for the > > other uses (like backlights), but we can probably move it into the fb > > core (atm it must be built-into vmlinux). > > > > 4. Push console_lock down the call-chain, until it is down in > > console_register again. > > > > 5. Finally start to clean up and rework the printk/console locking. > > > > For context of this saga see > > > > commit 50e244cc793d511b86adea24972f3a7264cae114 > > Author: Alan Cox > > Date: Fri Jan 25 10:28:15 2013 +1000 > > > > fb: rework locking to fix lock ordering on takeover > > > > plus the pile of commits on top that tried to make this all work > > without terminally upsetting lockdep. We've uncovered all this when > > console_lock lockdep annotations where added in > > > > commit daee779718a319ff9f83e1ba3339334ac650bb22 > > Author: Daniel Vetter > > Date: Sat Sep 22 19:52:11 2012 +0200 > > > > console: implement lockdep support for console_lock > > > > On the patch itself: > > - Switch CONFIG_FRAMEBUFFER_CONSOLE to be a boolean, using the overall > > CONFIG_FB tristate to decided whether it should be a module or > > built-in. > > > > - At first I thought I could force the build depency with just a dummy > > symbol that fbcon.ko exports and fb.ko uses. But that leads to a > > module depency cycle (it works fine when built-in). > > > > Since this tight binding is the entire goal the simplest solution is > > to move all the fbcon modules (and there's a bunch of optinal > > source-files which are each modules of their own, for no good > > reason) into the overall fb.ko core module. That's a bit more than > > what I would have liked to do in this patch, but oh well. > > > > Cc: Alan Cox > > Cc: Sergey Senozhatsky > > Cc: Linux Fbdev development list > > Cc: Steven Rostedt > > Cc: Bartlomiej Zolnierkiewicz > > Cc: dri-devel@lists.freedesktop.org > > Signed-off-by: Daniel Vetter Patch queued for 4.14, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH 1/4] fbcon: Make fbcon a built-time depency for fbdev Date: Tue, 01 Aug 2017 17:43:15 +0200 Message-ID: <2072598.i2ta92yxCh@amdc3058> References: <20170706125735.28299-1-daniel.vetter@ffwll.ch> <20170706125735.28299-2-daniel.vetter@ffwll.ch> <1829417.jhVqBZyytf@amdc3058> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <1829417.jhVqBZyytf@amdc3058> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: linux-fbdev@vger.kernel.org, Sergey Senozhatsky , Intel Graphics Development , Steven Rostedt , DRI Development , Daniel Vetter , Alan Cox List-Id: dri-devel@lists.freedesktop.org T24gV2VkbmVzZGF5LCBKdWx5IDEyLCAyMDE3IDEyOjQwOjQ1IFBNIEJhcnRsb21pZWogWm9sbmll cmtpZXdpY3ogd3JvdGU6Cj4gT24gVGh1cnNkYXksIEp1bHkgMDYsIDIwMTcgMDI6NTc6MzIgUE0g RGFuaWVsIFZldHRlciB3cm90ZToKPiA+IFRoZXJlJ3MgYSBidW5jaCBvZiBmb2xrcyB3aG8ncmUg dHJ5aW5nIHRvIG1ha2UgcHJpbnRrIGxlc3MKPiA+IGNvbnRlbmRlZCBhbmQgZmFzdGVyLCBidXQg dGhlcmUncyBhIHByb2JsZW06IHByaW50ayB1c2VzIHRoZQo+ID4gY29uc29sZV9sb2NrLCBhbmQg dGhlIGNvbnNvbGUgbG9jayBoYXMgYmVjb21lIHRoZSBCS0wgZm9yIGFsbCB0aGluZ3MKPiA+IGZi ZGV2L2ZiY29uLCB3aGljaCBpbiB0dXJuIHB1bGxlZCBpbiBoYWxmIHRoZSBkcm0gc3Vic3lzdGVt IHVuZGVyIHRoYXQKPiA+IGxvY2suIFRoYXQncyBhd2t3YXJkLgo+ID4gCj4gPiBUaGVyZSByZWFz b25zIGZvciB0aGF0IGlzIHByb2JhYmx5IGp1c3QgYSBoaXN0b3JpY2FsIGFjY2lkZW50Ogo+ID4g Cj4gPiAtIGZiY29uIGlzIGEgcnVudGltZSBvcHRpb24gb2YgZmJkZXYsIGkuZS4gYXQgcnVudGlt ZSB5b3UgY2FuIHBpY2sKPiA+ICAgd2hldGhlciB5b3VyIGZiZGV2IGRyaXZlciBpbnN0YW5jZXMg YXJlIHVzZWQgYXMga2VybmVsIGNvbnNvbGVzLgo+ID4gICBVbmZvcnR1bmF0ZWx5IHRoaXMgd2Fz bid0IGltcGxlbWVudGVkIHdpdGggc29tZSBtb2R1bGUgb3B0aW9uLCBidXQKPiA+ICAgdGhyb3Vn aCBzb21lIG1vZHVsZSBsb2FkaW5nIG1hZ2ljOiBBcyBsb25nIGFzIHlvdSBkb24ndCBsb2FkCj4g PiAgIGZiY29uLmtvLCB0aGVyZSdzIG5vIGZiZGV2IGNvbnNvbGUgc3VwcG9ydCwgYnV0IGxvYWRp bmcgaXQgKGluIGFueQo+ID4gICBvcmRlciB3cnQgZmJkZXYgZHJpdmVycykgd2lsbCBjcmVhdGUg Y29uc29sZSBpbnN0YW5jZXMgZm9yIGFsbCBmYmRldgo+ID4gICBkcml2ZXJzLgo+ID4gCj4gPiAt IFRoaXMgd2FzIGltcGxlbWVudGVkIHRocm91Z2ggYSBub3RpZmllciBjaGFpbi4gZmJjb24ua28g ZW51bWVyYXRlcwo+ID4gICBhbGwgZmJkZXYgaW5zdGFuY2VzIGF0IGxvYWQgdGltZSBhbmQgYWxz byByZWdpc3RlcnMgaXRzZWxmIGFzCj4gPiAgIGxpc3RlbmVyIGluIHRoZSBmYmRldiBub3RpZmll ci4gVGhlIGZiZGV2IGNvcmUgdHJpZXMgdG8gcmVnaXN0ZXIgbmV3Cj4gPiAgIGZiZGV2IGluc3Rh bmNlcyB3aXRoIGZiY29uIHVzaW5nIHRoZSBub3RpZmllci4KPiA+IAo+ID4gLSBPbiB0b3Agb2Yg dGhhdCB0aGUgbW9kaWZpZXIgY2hhaW4gaXMgYWxzbyB1c2VkIGF0IHJ1bnRpbWUgYnkgdGhlCj4g PiAgIGZiZGV2IHN1YnN5c3RlbSB0byBlLmcuIGNvbnRyb2wgYmFja2xpZ2h0cyBmb3IgcGFuZWxz Lgo+ID4gCj4gPiAtIFRoZSBwcm9ibGVtIGlzIHRoYXQgdGhlIG5vdGlmaWVyIHB1dHMgYSBtdXRl eCBsb2NraW5nIGNvbnRleHQKPiA+ICAgYmV0d2VlbiBmYmRldiBhbmQgZmJjb24sIHdoaWNoIG1p eGVzIHVwIHRoZSBsb2NraW5nIGNvbnRleHRzIGZvcgo+ID4gICBib3RoIHRoZSBydW50aW1lIHVz YWdlIGFuZCB0aGUgcmVnaXN0ZXIgdGltZSB1c2FnZSB0byBub3RpZnkgZmJjb24uCj4gPiAgIEFu ZCBhdCBydW50aW1lIGZiY29uICh0aHJvdWdoIHRoZSBmYmRldiBjb3JlKSBtaWdodCBjYWxsIGlu dG8gdGhlCj4gPiAgIG5vdGlmaWVyIGZyb20gYSBwcmludGsgY3JpdGljYWwgc2VjdGlvbiB3aGls ZSBjb25zb2xlX2xvY2sgaXMgaGVsZC4KPiA+IAo+ID4gLSBUaGlzIG1lYW5zIGNvbnNvbGVfbG9j ayBtdXN0IGJlIGFuIG91dGVyIGxvY2sgZm9yIHRoZSBlbnRpcmUgZmJkZXYKPiA+ICAgc3Vic3lz dGVtLCB3aGljaCBhbHNvIG1lYW5zIGl0IG11c3QgYmUgYWNxdWlyZWQgd2hlbiByZWdpc3Rlcmlu ZyBhCj4gPiAgIG5ldyBmcmFtZWJ1ZmZlciBkcml2ZXIgYXMgdGhlIG91dGVybW9zdCBsb2NrIHNp bmNlIHdlIG1pZ2h0IGNhbGwKPiA+ICAgaW50byBmYmNvbiAodGhyb3VnaCB0aGUgbm90aWZpZXIp IHdoaWNoIHdvdWxkIHJlc3VsdCBpbiBhIGxvY2tpbmcKPiA+ICAgaW52ZXJzaW9uIGlmIGZiY29u IHdvdWxkIGFjcXVpcmUgdGhlIGNvbnNvbGVfbG9jayBmcm9tIGl0cyBub3RpZmllcgo+ID4gICBj YWxsYmFjayAod2hpY2ggaXQgbmVlZHMgdG8gcmVnaXN0ZXIgdGhlIGNvbnNvbGUpLgo+ID4gCj4g PiAtIGNvbnNvbGVfbG9jayBjYW4gYmUgaGVsZCBhbnl3aGVyZSwgc2luY2UgcHJpbnRrIGNhbiBi ZSBjYWxsZWQKPiA+ICAgYW55d2hlcmUsIGFuZCB0aHJvdWdoIHRoZSBhYm92ZSBzdG9yeSwgcGx1 cyBkcm0va21zIGJlaW5nIGFuIGZiZGV2Cj4gPiAgIGRyaXZlciwgd2UgcHVsbCBpbiBhIHNob2Nr aW5nIGFtb3VudCBvZiBsb2NraW5nIGhpZXJjaGFyY2h5Cj4gPiAgIHVuZGVybmVhdGggdGhlIGNv bnNvbGVfbG9jay4gV2hpY2ggbWFrZXMgY2xlYW5pbmcgdXAgcHJpbnRrIHJlYWxseQo+ID4gICBo YXJkIChub3QgZXZlbiBzcGxpdHRpbmcgY29uc29sZV9sb2NrIGludG8gYW4gcndzZW0gaXMgYWxs IHRoYXQKPiA+ICAgdXNlZnVsIGR1ZSB0byB0aGlzKS4KPiA+IAo+ID4gVGhlcmUncyB2YXJpb3Vz IHdheXMgdG8gYWRkcmVzcyB0aGlzLCBidXQgdGhlIGNsZWFuZXN0IHdvdWxkIGJlIHRvCj4gPiBt YWtlIGZiY29uIGEgY29tcGlsZS10aW1lIG9wdGlvbiwgd2hlcmUgZmJkZXYgZGlyZWN0bHkgY2Fs bHMgdGhlIGZiY29uCj4gPiByZWdpc3RlciBmdW5jdGlvbnMgZnJvbSByZWdpc3Rlcl9mcmFtZWJ1 ZmZlciwgb3IgZHVtbXkgc3RhdGljIGlubGluZQo+ID4gdmVyc2lvbnMgaWYgZmJjb24gaXMgZGlz YWJsZWQuIE1heWJlIGF1Z21lbnRlZCB3aXRoIGEgcnVudGltZSBrbm9iIHRvCj4gPiBkaXNhYmxl IGZiY29uLCBpZiB0aGF0J3MgbmVlZGVkIChmb3IgZGVidWdnaW5nIHBlcmhhcHMpLgo+ID4gCj4g PiBCdXQgdGhpcyBjb3VsZCBicmVhayBzb21lIHVzZXJzIHdobyByZWx5IG9uIHRoZSBtYWdpYyAi bG9hZGluZwo+ID4gZmJjb24ua28gZW5hYmxlcy9kaXNhYmxlcyBmYmRldiBmcmFtZWJ1ZmZlcnMg YXQgcnVudGltZSIgdGhpbmcsIGV2ZW4KPiA+IGlmIHRoYXQncyB1bmxpa2VseS4gSGVuY2Ugd2Ug bXVzdCBiZSBjYXJlZnVsOgo+ID4gCj4gPiAxLiBDcmVhdGUgYSBjb21waWxlLXRpbWUgZGVwZW5k ZW5jeSBiZXR3ZWVuIGZiY29uIGFuZCBmYmRldiBpbiB0aGUKPiA+IGxlYXN0IG1pbmltYWwgd2F5 LiBUaGlzIGlzIHdoYXQgdGhpcyBwYXRjaCBkb2VzLgo+ID4gCj4gPiAyLiBXYWl0IGF0IGxlYXN0 IDEgeWVhciB0byBnaXZlIHBvc3NpYmxlIHVzZXJzIHRpbWUgdG8gc2NyZWFtIGFib3V0Cj4gPiBo b3cgd2UgYnJva2UgdGhlaXIgc2V0dXAuIFVubGlrZWx5LCBzaW5jZSBhbGwgZGlzdHJvcyBtYWtl IGZiY29uCj4gPiBjb21waWxlLWluLCBhbmQgZW1iZWRkZWQgcGxhdGZvcm1zIG9ubHkgY29tcGls ZSBzdHVmZiB0aGV5IGtub3cgdGhleQo+ID4gbmVlZCBhbnl3YXkuIEJ1dCBzdGlsbC4KPiA+IAo+ ID4gMy4gQ29udmVydCB0aGUgbm90aWZpZXIgdG8gZGlyZWN0IGZ1bmN0aW9ucyBjYWxscywgd2l0 aCBkdW1teSBzdGF0aWMKPiA+IGlubGluZXMgaWYgZmJjb24gaXMgZGlzYWJsZWQuIFdlJ2xsIHN0 aWxsIG5lZWQgdGhlIGZiIG5vdGlmaWVyIGZvciB0aGUKPiA+IG90aGVyIHVzZXMgKGxpa2UgYmFj a2xpZ2h0cyksIGJ1dCB3ZSBjYW4gcHJvYmFibHkgbW92ZSBpdCBpbnRvIHRoZSBmYgo+ID4gY29y ZSAoYXRtIGl0IG11c3QgYmUgYnVpbHQtaW50byB2bWxpbnV4KS4KPiA+IAo+ID4gNC4gUHVzaCBj b25zb2xlX2xvY2sgZG93biB0aGUgY2FsbC1jaGFpbiwgdW50aWwgaXQgaXMgZG93biBpbgo+ID4g Y29uc29sZV9yZWdpc3RlciBhZ2Fpbi4KPiA+IAo+ID4gNS4gRmluYWxseSBzdGFydCB0byBjbGVh biB1cCBhbmQgcmV3b3JrIHRoZSBwcmludGsvY29uc29sZSBsb2NraW5nLgo+ID4gCj4gPiBGb3Ig Y29udGV4dCBvZiB0aGlzIHNhZ2Egc2VlCj4gPiAKPiA+IGNvbW1pdCA1MGUyNDRjYzc5M2Q1MTFi ODZhZGVhMjQ5NzJmM2E3MjY0Y2FlMTE0Cj4gPiBBdXRob3I6IEFsYW4gQ294IDxhbGFuQGxpbnV4 LmludGVsLmNvbT4KPiA+IERhdGU6ICAgRnJpIEphbiAyNSAxMDoyODoxNSAyMDEzICsxMDAwCj4g PiAKPiA+ICAgICBmYjogcmV3b3JrIGxvY2tpbmcgdG8gZml4IGxvY2sgb3JkZXJpbmcgb24gdGFr ZW92ZXIKPiA+IAo+ID4gcGx1cyB0aGUgcGlsZSBvZiBjb21taXRzIG9uIHRvcCB0aGF0IHRyaWVk IHRvIG1ha2UgdGhpcyBhbGwgd29yawo+ID4gd2l0aG91dCB0ZXJtaW5hbGx5IHVwc2V0dGluZyBs b2NrZGVwLiBXZSd2ZSB1bmNvdmVyZWQgYWxsIHRoaXMgd2hlbgo+ID4gY29uc29sZV9sb2NrIGxv Y2tkZXAgYW5ub3RhdGlvbnMgd2hlcmUgYWRkZWQgaW4KPiA+IAo+ID4gY29tbWl0IGRhZWU3Nzk3 MThhMzE5ZmY5ZjgzZTFiYTMzMzkzMzRhYzY1MGJiMjIKPiA+IEF1dGhvcjogRGFuaWVsIFZldHRl ciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiA+IERhdGU6ICAgU2F0IFNlcCAyMiAxOTo1Mjox MSAyMDEyICswMjAwCj4gPiAKPiA+ICAgICBjb25zb2xlOiBpbXBsZW1lbnQgbG9ja2RlcCBzdXBw b3J0IGZvciBjb25zb2xlX2xvY2sKPiA+IAo+ID4gT24gdGhlIHBhdGNoIGl0c2VsZjoKPiA+IC0g U3dpdGNoIENPTkZJR19GUkFNRUJVRkZFUl9DT05TT0xFIHRvIGJlIGEgYm9vbGVhbiwgdXNpbmcg dGhlIG92ZXJhbGwKPiA+ICAgQ09ORklHX0ZCIHRyaXN0YXRlIHRvIGRlY2lkZWQgd2hldGhlciBp dCBzaG91bGQgYmUgYSBtb2R1bGUgb3IKPiA+ICAgYnVpbHQtaW4uCj4gPiAKPiA+IC0gQXQgZmly c3QgSSB0aG91Z2h0IEkgY291bGQgZm9yY2UgdGhlIGJ1aWxkIGRlcGVuY3kgd2l0aCBqdXN0IGEg ZHVtbXkKPiA+ICAgc3ltYm9sIHRoYXQgZmJjb24ua28gZXhwb3J0cyBhbmQgZmIua28gdXNlcy4g QnV0IHRoYXQgbGVhZHMgdG8gYQo+ID4gICBtb2R1bGUgZGVwZW5jeSBjeWNsZSAoaXQgd29ya3Mg ZmluZSB3aGVuIGJ1aWx0LWluKS4KPiA+IAo+ID4gICBTaW5jZSB0aGlzIHRpZ2h0IGJpbmRpbmcg aXMgdGhlIGVudGlyZSBnb2FsIHRoZSBzaW1wbGVzdCBzb2x1dGlvbiBpcwo+ID4gICB0byBtb3Zl IGFsbCB0aGUgZmJjb24gbW9kdWxlcyAoYW5kIHRoZXJlJ3MgYSBidW5jaCBvZiBvcHRpbmFsCj4g PiAgIHNvdXJjZS1maWxlcyB3aGljaCBhcmUgZWFjaCBtb2R1bGVzIG9mIHRoZWlyIG93biwgZm9y IG5vIGdvb2QKPiA+ICAgcmVhc29uKSBpbnRvIHRoZSBvdmVyYWxsIGZiLmtvIGNvcmUgbW9kdWxl LiBUaGF0J3MgYSBiaXQgbW9yZSB0aGFuCj4gPiAgIHdoYXQgSSB3b3VsZCBoYXZlIGxpa2VkIHRv IGRvIGluIHRoaXMgcGF0Y2gsIGJ1dCBvaCB3ZWxsLgo+ID4gCj4gPiBDYzogQWxhbiBDb3ggPGFs YW5AbHhvcmd1ay51a3V1Lm9yZy51az4KPiA+IENjOiBTZXJnZXkgU2Vub3poYXRza3kgPHNlcmdl eS5zZW5vemhhdHNreS53b3JrQGdtYWlsLmNvbT4KPiA+IENjOiBMaW51eCBGYmRldiBkZXZlbG9w bWVudCBsaXN0IDxsaW51eC1mYmRldkB2Z2VyLmtlcm5lbC5vcmc+Cj4gPiBDYzogU3RldmVuIFJv c3RlZHQgPHJvc3RlZHRAZ29vZG1pcy5vcmc+Cj4gPiBDYzogQmFydGxvbWllaiBab2xuaWVya2ll d2ljeiA8Yi56b2xuaWVya2llQHNhbXN1bmcuY29tPgo+ID4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKPiA+IFNpZ25lZC1vZmYtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52 ZXR0ZXJAaW50ZWwuY29tPgoKUGF0Y2ggcXVldWVkIGZvciA0LjE0LCB0aGFua3MuCgpCZXN0IHJl Z2FyZHMsCi0tCkJhcnRsb21pZWogWm9sbmllcmtpZXdpY3oKU2Ftc3VuZyBSJkQgSW5zdGl0dXRl IFBvbGFuZApTYW1zdW5nIEVsZWN0cm9uaWNzCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWwK