From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758673AbcJQXYx (ORCPT ); Mon, 17 Oct 2016 19:24:53 -0400 Received: from mail-pf0-f175.google.com ([209.85.192.175]:32973 "EHLO mail-pf0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758466AbcJQXYr (ORCPT ); Mon, 17 Oct 2016 19:24:47 -0400 Subject: Re: [PATCH v2] arm64: defconfig: enable EEPROM_AT25 config option To: Olof Johansson References: <1476298306-9138-1-git-send-email-scott.branden@broadcom.com> Cc: Catalin Marinas , Will Deacon , Arnd Bergmann , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , BCM Kernel Feedback From: Scott Branden Message-ID: <207706e2-8fd4-748f-2ee7-3c372b447a7d@broadcom.com> Date: Mon, 17 Oct 2016 16:24:31 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Olof, On 16-10-17 02:58 PM, Olof Johansson wrote: > Hi, > > On Wed, Oct 12, 2016 at 11:51 AM, Scott Branden > wrote: >> Enable support for on board SPI EEPROM by turning on >> CONFIG_EEPROM_AT25. This needs to be on in order to >> boot and test the kernel with a static rootfs image >> that is not rebuilt everytime the kernel is rebuilt. > > If we did this for every kernel option we'd get a huge kernel. > > In general, we've said that static options for what's needed to boot > to rootfs (i.e. storage and network drivers for nfsroot) are fine to > enable statically. > > I doubt you need the EEPROM driver to boot to rootfs on your system, > so please enable it as a module instead. > > Look into using config fragments in case you need to modify the > options for local builds, it should be a convenient way to have a > small delta to apply to fit your internal needs, instead of completely > forking the config file. Do you allow such config fragments to be upstreamed or do we need to maintain these in our tree? > > > -Olof > Thanks, Scott From mboxrd@z Thu Jan 1 00:00:00 1970 From: scott.branden@broadcom.com (Scott Branden) Date: Mon, 17 Oct 2016 16:24:31 -0700 Subject: [PATCH v2] arm64: defconfig: enable EEPROM_AT25 config option In-Reply-To: References: <1476298306-9138-1-git-send-email-scott.branden@broadcom.com> Message-ID: <207706e2-8fd4-748f-2ee7-3c372b447a7d@broadcom.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Olof, On 16-10-17 02:58 PM, Olof Johansson wrote: > Hi, > > On Wed, Oct 12, 2016 at 11:51 AM, Scott Branden > wrote: >> Enable support for on board SPI EEPROM by turning on >> CONFIG_EEPROM_AT25. This needs to be on in order to >> boot and test the kernel with a static rootfs image >> that is not rebuilt everytime the kernel is rebuilt. > > If we did this for every kernel option we'd get a huge kernel. > > In general, we've said that static options for what's needed to boot > to rootfs (i.e. storage and network drivers for nfsroot) are fine to > enable statically. > > I doubt you need the EEPROM driver to boot to rootfs on your system, > so please enable it as a module instead. > > Look into using config fragments in case you need to modify the > options for local builds, it should be a convenient way to have a > small delta to apply to fit your internal needs, instead of completely > forking the config file. Do you allow such config fragments to be upstreamed or do we need to maintain these in our tree? > > > -Olof > Thanks, Scott