From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754807AbbLQXsl (ORCPT ); Thu, 17 Dec 2015 18:48:41 -0500 Received: from gloria.sntech.de ([95.129.55.99]:50933 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753063AbbLQXsk (ORCPT ); Thu, 17 Dec 2015 18:48:40 -0500 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Kees Cook Cc: Caesar Wang , linux-rockchip@lists.infradead.org, "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , LKML , Leo Wang , Yakir Yang Subject: Re: [PATCH v1 0/6] Support the rk3036 Kylin board Date: Fri, 18 Dec 2015 00:48:36 +0100 Message-ID: <2077620.agNLOx8o2g@diego> User-Agent: KMail/4.14.10 (Linux/4.2.0-1-amd64; KDE/4.14.13; x86_64; ; ) In-Reply-To: References: <1450362112-8075-1-git-send-email-wxt@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Caesar, Kees, Am Donnerstag, 17. Dezember 2015, 11:45:06 schrieb Kees Cook: > On Thu, Dec 17, 2015 at 6:21 AM, Caesar Wang wrote: > > Kylin-board is based on RK3036 SOCs, add the initiation > > version for working. > > > > This series patches have the following decriptions: > > > > PATCH[1/6]: > > ARM: dts: fix the correct pinctrl control for rk3036 > > > > The pinctrl gpio pull up/down is incorrect since the rk3036 SoCs > > can't set the status in the internal. > > --- > > > > PATCH[2/6]: > > ARM: dts: add the lcdc and hdmi node for rk3036 > > > > Add the devices is related to display. > > Based on the series patches of Mark Yao's > > --- > > > > PATCH[3/6]: > > ARM: dts: add the sdio/sdmmc node for rk3036 > > > > Add the wifi/sd card work for kylin board. > > --- > > > > PATCH[4/6]: > > ARM: dts: rockchip: add the kylin board for rk3036 > > > > Add the dts for kylin board. > > --- > > > > PATCH[5/6]: > > ARM: dts: add the sound codec for kylin board > > > > Make the codec rt5616 working on kylin board. > > The realteak have been upstream for Mark Brown, > > I guess need some days to review. > > > > --- > > > > PATCH[6/6]: > > ARM: dts: add the sdio node for kylin board > > > > Enable the sdio for kylin board. > > --- > > Thanks for sending this! > > Reviewed-by: Kees Cook > > Some thoughts: maybe collapse 4, 5, and 6 together, since it's a new file? @Caesar, no need to resend, I can do that merging myself. After we clarified the authorship of patch1 ;-) . Except the audio patch, as we're missing the realtek codec driver. I'll also drop the lcdc+hdmi parts for now, as the relevant parts aren't in any maintainer-tree yet. The ordering is for this: - atomic conversion - rk3036 vop - inno-hdmi driver - dts changes last The driver for the Innosilicon hdmi driver is from November, had one comment from me and Caesar+ Yakir should make sure it works with the atomic modesetting variant of the drm/kms driver please. (And probably resend the series fixing that one tiny comment). Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH v1 0/6] Support the rk3036 Kylin board Date: Fri, 18 Dec 2015 00:48:36 +0100 Message-ID: <2077620.agNLOx8o2g@diego> References: <1450362112-8075-1-git-send-email-wxt@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Kees Cook Cc: Caesar Wang , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , LKML , Leo Wang , Yakir Yang List-Id: devicetree@vger.kernel.org Hi Caesar, Kees, Am Donnerstag, 17. Dezember 2015, 11:45:06 schrieb Kees Cook: > On Thu, Dec 17, 2015 at 6:21 AM, Caesar Wang wrote: > > Kylin-board is based on RK3036 SOCs, add the initiation > > version for working. > > > > This series patches have the following decriptions: > > > > PATCH[1/6]: > > ARM: dts: fix the correct pinctrl control for rk3036 > > > > The pinctrl gpio pull up/down is incorrect since the rk3036 SoCs > > can't set the status in the internal. > > --- > > > > PATCH[2/6]: > > ARM: dts: add the lcdc and hdmi node for rk3036 > > > > Add the devices is related to display. > > Based on the series patches of Mark Yao's > > --- > > > > PATCH[3/6]: > > ARM: dts: add the sdio/sdmmc node for rk3036 > > > > Add the wifi/sd card work for kylin board. > > --- > > > > PATCH[4/6]: > > ARM: dts: rockchip: add the kylin board for rk3036 > > > > Add the dts for kylin board. > > --- > > > > PATCH[5/6]: > > ARM: dts: add the sound codec for kylin board > > > > Make the codec rt5616 working on kylin board. > > The realteak have been upstream for Mark Brown, > > I guess need some days to review. > > > > --- > > > > PATCH[6/6]: > > ARM: dts: add the sdio node for kylin board > > > > Enable the sdio for kylin board. > > --- > > Thanks for sending this! > > Reviewed-by: Kees Cook > > Some thoughts: maybe collapse 4, 5, and 6 together, since it's a new file? @Caesar, no need to resend, I can do that merging myself. After we clarified the authorship of patch1 ;-) . Except the audio patch, as we're missing the realtek codec driver. I'll also drop the lcdc+hdmi parts for now, as the relevant parts aren't in any maintainer-tree yet. The ordering is for this: - atomic conversion - rk3036 vop - inno-hdmi driver - dts changes last The driver for the Innosilicon hdmi driver is from November, had one comment from me and Caesar+ Yakir should make sure it works with the atomic modesetting variant of the drm/kms driver please. (And probably resend the series fixing that one tiny comment). Heiko -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko =?ISO-8859-1?Q?St=FCbner?=) Date: Fri, 18 Dec 2015 00:48:36 +0100 Subject: [PATCH v1 0/6] Support the rk3036 Kylin board In-Reply-To: References: <1450362112-8075-1-git-send-email-wxt@rock-chips.com> Message-ID: <2077620.agNLOx8o2g@diego> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Caesar, Kees, Am Donnerstag, 17. Dezember 2015, 11:45:06 schrieb Kees Cook: > On Thu, Dec 17, 2015 at 6:21 AM, Caesar Wang wrote: > > Kylin-board is based on RK3036 SOCs, add the initiation > > version for working. > > > > This series patches have the following decriptions: > > > > PATCH[1/6]: > > ARM: dts: fix the correct pinctrl control for rk3036 > > > > The pinctrl gpio pull up/down is incorrect since the rk3036 SoCs > > can't set the status in the internal. > > --- > > > > PATCH[2/6]: > > ARM: dts: add the lcdc and hdmi node for rk3036 > > > > Add the devices is related to display. > > Based on the series patches of Mark Yao's > > --- > > > > PATCH[3/6]: > > ARM: dts: add the sdio/sdmmc node for rk3036 > > > > Add the wifi/sd card work for kylin board. > > --- > > > > PATCH[4/6]: > > ARM: dts: rockchip: add the kylin board for rk3036 > > > > Add the dts for kylin board. > > --- > > > > PATCH[5/6]: > > ARM: dts: add the sound codec for kylin board > > > > Make the codec rt5616 working on kylin board. > > The realteak have been upstream for Mark Brown, > > I guess need some days to review. > > > > --- > > > > PATCH[6/6]: > > ARM: dts: add the sdio node for kylin board > > > > Enable the sdio for kylin board. > > --- > > Thanks for sending this! > > Reviewed-by: Kees Cook > > Some thoughts: maybe collapse 4, 5, and 6 together, since it's a new file? @Caesar, no need to resend, I can do that merging myself. After we clarified the authorship of patch1 ;-) . Except the audio patch, as we're missing the realtek codec driver. I'll also drop the lcdc+hdmi parts for now, as the relevant parts aren't in any maintainer-tree yet. The ordering is for this: - atomic conversion - rk3036 vop - inno-hdmi driver - dts changes last The driver for the Innosilicon hdmi driver is from November, had one comment from me and Caesar+ Yakir should make sure it works with the atomic modesetting variant of the drm/kms driver please. (And probably resend the series fixing that one tiny comment). Heiko