From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C392C7618F for ; Mon, 22 Jul 2019 18:35:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DA41121901 for ; Mon, 22 Jul 2019 18:35:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731293AbfGVSfi (ORCPT ); Mon, 22 Jul 2019 14:35:38 -0400 Received: from smtprelay0152.hostedemail.com ([216.40.44.152]:56129 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727744AbfGVSfh (ORCPT ); Mon, 22 Jul 2019 14:35:37 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay01.hostedemail.com (Postfix) with ESMTP id 37ADE100E806B; Mon, 22 Jul 2019 18:35:36 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: sort55_4dc629887d118 X-Filterd-Recvd-Size: 2243 Received: from XPS-9350.home (cpe-23-242-196-136.socal.res.rr.com [23.242.196.136]) (Authenticated sender: joe@perches.com) by omf10.hostedemail.com (Postfix) with ESMTPA; Mon, 22 Jul 2019 18:35:34 +0000 (UTC) Message-ID: <207e201cb7a36e38f032bcb66e79e2d4b9b63c7b.camel@perches.com> Subject: Re: [RFC PATCH] string.h: Add stracpy/stracpy_pad (was: Re: [PATCH] checkpatch: Added warnings in favor of strscpy().) From: Joe Perches To: Matthew Wilcox Cc: Kees Cook , Nitin Gote , akpm@linux-foundation.org, corbet@lwn.net, apw@canonical.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-hardening@lists.openwall.com, Rasmus Villemoes Date: Mon, 22 Jul 2019 11:35:33 -0700 In-Reply-To: <20190722182703.GE363@bombadil.infradead.org> References: <1562219683-15474-1-git-send-email-nitin.r.gote@intel.com> <201907221031.8B87A9DE@keescook> <2c959c56c23d0052e5c35ecfa2f6051b17fb2798.camel@perches.com> <20190722182703.GE363@bombadil.infradead.org> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.5-0ubuntu0.18.10.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2019-07-22 at 11:27 -0700, Matthew Wilcox wrote: > On Mon, Jul 22, 2019 at 10:58:15AM -0700, Joe Perches wrote: > > On Mon, 2019-07-22 at 10:43 -0700, Joe Perches wrote: > > > On Mon, 2019-07-22 at 10:33 -0700, Kees Cook wrote: > > > > On Thu, Jul 04, 2019 at 05:15:57PM -0700, Joe Perches wrote: > > > > > On Thu, 2019-07-04 at 13:46 -0700, Joe Perches wrote: [] > > > > > +#define stracpy(to, from) \ > > > > > +({ \ > > > > > + size_t size = ARRAY_SIZE(to); \ > > > > > + BUILD_BUG_ON(!__same_type(typeof(*to), char)); \ > > > > > + \ > > > > > + strscpy(to, from, size); \ > > > > > +}) > > Where does the 'a' in 'stracpy' come from? No place in particular. I used it because dst has to be an 'a'rray rather than a pointer. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD450C7618F for ; Mon, 22 Jul 2019 18:35:55 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id 136EF2190D for ; Mon, 22 Jul 2019 18:35:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 136EF2190D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-16533-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 22024 invoked by uid 550); 22 Jul 2019 18:35:49 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 21980 invoked from network); 22 Jul 2019 18:35:48 -0000 X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: sort55_4dc629887d118 X-Filterd-Recvd-Size: 2243 Message-ID: <207e201cb7a36e38f032bcb66e79e2d4b9b63c7b.camel@perches.com> Subject: Re: [RFC PATCH] string.h: Add stracpy/stracpy_pad (was: Re: [PATCH] checkpatch: Added warnings in favor of strscpy().) From: Joe Perches To: Matthew Wilcox Cc: Kees Cook , Nitin Gote , akpm@linux-foundation.org, corbet@lwn.net, apw@canonical.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-hardening@lists.openwall.com, Rasmus Villemoes Date: Mon, 22 Jul 2019 11:35:33 -0700 In-Reply-To: <20190722182703.GE363@bombadil.infradead.org> References: <1562219683-15474-1-git-send-email-nitin.r.gote@intel.com> <201907221031.8B87A9DE@keescook> <2c959c56c23d0052e5c35ecfa2f6051b17fb2798.camel@perches.com> <20190722182703.GE363@bombadil.infradead.org> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.5-0ubuntu0.18.10.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit On Mon, 2019-07-22 at 11:27 -0700, Matthew Wilcox wrote: > On Mon, Jul 22, 2019 at 10:58:15AM -0700, Joe Perches wrote: > > On Mon, 2019-07-22 at 10:43 -0700, Joe Perches wrote: > > > On Mon, 2019-07-22 at 10:33 -0700, Kees Cook wrote: > > > > On Thu, Jul 04, 2019 at 05:15:57PM -0700, Joe Perches wrote: > > > > > On Thu, 2019-07-04 at 13:46 -0700, Joe Perches wrote: [] > > > > > +#define stracpy(to, from) \ > > > > > +({ \ > > > > > + size_t size = ARRAY_SIZE(to); \ > > > > > + BUILD_BUG_ON(!__same_type(typeof(*to), char)); \ > > > > > + \ > > > > > + strscpy(to, from, size); \ > > > > > +}) > > Where does the 'a' in 'stracpy' come from? No place in particular. I used it because dst has to be an 'a'rray rather than a pointer.