From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: Helge Deller <deller@gmx.de>, Sven Schnelle <svens@stackframe.org>
Cc: linux-parisc@vger.kernel.org
Subject: Re: [PATCH v3 4/4] parisc: add support for TOC (transfer of control)
Date: Sat, 16 Oct 2021 18:49:34 +0200 [thread overview]
Message-ID: <2081016.irdbgypaU6@daneel.sf-tec.de> (raw)
In-Reply-To: <20211014194916.13901-5-svens@stackframe.org>
[-- Attachment #1: Type: text/plain, Size: 1419 bytes --]
Sven Schnelle wrote:
> diff --git a/arch/parisc/Kconfig b/arch/parisc/Kconfig
> index 27a8b49af11f..97a889eaffe1 100644
> --- a/arch/parisc/Kconfig
> +++ b/arch/parisc/Kconfig
> @@ -288,6 +288,20 @@ config SMP
>
> If you don't know what to do here, say N.
>
> +config TOC
> + bool "Support TOC switch"
> + default y if 64BIT || !SMP
> + help
> + Most PA-RISC machines have either a switch at the back of the
machine
> + or a command in BMC to trigger a TOC interrupt. If you say Y here
a
> + handler will be installed which will either show a backtrace on
all
> + CPUs, or enter a possible configured debugger like kgdb/kdb.
> +
> + Note that with this option enabled, the kernel will use an
additional
> 16KB + per possible CPU as a special stack for the TOC handler.
> +
> + If you don't want to debug the Kernel, so N.
so -> say?
> +void notrace __noreturn __cold toc_intr(struct pt_regs *regs)
> +{
> + struct pdc_toc_pim_20 pim_data20;
> + struct pdc_toc_pim_11 pim_data11;
> +
> + nmi_enter();
> +
> + if (boot_cpu_data.cpu_type >= pcxu) {
> + if (pdc_pim_toc20(&pim_data20))
> + panic("Failed to get PIM data");
> + toc20_to_pt_regs(regs, &pim_data20);
> + } else {
> + if (pdc_pim_toc11(&pim_data11))
> + panic("Failed to get PIM data");
> + toc11_to_pt_regs(regs, &pim_data11);
> + }
As I said elsewhere because I had missed v3: move the variables in the if
branches.
Eike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2021-10-16 16:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 19:49 [PATCH v3 0/4] add TOC support Sven Schnelle
2021-10-14 19:49 ` [PATCH v3 1/4] parisc: move virt_map macro to assembly.h Sven Schnelle
2021-10-14 19:49 ` [PATCH v3 2/4] parisc: add PIM TOC data structures Sven Schnelle
2021-10-14 19:49 ` [PATCH v3 3/4] parisc/firmware: add functions to retrieve TOC data Sven Schnelle
2021-10-14 19:49 ` [PATCH v3 4/4] parisc: add support for TOC (transfer of control) Sven Schnelle
2021-10-16 16:49 ` Rolf Eike Beer [this message]
2021-10-16 16:56 ` Helge Deller
2021-10-14 20:27 ` [PATCH v3 0/4] add TOC support Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2081016.irdbgypaU6@daneel.sf-tec.de \
--to=eike-kernel@sf-tec.de \
--cc=deller@gmx.de \
--cc=linux-parisc@vger.kernel.org \
--cc=svens@stackframe.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.