All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	dri-devel@lists.freedesktop.org, linux-sunxi@lists.linux.dev,
	Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
Subject: Re: Empty IN_FORMATS in sun4i-drm
Date: Tue, 14 Dec 2021 18:58:56 +0100	[thread overview]
Message-ID: <2084377.irdbgypaU6@kista> (raw)
In-Reply-To: <20211214120248.y2zdzr5zsqowixjx@luna>

Dne torek, 14. december 2021 ob 13:02:48 CET je Emmanuel Gil Peyrot 
napisal(a):
> Hi,
> 
> After updating Weston from 9f8561e9 to 07326040 (latest master), it
> fails to run on my PinePhone saying “format 0x34325258 not supported by
> output DSI-1” and then exiting.
> 
> This format is XR24, which would be extremely surprising not to be
> present, and drm_info[1] says it is present.  Looking into Weston’s
> code, I found that drm_plane_populate_formats()’s docstring says it uses
> “either the IN_FORMATS blob property (if available), or the plane's
> format list if not.”  Looking back at drm_info, I saw said IN_FORMATS
> blob being empty of formats (while the format list is fully populated):
> "IN_FORMATS" (immutable): blob = 32
> └───DRM_FORMAT_MOD_LINEAR (0x0)

Does this solve your issue? http://ix.io/3Ipo

Best regards,
Jernej

> 
> This makes me think the kernel should populate IN_FORMATS with at least
> the same formats as the format list when supported, or stop advertising
> this property altogether.
> 
> Other compositors (such as phoc) still run file, probably because they
> use the format list exclusively, without consideration for modifiers.
> 
> Besides fixing this driver, would it make sense to also make Weston
> ignore an empty IN_FORMATS and fall back to the format list?
> 
> Thanks,
> 
> [1] https://github.com/ascent12/drm_info
> 
> -- 
> Emmanuel Gil Peyrot
> 



  reply	other threads:[~2021-12-14 17:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-14 12:02 Empty IN_FORMATS in sun4i-drm Emmanuel Gil Peyrot
2021-12-14 17:58 ` Jernej Škrabec [this message]
2021-12-23  9:59   ` Emmanuel Gil Peyrot
2021-12-23  9:59     ` Emmanuel Gil Peyrot
2021-12-24  6:33     ` Jernej Škrabec
2021-12-24  6:33       ` Jernej Škrabec
     [not found] <Ybiu8jZEyRii44Dw@luna>
2021-12-14 16:34 ` Simon Ser
2021-12-14 16:34   ` Simon Ser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2084377.irdbgypaU6@kista \
    --to=jernej.skrabec@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linkmauve@linkmauve.fr \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=mripard@kernel.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.