From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6FFC23A9; Sun, 6 Nov 2022 09:13:14 +0000 (UTC) Received: by mail-ej1-f45.google.com with SMTP id b2so23126393eja.6; Sun, 06 Nov 2022 01:13:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kB5x5Lb8Br6d/Jeea8bVOt5eSs5IgdDtxZC3hRWWkBA=; b=U8zWoIusLivflIrhe/QqeEUiTBHp0weDQtpu7a3iD1sc9QTKpwALpgF1vtgRfCzikb 37wK32SeseS2JESpp01aC/H0tP0qOFSyd2ZFLVWP+RvfWoyE1KbjxaH3rxX0jkxtrlgJ D6USi7yXUC6kWqFuNsQzUPJaqoT9qZlwHyH2mQA4rILUJwQh3tpZaZbOgdAsquswiD1L p2ZpctsvirMCFQ/3saaqaii0fPnzKCyGC/7aHR+enUeY8lG7bv/DW4W44BETId09iXoa RX3yDYau3yE4BILllMhrojO6TJGi2PlX34S51wpMGtyy5OCxFuyQPOtqjporW0oe+YLD 5mpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kB5x5Lb8Br6d/Jeea8bVOt5eSs5IgdDtxZC3hRWWkBA=; b=Y+c5uQwCWFHdCCjCc5PidwB1X2n2AOdK+D6ZQ+FRD0RIHd4ALjTNViBLS74wyPKIlh bbb6QhhKOthvUM6Yc4SCa5skDOX0IlZ8fpn8dvTexJvLYwoE8V6P/VKjfk9VTMfIxil4 +gJh6ETocP5A5Iih9d8JB5zg/DDd8HcGlvkkMooSzcn3eY5fUCh8FMpyDfSx9k/KeKWb WQwxNgVomvnvXBFr0V/pidqwARvsFk9LX0c+PUJD0PGsXxGb3YuEZkjNyvfol2QqiAst 9YSzMzbdkScL7XeQbRj2ezq0QbNrdPQIpZhopBhkh1PtqR+VLriwBaSDjUvZ0VNOfQO4 3Y1w== X-Gm-Message-State: ACrzQf21u5bCwtC+NQSsvEHs7+7R4KNey5BO8/5y8TynI3gdzYb/ITh1 /cITjadCD7iFRSx0PHxy+3s= X-Google-Smtp-Source: AMsMyM7WcxErEBkvYvl5QcgwyJodv5qAgL63AB5uiIt8PX9pxynGvsrLzYqtMYJ/J3DxD2waFR33CQ== X-Received: by 2002:a17:907:a4e:b0:77d:94d:8148 with SMTP id be14-20020a1709070a4e00b0077d094d8148mr40810136ejc.607.1667725992932; Sun, 06 Nov 2022 01:13:12 -0800 (PST) Received: from jernej-laptop.localnet (89-212-118-115.static.t-2.net. [89.212.118.115]) by smtp.gmail.com with ESMTPSA id r23-20020aa7d597000000b004638ba0ea96sm2301896edq.97.2022.11.06.01.13.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Nov 2022 01:13:12 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Paul Kocialkowski Cc: Paul Kocialkowski , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Chen-Yu Tsai , Samuel Holland , Sakari Ailus , Hans Verkuil , Laurent Pinchart , Maxime Ripard , Thomas Petazzoni Subject: Re: [PATCH v8 6/6] media: sun6i-csi: Add support for hooking to the isp devices Date: Sun, 06 Nov 2022 10:13:11 +0100 Message-ID: <2085642.OBFZWjSADL@jernej-laptop> In-Reply-To: <20221103163717.246217-7-paul.kocialkowski@bootlin.com> References: <20221103163717.246217-1-paul.kocialkowski@bootlin.com> <20221103163717.246217-7-paul.kocialkowski@bootlin.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Dne =C4=8Detrtek, 03. november 2022 ob 17:37:17 CET je Paul Kocialkowski=20 napisal(a): > In order to use the isp and csi together, both devices need to be > parented to the same v4l2 and media devices. We use the isp as > top-level device and let the csi code hook to its v4l2 and media > devices when async subdev registration takes place. >=20 > As a result v4l2/media device setup is only called when the ISP > is missing and the capture device is registered after the devices > are hooked. The bridge subdev and its notifier are registered > without any device when the ISP is available. Top-level pointers > for the devices are introduced to either redirect to the hooked ones > (isp available) or the registered ones (isp missing). >=20 > Also keep track of whether the capture node was setup or not to > avoid cleaning up resources when it wasn't. >=20 > Signed-off-by: Paul Kocialkowski Acked-by: Jernej Skrabec Best regards, Jernej From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54E91C433FE for ; Sun, 6 Nov 2022 09:14:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=df+G7QpsHUCyHVB6EvHWOoB7H8ctotiiUiBcj0bQ8Oo=; b=hrd9cl+ZQdZLQf MU+C1gJrQoVB/4TcyXXMS70lmoV/vaA8hHo9SsnGvDfss1rMv90P/lcz2AOXJ01AJ+3uhO+s2H8Xu JbFtbye/X0mTNFY3R9PPuiZlzpOBKye4iB9p1jl29lIr5GgOAP7Kct4YPKbcF0Er8nU9583KK51af vmrGsezjsWPUnV0P9Gm/11Mj5DZHQsm1LUxpzsbX1wiYz+KftuKCgnewRQoz1TYeMkOB6Iybz/bhD U+OSQXi+04e5Gy2fWoYC1XRvAJGQptIWUmi1arrwDpZ8OrbMP1SevZJuZfPhPyxZIhdf6iwlpLN22 dsq2oO/itLSNt6IoRk4w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1orbiQ-007ozl-BP; Sun, 06 Nov 2022 09:13:18 +0000 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1orbiM-007oy2-Tf for linux-arm-kernel@lists.infradead.org; Sun, 06 Nov 2022 09:13:16 +0000 Received: by mail-ej1-x634.google.com with SMTP id q9so23254494ejd.0 for ; Sun, 06 Nov 2022 01:13:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kB5x5Lb8Br6d/Jeea8bVOt5eSs5IgdDtxZC3hRWWkBA=; b=U8zWoIusLivflIrhe/QqeEUiTBHp0weDQtpu7a3iD1sc9QTKpwALpgF1vtgRfCzikb 37wK32SeseS2JESpp01aC/H0tP0qOFSyd2ZFLVWP+RvfWoyE1KbjxaH3rxX0jkxtrlgJ D6USi7yXUC6kWqFuNsQzUPJaqoT9qZlwHyH2mQA4rILUJwQh3tpZaZbOgdAsquswiD1L p2ZpctsvirMCFQ/3saaqaii0fPnzKCyGC/7aHR+enUeY8lG7bv/DW4W44BETId09iXoa RX3yDYau3yE4BILllMhrojO6TJGi2PlX34S51wpMGtyy5OCxFuyQPOtqjporW0oe+YLD 5mpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kB5x5Lb8Br6d/Jeea8bVOt5eSs5IgdDtxZC3hRWWkBA=; b=6L6jUe71SAFK44y1fTcn3U3zXcnHq4i30jYvicIIMlsSC+/cHbJb7wAhr4q5xniMQj zdXzPw/e8SPS4b+sqGilkdTgq2y/SfImvS7LrlO7zDHsO3+GClYDoJK3gU9sJ2Fc234Q qaU0lMkzz1AsSW4r4QY45nOosZwf+UXnh2ecxF3lx+8YaR/s82LrRp3h4gcXGZWEnG1Z lZjVn5gIoG22Kor2lYnaMh2dCnIkgjNBNOhFfy2KKr/Iz5IXOHME09lYbhLkPbttXET1 HwwqxtWaRhpcB992zjSvPd6yikKnEdt1k0ZqjvKhny9r87ZMQDWv4mzaqdyE6aBDo7Iw +MXA== X-Gm-Message-State: ACrzQf3QkPzJxGAIXV80aGtPX+xFnTbcJ4VCwic6ZRB5dQ4PRcVTzt4H U/r8VgauV8QI3FSmgs3IXs8= X-Google-Smtp-Source: AMsMyM7WcxErEBkvYvl5QcgwyJodv5qAgL63AB5uiIt8PX9pxynGvsrLzYqtMYJ/J3DxD2waFR33CQ== X-Received: by 2002:a17:907:a4e:b0:77d:94d:8148 with SMTP id be14-20020a1709070a4e00b0077d094d8148mr40810136ejc.607.1667725992932; Sun, 06 Nov 2022 01:13:12 -0800 (PST) Received: from jernej-laptop.localnet (89-212-118-115.static.t-2.net. [89.212.118.115]) by smtp.gmail.com with ESMTPSA id r23-20020aa7d597000000b004638ba0ea96sm2301896edq.97.2022.11.06.01.13.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Nov 2022 01:13:12 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Paul Kocialkowski Cc: Paul Kocialkowski , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Chen-Yu Tsai , Samuel Holland , Sakari Ailus , Hans Verkuil , Laurent Pinchart , Maxime Ripard , Thomas Petazzoni Subject: Re: [PATCH v8 6/6] media: sun6i-csi: Add support for hooking to the isp devices Date: Sun, 06 Nov 2022 10:13:11 +0100 Message-ID: <2085642.OBFZWjSADL@jernej-laptop> In-Reply-To: <20221103163717.246217-7-paul.kocialkowski@bootlin.com> References: <20221103163717.246217-1-paul.kocialkowski@bootlin.com> <20221103163717.246217-7-paul.kocialkowski@bootlin.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221106_011314_975236_8671D946 X-CRM114-Status: GOOD ( 14.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RG5lIMSNZXRydGVrLCAwMy4gbm92ZW1iZXIgMjAyMiBvYiAxNzozNzoxNyBDRVQgamUgUGF1bCBL b2NpYWxrb3dza2kgCm5hcGlzYWwoYSk6Cj4gSW4gb3JkZXIgdG8gdXNlIHRoZSBpc3AgYW5kIGNz aSB0b2dldGhlciwgYm90aCBkZXZpY2VzIG5lZWQgdG8gYmUKPiBwYXJlbnRlZCB0byB0aGUgc2Ft ZSB2NGwyIGFuZCBtZWRpYSBkZXZpY2VzLiBXZSB1c2UgdGhlIGlzcCBhcwo+IHRvcC1sZXZlbCBk ZXZpY2UgYW5kIGxldCB0aGUgY3NpIGNvZGUgaG9vayB0byBpdHMgdjRsMiBhbmQgbWVkaWEKPiBk ZXZpY2VzIHdoZW4gYXN5bmMgc3ViZGV2IHJlZ2lzdHJhdGlvbiB0YWtlcyBwbGFjZS4KPiAKPiBB cyBhIHJlc3VsdCB2NGwyL21lZGlhIGRldmljZSBzZXR1cCBpcyBvbmx5IGNhbGxlZCB3aGVuIHRo ZSBJU1AKPiBpcyBtaXNzaW5nIGFuZCB0aGUgY2FwdHVyZSBkZXZpY2UgaXMgcmVnaXN0ZXJlZCBh ZnRlciB0aGUgZGV2aWNlcwo+IGFyZSBob29rZWQuIFRoZSBicmlkZ2Ugc3ViZGV2IGFuZCBpdHMg bm90aWZpZXIgYXJlIHJlZ2lzdGVyZWQKPiB3aXRob3V0IGFueSBkZXZpY2Ugd2hlbiB0aGUgSVNQ IGlzIGF2YWlsYWJsZS4gVG9wLWxldmVsIHBvaW50ZXJzCj4gZm9yIHRoZSBkZXZpY2VzIGFyZSBp bnRyb2R1Y2VkIHRvIGVpdGhlciByZWRpcmVjdCB0byB0aGUgaG9va2VkIG9uZXMKPiAoaXNwIGF2 YWlsYWJsZSkgb3IgdGhlIHJlZ2lzdGVyZWQgb25lcyAoaXNwIG1pc3NpbmcpLgo+IAo+IEFsc28g a2VlcCB0cmFjayBvZiB3aGV0aGVyIHRoZSBjYXB0dXJlIG5vZGUgd2FzIHNldHVwIG9yIG5vdCB0 bwo+IGF2b2lkIGNsZWFuaW5nIHVwIHJlc291cmNlcyB3aGVuIGl0IHdhc24ndC4KPiAKPiBTaWdu ZWQtb2ZmLWJ5OiBQYXVsIEtvY2lhbGtvd3NraSA8cGF1bC5rb2NpYWxrb3dza2lAYm9vdGxpbi5j b20+CgpBY2tlZC1ieTogSmVybmVqIFNrcmFiZWMgPGplcm5lai5za3JhYmVjQGdtYWlsLmNvbT4K CkJlc3QgcmVnYXJkcywKSmVybmVqCgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK