From: Richard Weinberger <richard@nod.at>
To: Vignesh Raghavendra <vigneshr@ti.com>
Cc: Tudor Ambarus <Tudor.Ambarus@microchip.com>,
linux-mtd <linux-mtd@lists.infradead.org>,
Miquel Raynal <miquel.raynal@bootlin.com>
Subject: Re: [GIT PULL] CFI and HyperFlash changes for v5.10-rc1
Date: Sun, 11 Oct 2020 22:42:21 +0200 (CEST) [thread overview]
Message-ID: <2085985092.185629.1602448941236.JavaMail.zimbra@nod.at> (raw)
In-Reply-To: <6755a43e-1fec-4a5f-760d-44ac834787aa@ti.com>
Vignesh,
----- Ursprüngliche Mail -----
> Von: "Vignesh Raghavendra" <vigneshr@ti.com>
> An: "Miquel Raynal" <miquel.raynal@bootlin.com>, "richard" <richard@nod.at>
> CC: "linux-mtd" <linux-mtd@lists.infradead.org>, "Tudor Ambarus" <Tudor.Ambarus@microchip.com>
> Gesendet: Freitag, 9. Oktober 2020 13:43:36
> Betreff: [GIT PULL] CFI and HyperFlash changes for v5.10-rc1
> Hi Miquel, Richard,
>
> Here is the CFI and HyperFlash related PR for v5.10-rc1. Thanks!
>
> Regards
> Vignesh
>
> The following changes since commit ba4f184e126b751d1bffad5897f263108befc780:
>
> Linux 5.9-rc6 (2020-09-20 16:33:55 -0700)
Did you base your patches on purpose on -rc6?
mtd/next is based on -rc2.
Not a big deal, but can cause confusion.
> are available in the Git repository at:
>
> git@gitolite.kernel.org:pub/scm/linux/kernel/git/mtd/linux.git tags/cfi/for-5.10
>
> for you to fetch changes up to 5de15b610f785f0e188fefb707f0b19de156968a:
>
> mtd: hyperbus: add Renesas RPC-IF driver (2020-10-06 12:36:21 +0530)
>
> ----------------------------------------------------------------
> HyperBus changes
>
> * DMA support for TI's AM654 HyperBus controller driver.
> * HyperBus frontend driver for Renesas RPC-IF driver.
>
> ----------------------------------------------------------------
> Sergei Shtylyov (1):
> mtd: hyperbus: add Renesas RPC-IF driver
>
> Vignesh Raghavendra (4):
> mtd: hyperbus: Provide per device private pointer
> mtd: hyperbus: hbmc-am654: Fix direct mapping setup flash access
> mtd: hyperbus: hbmc-am654: Drop pm_runtime* calls from probe
> mtd: hyperbus: hbmc-am654: Add DMA support for reads
5de15b610f78 ("mtd: hyperbus: add Renesas RPC-IF driver") does not build here
with CONFIG_COMPILE_TEST because the driver needs functions from CONFIG_RENESAS_RPCIF
which is only buildable for CONFIG_ARCH_RENESAS.
rpc-if.c:(.text+0x20): undefined reference to `rpcif_disable_rpm'
ld: drivers/mtd/hyperbus/rpc-if.o: in function `rpcif_hb_prepare_read':
rpc-if.c:(.text+0xd6): undefined reference to `rpcif_prepare'
ld: drivers/mtd/hyperbus/rpc-if.o: in function `rpcif_hb_read16':
rpc-if.c:(.text+0x170): undefined reference to `rpcif_manual_xfer'
ld: drivers/mtd/hyperbus/rpc-if.o: in function `rpcif_hb_probe':
rpc-if.c:(.text+0x1d5): undefined reference to `rpcif_sw_init'
ld: rpc-if.c:(.text+0x1e4): undefined reference to `rpcif_enable_rpm'
ld: rpc-if.c:(.text+0x1f1): undefined reference to `rpcif_hw_init'
ld: rpc-if.c:(.text+0x23f): undefined reference to `rpcif_disable_rpm'
ld: drivers/mtd/hyperbus/rpc-if.o: in function `rpcif_hb_write16':
rpc-if.c:(.text+0x2e5): undefined reference to `rpcif_prepare'
ld: rpc-if.c:(.text+0x2ed): undefined reference to `rpcif_manual_xfer'
ld: drivers/mtd/hyperbus/rpc-if.o: in function `rpcif_hb_copy_from':
rpc-if.c:(.text+0x12e): undefined reference to `rpcif_dirmap_read'
This should do the trick, please double check:
diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
index 2c79e95dd486..794740636bc4 100644
--- a/drivers/memory/Kconfig
+++ b/drivers/memory/Kconfig
@@ -181,7 +181,7 @@ config PL353_SMC
config RENESAS_RPCIF
tristate "Renesas RPC-IF driver"
- depends on ARCH_RENESAS
+ depends on ARCH_RENESAS || COMPILE_TEST
select REGMAP_MMIO
help
This supports Renesas R-Car Gen3 RPC-IF which provides either SPI
diff --git a/drivers/mtd/hyperbus/Kconfig b/drivers/mtd/hyperbus/Kconfig
index 35b3ab4c8b94..46c7e407e378 100644
--- a/drivers/mtd/hyperbus/Kconfig
+++ b/drivers/mtd/hyperbus/Kconfig
@@ -24,7 +24,7 @@ config HBMC_AM654
config RPCIF_HYPERBUS
tristate "Renesas RPC-IF HyperBus driver"
- depends on RENESAS_RPCIF || COMPILE_TEST
+ depends on RENESAS_RPCIF
depends on MTD_CFI_BE_BYTE_SWAP
help
This option includes Renesas RPC-IF HyperBus support.
Anyway, pulled. :-)
Thanks,
//richard
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-10-11 20:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 11:43 [GIT PULL] CFI and HyperFlash changes for v5.10-rc1 Vignesh Raghavendra
2020-10-11 20:42 ` Richard Weinberger [this message]
2020-10-12 6:43 ` Vignesh Raghavendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2085985092.185629.1602448941236.JavaMail.zimbra@nod.at \
--to=richard@nod.at \
--cc=Tudor.Ambarus@microchip.com \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.