Re: [PATCH v2] qemu-xen:Correctly expose PCH ISA bridge for IGD passthrough [and 2 more messages]

From: Ian Jackson <Ian.Jackson@eu.citrix.com>
To: Pasi Kakkainen <pasik@iki.fi>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>,
	Ian Campbell <Ian.Campbell@citrix.com>,
	"G.R." <firemeteor@users.sourceforge.net>,
	Jan Beulich <JBeulich@suse.com>,
	xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH v2] qemu-xen:Correctly expose PCH ISA bridge for IGD passthrough [and 2 more messages]
Date: Tue, 7 May 2013 18:12:30 +0100	[thread overview]
Message-ID: <20873.13822.177086.581233@mariner.uk.xensource.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1302251248100.5360@kaball.uk.xensource.com>, <alpine.DEB.2.02.1304181247590.7254@kaball.uk.xensource.com>, <20130503151442.GX11427@reaktio.net>

Stefano Stabellini writes ("Re: [Xen-devel] [PATCH v2] qemu-xen:Correctly expose PCH ISA bridge for IGD passthrough"):
> On Mon, 25 Feb 2013, Jan Beulich wrote:
> > >>> On 25.02.13 at 12:24, Ian Jackson <Ian.Jackson@eu.citrix.com> wrote:
> > > Jan Beulich writes ("Re: [Xen-devel] [PATCH v2] qemu-xen:Correctly expose PCH 
> > >> Which means that my pointing out of shortcomings in this patch
> > >> got completely ignored - we can only hope that this won't bite us
> > >> later...
> > > 
> > > Sorry about that, perhaps I didn't spot the thread.  Do you think it
> > > should be reverted ?
> > 
> > I'd prefer if you did so, and wait for a cleaned up version of the
> > patch to be submitted. If you leave in what's there right now, I
> > would b afraid that we'd never get to see a fixup patch on top.
> 
> You are talking about 5114F15002000078000BD2B2@nat28.tlf.novell.com?
> G.R., can you work on this patch a bit more and address Jan's comments?
> It shouldn't take long..

Stefano Stabellini writes ("Re: [Xen-devel] Patch series for IGD passthrough"):
> On Tue, 16 Apr 2013, George Dunlap wrote:
> > On Mon, Apr 15, 2013 at 9:48 PM, Pasi Kärkkäinen <pasik@iki.fi> wrote:
> > > On Wed, Mar 20, 2013 at 07:17:14PM +0200, Pasi Kärkkäinen wrote:
> > >> On Fri, Feb 08, 2013 at 12:12:05AM +0800, Rui Guo wrote:
> > >> > This series contains all the fixes required to produce a working IGD
> > >> > passthrough box. All the changes are previously seen in the dev list but
> > >> > not yet accepted. Some of them are out-dated and need some reshape.
> > >> >
> > >> > Detailed description can be found later in each patch.
> > >> >
> > >> > . [PATCH 1/3] qemu-xen-trad/pt_msi_disable: do not clear all MSI flags
> > >> > . [PATCH 2/3] qemu-xen-trad: Correctly expose PCH ISA bridge for IGD
> > >> > . [PATCH 3/3] qemu-xen-trad: IGD passthrough: Expose vendor specific
> > >> >
> > >>
> > >> Looking at qemu-xen-unstable I think patches 2 and 3 are not yet applied.
> > >> (patch 2 was applied earlier but it got reverted).
> > >>
> > >> Is it likely that we'll get these merged in for Xen 4.3 ?

Have you addressed Jan's comments from February ?  I don't see
anything saying you have done so.

Also please could you CC patches to the maintainer (ie, me, in this
case) and also to people who have commented on them in the past (Jan,
in this case).

Simply constantly pinging is not appropriate.

Ian.