From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sameer Pujar Subject: Re: [alsa-devel] [PATCH 7/9] ASoC: tegra: add Tegra210 based ADMAIF driver Date: Mon, 27 Jan 2020 10:38:39 +0530 Message-ID: <208e3f8b-75ca-9bb0-ad43-7489709fcae0@nvidia.com> References: <1579530198-13431-1-git-send-email-spujar@nvidia.com> <1579530198-13431-8-git-send-email-spujar@nvidia.com> <743d6d7d-f29c-191a-853b-414250ca38df@gmail.com> <3759aa0b-9e56-0fb4-27b7-4f98898d4e22@nvidia.com> <8a3259b7-6875-236a-b16c-cd8e023cc8b2@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <8a3259b7-6875-236a-b16c-cd8e023cc8b2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Content-Language: en-GB Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dmitry Osipenko , perex-/Fr2/VpizcU@public.gmane.org, tiwai-IBi9RG/b67k@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Cc: spujar-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, atalambedu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, viswanathl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, sharadg-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, rlokhande-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, mkumard-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, dramesh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 1/24/2020 9:55 AM, Dmitry Osipenko wrote: > External email: Use caution opening links or attachments > > > 24.01.2020 06:27, Sameer Pujar =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> >> On 1/24/2020 6:58 AM, Dmitry Osipenko wrote: >>> External email: Use caution opening links or attachments >>> >>> >>> 20.01.2020 17:23, Sameer Pujar =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>> [snip] >>>> +static bool tegra_admaif_wr_reg(struct device *dev, unsigned int reg) >>>> +{ >>>> + struct tegra_admaif *admaif =3D dev_get_drvdata(dev); >>>> + unsigned int ch_stride =3D TEGRA_ADMAIF_CHANNEL_REG_STRIDE; >>>> + unsigned int num_ch =3D admaif->soc_data->num_ch; >>>> + unsigned int rx_base =3D admaif->soc_data->rx_base; >>>> + unsigned int tx_base =3D admaif->soc_data->tx_base; >>>> + unsigned int global_base =3D admaif->soc_data->global_base; >>>> + unsigned int reg_max =3D >>>> admaif->soc_data->regmap_conf->max_register; >>>> + unsigned int rx_max =3D rx_base + (num_ch * ch_stride); >>>> + unsigned int tx_max =3D tx_base + (num_ch * ch_stride); >>>> + >>>> + if ((reg >=3D rx_base) && (reg < rx_max)) { >>> The braces are not needed around the comparisons because they precede >>> the AND. Same for all other similar occurrences in the code. >> While that is true, some prefer to use explicit braces to make it more >> readable. >> In the past I was told to use explicitly in such cases. > At least most of code in kernel (I've seen) doesn't have superfluous > parens (the curvy thingies actually should be the braces). Readability > is arguable in this case, I'm finding such code a bit more difficult to > read, although in some cases parens and spacing may help to read more > complex constructions. Yes this is subjective and depends on the individual reading the code. It i= s confusing every time, for the sender, about which guideline to follow.=20 Resending the patch/series for only this reason may not be really necessary. Since=20 I need to fix couple of issues in this series I may consider removing the=20 explicit braces. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8589C32771 for ; Mon, 27 Jan 2020 05:08:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A97C121569 for ; Mon, 27 Jan 2020 05:08:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="r7zqGfrH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727409AbgA0FIw (ORCPT ); Mon, 27 Jan 2020 00:08:52 -0500 Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:6398 "EHLO hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725308AbgA0FIv (ORCPT ); Mon, 27 Jan 2020 00:08:51 -0500 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Sun, 26 Jan 2020 21:08:01 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Sun, 26 Jan 2020 21:08:50 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Sun, 26 Jan 2020 21:08:50 -0800 Received: from [10.25.73.144] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 27 Jan 2020 05:08:43 +0000 CC: , , , , , , , , , , , , , , Subject: Re: [alsa-devel] [PATCH 7/9] ASoC: tegra: add Tegra210 based ADMAIF driver To: Dmitry Osipenko , , , References: <1579530198-13431-1-git-send-email-spujar@nvidia.com> <1579530198-13431-8-git-send-email-spujar@nvidia.com> <743d6d7d-f29c-191a-853b-414250ca38df@gmail.com> <3759aa0b-9e56-0fb4-27b7-4f98898d4e22@nvidia.com> <8a3259b7-6875-236a-b16c-cd8e023cc8b2@gmail.com> From: Sameer Pujar Message-ID: <208e3f8b-75ca-9bb0-ad43-7489709fcae0@nvidia.com> Date: Mon, 27 Jan 2020 10:38:39 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <8a3259b7-6875-236a-b16c-cd8e023cc8b2@gmail.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-GB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1580101682; bh=LUht9Gcr7wFh+xPtTMEK2tJj/GlzVeLgVO2GrvXpTH4=; h=X-PGP-Universal:CC:Subject:To:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding: Content-Language; b=r7zqGfrHqTIn5gRQgSMV5IVO6t8pSqTq+WbiKenqxJleVMdN9fyya9NRYRtTKyHxG MjhGVw8KTHShviWDQuvIHw7kj7ITLqH0Ccoz1XSSBZWj7hyJiskkKbshIES6xRtaFF 0KooO1eM4pJ7+6xk5oe1vMe8sdaN82o/HUJ/Nn5bSjWqDMoCHltLpdosFCatZYqykc IESo6RZUY82fH8gMbywez8Tik4Ncpd47t62SsOPI3mmKAQNLWFxQsqqU7ptPscSJ+5 tgvh8/OsOa1nRy2vPdMMAMKyDb/OtKlA2cATOPEDzgRU9bu+FrSiPNvn5+kMK1aMxl PDbr1F5GVIHhA== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/24/2020 9:55 AM, Dmitry Osipenko wrote: > External email: Use caution opening links or attachments > > > 24.01.2020 06:27, Sameer Pujar =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> >> On 1/24/2020 6:58 AM, Dmitry Osipenko wrote: >>> External email: Use caution opening links or attachments >>> >>> >>> 20.01.2020 17:23, Sameer Pujar =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >>> [snip] >>>> +static bool tegra_admaif_wr_reg(struct device *dev, unsigned int reg) >>>> +{ >>>> + struct tegra_admaif *admaif =3D dev_get_drvdata(dev); >>>> + unsigned int ch_stride =3D TEGRA_ADMAIF_CHANNEL_REG_STRIDE; >>>> + unsigned int num_ch =3D admaif->soc_data->num_ch; >>>> + unsigned int rx_base =3D admaif->soc_data->rx_base; >>>> + unsigned int tx_base =3D admaif->soc_data->tx_base; >>>> + unsigned int global_base =3D admaif->soc_data->global_base; >>>> + unsigned int reg_max =3D >>>> admaif->soc_data->regmap_conf->max_register; >>>> + unsigned int rx_max =3D rx_base + (num_ch * ch_stride); >>>> + unsigned int tx_max =3D tx_base + (num_ch * ch_stride); >>>> + >>>> + if ((reg >=3D rx_base) && (reg < rx_max)) { >>> The braces are not needed around the comparisons because they precede >>> the AND. Same for all other similar occurrences in the code. >> While that is true, some prefer to use explicit braces to make it more >> readable. >> In the past I was told to use explicitly in such cases. > At least most of code in kernel (I've seen) doesn't have superfluous > parens (the curvy thingies actually should be the braces). Readability > is arguable in this case, I'm finding such code a bit more difficult to > read, although in some cases parens and spacing may help to read more > complex constructions. Yes this is subjective and depends on the individual reading the code. It i= s confusing every time, for the sender, about which guideline to follow.=20 Resending the patch/series for only this reason may not be really necessary. Since=20 I need to fix couple of issues in this series I may consider removing the=20 explicit braces. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56880C32771 for ; Mon, 27 Jan 2020 05:10:02 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D43D3214DB for ; Mon, 27 Jan 2020 05:10:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="s9ZBoZdV"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="r7zqGfrH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D43D3214DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 31D771672; Mon, 27 Jan 2020 06:09:10 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 31D771672 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1580101800; bh=WWw7YBIiVqBubGfqk089k9d8SX1TPufRXIR/baz4m8s=; h=To:References:From:Date:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=s9ZBoZdVqvc24bZMICs7Ug/5P+tKFekUHnbhqrh68+UrjifPQJsMFT0osni3U6z3t MNRwIyhVdxFQu1nu1aBCGwb0Tc0gsV6qitBb7KVJuDXpk9wLl+BzMhbULKRUVzqXaS OC5IrXs2kKVx7iwMj88IBvv1k4PjlHKxznOiTpf4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 8ABE1F80218; Mon, 27 Jan 2020 06:09:09 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 20FE4F8021E; Mon, 27 Jan 2020 06:09:03 +0100 (CET) Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com [216.228.121.143]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4CFCCF800C8 for ; Mon, 27 Jan 2020 06:08:53 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4CFCCF800C8 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="r7zqGfrH" Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Sun, 26 Jan 2020 21:08:01 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Sun, 26 Jan 2020 21:08:50 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Sun, 26 Jan 2020 21:08:50 -0800 Received: from [10.25.73.144] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 27 Jan 2020 05:08:43 +0000 To: Dmitry Osipenko , , , References: <1579530198-13431-1-git-send-email-spujar@nvidia.com> <1579530198-13431-8-git-send-email-spujar@nvidia.com> <743d6d7d-f29c-191a-853b-414250ca38df@gmail.com> <3759aa0b-9e56-0fb4-27b7-4f98898d4e22@nvidia.com> <8a3259b7-6875-236a-b16c-cd8e023cc8b2@gmail.com> From: Sameer Pujar Message-ID: <208e3f8b-75ca-9bb0-ad43-7489709fcae0@nvidia.com> Date: Mon, 27 Jan 2020 10:38:39 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <8a3259b7-6875-236a-b16c-cd8e023cc8b2@gmail.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) Content-Language: en-GB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1580101682; bh=LUht9Gcr7wFh+xPtTMEK2tJj/GlzVeLgVO2GrvXpTH4=; h=X-PGP-Universal:CC:Subject:To:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding: Content-Language; b=r7zqGfrHqTIn5gRQgSMV5IVO6t8pSqTq+WbiKenqxJleVMdN9fyya9NRYRtTKyHxG MjhGVw8KTHShviWDQuvIHw7kj7ITLqH0Ccoz1XSSBZWj7hyJiskkKbshIES6xRtaFF 0KooO1eM4pJ7+6xk5oe1vMe8sdaN82o/HUJ/Nn5bSjWqDMoCHltLpdosFCatZYqykc IESo6RZUY82fH8gMbywez8Tik4Ncpd47t62SsOPI3mmKAQNLWFxQsqqU7ptPscSJ+5 tgvh8/OsOa1nRy2vPdMMAMKyDb/OtKlA2cATOPEDzgRU9bu+FrSiPNvn5+kMK1aMxl PDbr1F5GVIHhA== Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, spujar@nvidia.com, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, viswanathl@nvidia.com, linux-tegra@vger.kernel.org, broonie@kernel.org, atalambedu@nvidia.com, sharadg@nvidia.com, thierry.reding@gmail.com, jonathanh@nvidia.com, rlokhande@nvidia.com, mkumard@nvidia.com, dramesh@nvidia.com Subject: Re: [alsa-devel] [PATCH 7/9] ASoC: tegra: add Tegra210 based ADMAIF driver X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" CgpPbiAxLzI0LzIwMjAgOTo1NSBBTSwgRG1pdHJ5IE9zaXBlbmtvIHdyb3RlOgo+IEV4dGVybmFs IGVtYWlsOiBVc2UgY2F1dGlvbiBvcGVuaW5nIGxpbmtzIG9yIGF0dGFjaG1lbnRzCj4KPgo+IDI0 LjAxLjIwMjAgMDY6MjcsIFNhbWVlciBQdWphciDQv9C40YjQtdGCOgo+Pgo+PiBPbiAxLzI0LzIw MjAgNjo1OCBBTSwgRG1pdHJ5IE9zaXBlbmtvIHdyb3RlOgo+Pj4gRXh0ZXJuYWwgZW1haWw6IFVz ZSBjYXV0aW9uIG9wZW5pbmcgbGlua3Mgb3IgYXR0YWNobWVudHMKPj4+Cj4+Pgo+Pj4gMjAuMDEu MjAyMCAxNzoyMywgU2FtZWVyIFB1amFyINC/0LjRiNC10YI6Cj4+PiBbc25pcF0KPj4+PiArc3Rh dGljIGJvb2wgdGVncmFfYWRtYWlmX3dyX3JlZyhzdHJ1Y3QgZGV2aWNlICpkZXYsIHVuc2lnbmVk IGludCByZWcpCj4+Pj4gK3sKPj4+PiArICAgICBzdHJ1Y3QgdGVncmFfYWRtYWlmICphZG1haWYg PSBkZXZfZ2V0X2RydmRhdGEoZGV2KTsKPj4+PiArICAgICB1bnNpZ25lZCBpbnQgY2hfc3RyaWRl ID0gVEVHUkFfQURNQUlGX0NIQU5ORUxfUkVHX1NUUklERTsKPj4+PiArICAgICB1bnNpZ25lZCBp bnQgbnVtX2NoID0gYWRtYWlmLT5zb2NfZGF0YS0+bnVtX2NoOwo+Pj4+ICsgICAgIHVuc2lnbmVk IGludCByeF9iYXNlID0gYWRtYWlmLT5zb2NfZGF0YS0+cnhfYmFzZTsKPj4+PiArICAgICB1bnNp Z25lZCBpbnQgdHhfYmFzZSA9IGFkbWFpZi0+c29jX2RhdGEtPnR4X2Jhc2U7Cj4+Pj4gKyAgICAg dW5zaWduZWQgaW50IGdsb2JhbF9iYXNlID0gYWRtYWlmLT5zb2NfZGF0YS0+Z2xvYmFsX2Jhc2U7 Cj4+Pj4gKyAgICAgdW5zaWduZWQgaW50IHJlZ19tYXggPQo+Pj4+IGFkbWFpZi0+c29jX2RhdGEt PnJlZ21hcF9jb25mLT5tYXhfcmVnaXN0ZXI7Cj4+Pj4gKyAgICAgdW5zaWduZWQgaW50IHJ4X21h eCA9IHJ4X2Jhc2UgKyAobnVtX2NoICogY2hfc3RyaWRlKTsKPj4+PiArICAgICB1bnNpZ25lZCBp bnQgdHhfbWF4ID0gdHhfYmFzZSArIChudW1fY2ggKiBjaF9zdHJpZGUpOwo+Pj4+ICsKPj4+PiAr ICAgICBpZiAoKHJlZyA+PSByeF9iYXNlKSAmJiAocmVnIDwgcnhfbWF4KSkgewo+Pj4gVGhlIGJy YWNlcyBhcmUgbm90IG5lZWRlZCBhcm91bmQgdGhlIGNvbXBhcmlzb25zIGJlY2F1c2UgdGhleSBw cmVjZWRlCj4+PiB0aGUgQU5ELiBTYW1lIGZvciBhbGwgb3RoZXIgc2ltaWxhciBvY2N1cnJlbmNl cyBpbiB0aGUgY29kZS4KPj4gV2hpbGUgdGhhdCBpcyB0cnVlLCBzb21lIHByZWZlciB0byB1c2Ug ZXhwbGljaXQgYnJhY2VzIHRvIG1ha2UgaXQgbW9yZQo+PiByZWFkYWJsZS4KPj4gSW4gdGhlIHBh c3QgSSB3YXMgdG9sZCB0byB1c2UgZXhwbGljaXRseSBpbiBzdWNoIGNhc2VzLgo+IEF0IGxlYXN0 IG1vc3Qgb2YgY29kZSBpbiBrZXJuZWwgKEkndmUgc2VlbikgZG9lc24ndCBoYXZlIHN1cGVyZmx1 b3VzCj4gcGFyZW5zICh0aGUgY3VydnkgdGhpbmdpZXMgYWN0dWFsbHkgc2hvdWxkIGJlIHRoZSBi cmFjZXMpLiBSZWFkYWJpbGl0eQo+IGlzIGFyZ3VhYmxlIGluIHRoaXMgY2FzZSwgSSdtIGZpbmRp bmcgc3VjaCBjb2RlIGEgYml0IG1vcmUgZGlmZmljdWx0IHRvCj4gcmVhZCwgYWx0aG91Z2ggaW4g c29tZSBjYXNlcyBwYXJlbnMgYW5kIHNwYWNpbmcgbWF5IGhlbHAgdG8gcmVhZCBtb3JlCj4gY29t cGxleCBjb25zdHJ1Y3Rpb25zLgoKWWVzIHRoaXMgaXMgc3ViamVjdGl2ZSBhbmQgZGVwZW5kcyBv biB0aGUgaW5kaXZpZHVhbCByZWFkaW5nIHRoZSBjb2RlLiBJdCBpcwpjb25mdXNpbmcgZXZlcnkg dGltZSwgZm9yIHRoZSBzZW5kZXIsIGFib3V0IHdoaWNoIGd1aWRlbGluZSB0byBmb2xsb3cuIApS ZXNlbmRpbmcKdGhlIHBhdGNoL3NlcmllcyBmb3Igb25seSB0aGlzIHJlYXNvbiBtYXkgbm90IGJl IHJlYWxseSBuZWNlc3NhcnkuIFNpbmNlIApJIG5lZWQKdG8gZml4IGNvdXBsZSBvZiBpc3N1ZXMg aW4gdGhpcyBzZXJpZXMgSSBtYXkgY29uc2lkZXIgcmVtb3ZpbmcgdGhlIApleHBsaWNpdCBicmFj ZXMuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpBbHNh LWRldmVsIG1haWxpbmcgbGlzdApBbHNhLWRldmVsQGFsc2EtcHJvamVjdC5vcmcKaHR0cHM6Ly9t YWlsbWFuLmFsc2EtcHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbHNhLWRldmVsCg==