From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [RFC 2/7] drm/omap: Allocate drm_device earlier and unref it as last step Date: Fri, 01 Sep 2017 14:12:32 +0300 Message-ID: <2090248.InI4i6EBot@avalon> References: <20170829073218.11097-1-peter.ujfalusi@ti.com> <20170829073218.11097-3-peter.ujfalusi@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [185.26.127.97]) by gabe.freedesktop.org (Postfix) with ESMTPS id 90FA98996E for ; Fri, 1 Sep 2017 13:13:07 +0000 (UTC) In-Reply-To: <20170829073218.11097-3-peter.ujfalusi@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Peter Ujfalusi Cc: tomi.valkeinen@ti.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgUGV0ZXIsCgpUaGFuayB5b3UgZm9yIHRoZSBwYXRjaC4KCk9uIFR1ZXNkYXksIDI5IEF1Z3Vz dCAyMDE3IDEwOjMyOjEzIEVFU1QgUGV0ZXIgVWpmYWx1c2kgd3JvdGU6Cj4gSWYgd2UgYWxsb2Nh dGUgdGhlIGRybV9kZXZpY2UgZWFybGllciB3ZSBjYW4ganVzdCByZXR1cm4gdGhlIGVycm9yIGNv ZGUKPiB3aXRob3V0IHRoZSBuZWVkIHRvIHVzZSBnb3RvLgo+IERvIHRoZSB1bnJlZiBvZiB0aGUg ZHJtX2RldmljZSBhcyBhIGxhc3Qgc3RlcCB3aGVuIGNsZWFuaW5nIHVwLiBUaGlzIHdpbGwKPiBt YWtlIHRoZSBkcm1fZGV2aWNlIGF2YWlsYWJsZSBsb25nZXIgZm9yIHVzIGFuZCBtYWtlcyBzdXJl IHRoYXQgd2Ugb25seQo+IGZyZWUgdXAgdGhlIG1lbW9yeSB3aGVuIGFsbCBvdGhlciBjbGVhbnVw cyBoYXZlIGJlZW4gYWxyZWFkeSBkb25lLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFBldGVyIFVqZmFs dXNpIDxwZXRlci51amZhbHVzaUB0aS5jb20+CgpQZW5kaW5nIGEgbmV3IHZlcnNpb24gZHVlIHRv IHBhdGNoIDEvNyBub3QgYmVpbmcgY29ycmVjdCwKClJldmlld2VkLWJ5OiBMYXVyZW50IFBpbmNo YXJ0IDxsYXVyZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+Cgo+IC0tLQo+ICBkcml2ZXJz L2dwdS9kcm0vb21hcGRybS9vbWFwX2Rydi5jIHwgMjkgKysrKysrKysrKysrKy0tLS0tLS0tLS0t LS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKyksIDE2IGRlbGV0aW9ucygt KQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vb21hcGRybS9vbWFwX2Rydi5jCj4g Yi9kcml2ZXJzL2dwdS9kcm0vb21hcGRybS9vbWFwX2Rydi5jIGluZGV4IDkwMzUxMGQ4MDU0ZS4u YmQ3ZmUzMTdhMzY1Cj4gMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL29tYXBkcm0vb21h cF9kcnYuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9vbWFwZHJtL29tYXBfZHJ2LmMKPiBAQCAt NTUyLDYgKzU1MiwxNCBAQCBzdGF0aWMgaW50IHBkZXZfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2Rl dmljZSAqcGRldikKPiAgCWlmICghcHJpdikKPiAgCQlyZXR1cm4gLUVOT01FTTsKPiAKPiArCS8q IEFsbG9jYXRlIGFuZCBpbml0aWFsaXplIHRoZSBEUk0gZGV2aWNlLiAqLwo+ICsJZGRldiA9IGRy bV9kZXZfYWxsb2MoJm9tYXBfZHJtX2RyaXZlciwgJnBkZXYtPmRldik7Cj4gKwlpZiAoSVNfRVJS KGRkZXYpKQo+ICsJCXJldHVybiBQVFJfRVJSKGRkZXYpOwo+ICsKPiArCWRkZXYtPmRldl9wcml2 YXRlID0gcHJpdjsKPiArCXBsYXRmb3JtX3NldF9kcnZkYXRhKHBkZXYsIGRkZXYpOwo+ICsKPiAg CW9tYXBfY3J0Y19wcmVfaW5pdCgpOwo+IAo+ICAJcmV0ID0gb21hcF9jb25uZWN0X2Rzc2RldnMo KTsKPiBAQCAtNTY4LDIyICs1NzYsMTIgQEAgc3RhdGljIGludCBwZGV2X3Byb2JlKHN0cnVjdCBw bGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gIAlzcGluX2xvY2tfaW5pdCgmcHJpdi0+bGlzdF9sb2Nr KTsKPiAgCUlOSVRfTElTVF9IRUFEKCZwcml2LT5vYmpfbGlzdCk7Cj4gCj4gLQkvKiBBbGxvY2F0 ZSBhbmQgaW5pdGlhbGl6ZSB0aGUgRFJNIGRldmljZS4gKi8KPiAtCWRkZXYgPSBkcm1fZGV2X2Fs bG9jKCZvbWFwX2RybV9kcml2ZXIsICZwZGV2LT5kZXYpOwo+IC0JaWYgKElTX0VSUihkZGV2KSkg ewo+IC0JCXJldCA9IFBUUl9FUlIoZGRldik7Cj4gLQkJZ290byBlcnJfZGVzdHJveV93cTsKPiAt CX0KPiAtCj4gLQlkZGV2LT5kZXZfcHJpdmF0ZSA9IHByaXY7Cj4gLQlwbGF0Zm9ybV9zZXRfZHJ2 ZGF0YShwZGV2LCBkZGV2KTsKPiAtCj4gIAlvbWFwX2dlbV9pbml0KGRkZXYpOwo+IAo+ICAJcmV0 ID0gb21hcF9tb2Rlc2V0X2luaXQoZGRldik7Cj4gIAlpZiAocmV0KSB7Cj4gIAkJZGV2X2Vycigm cGRldi0+ZGV2LCAib21hcF9tb2Rlc2V0X2luaXQgZmFpbGVkOiByZXQ9JWRcbiIsIHJldCk7Cj4g LQkJZ290byBlcnJfZnJlZV9kcm1fZGV2Owo+ICsJCWdvdG8gZXJyX2dlbV9kZWluaXQ7Cj4gIAl9 Cj4gCj4gIAkvKiBJbml0aWFsaXplIHZibGFuayBoYW5kbGluZywgc3RhcnQgd2l0aCBhbGwgQ1JU Q3MgZGlzYWJsZWQuICovCj4gQEAgLTYxOSwxNCArNjE3LDEzIEBAIHN0YXRpYyBpbnQgcGRldl9w cm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ICBlcnJfY2xlYW51cF9tb2Rlc2V0 Ogo+ICAJZHJtX21vZGVfY29uZmlnX2NsZWFudXAoZGRldik7Cj4gIAlvbWFwX2RybV9pcnFfdW5p bnN0YWxsKGRkZXYpOwo+IC1lcnJfZnJlZV9kcm1fZGV2Ogo+ICtlcnJfZ2VtX2RlaW5pdDoKPiAg CW9tYXBfZ2VtX2RlaW5pdChkZGV2KTsKPiAtCWRybV9kZXZfdW5yZWYoZGRldik7Cj4gLWVycl9k ZXN0cm95X3dxOgo+ICAJZGVzdHJveV93b3JrcXVldWUocHJpdi0+d3EpOwo+ICAJb21hcF9kaXNj b25uZWN0X2Rzc2RldnMoKTsKPiAgZXJyX2NydGNfdW5pbml0Ogo+ICAJb21hcF9jcnRjX3ByZV91 bmluaXQoKTsKPiArCWRybV9kZXZfdW5yZWYoZGRldik7Cj4gIAlyZXR1cm4gcmV0Owo+ICB9Cj4g Cj4gQEAgLTY1MiwxMyArNjQ5LDEzIEBAIHN0YXRpYyBpbnQgcGRldl9yZW1vdmUoc3RydWN0IHBs YXRmb3JtX2RldmljZSAqcGRldikKPiAgCW9tYXBfZHJtX2lycV91bmluc3RhbGwoZGRldik7Cj4g IAlvbWFwX2dlbV9kZWluaXQoZGRldik7Cj4gCj4gLQlkcm1fZGV2X3VucmVmKGRkZXYpOwo+IC0K PiAgCWRlc3Ryb3lfd29ya3F1ZXVlKHByaXYtPndxKTsKPiAKPiAgCW9tYXBfZGlzY29ubmVjdF9k c3NkZXZzKCk7Cj4gIAlvbWFwX2NydGNfcHJlX3VuaW5pdCgpOwo+IAo+ICsJZHJtX2Rldl91bnJl ZihkZGV2KTsKPiArCj4gIAlyZXR1cm4gMDsKPiAgfQoKCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQ aW5jaGFydAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K ZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==