From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: Re: [PATCH v2] introduce a cache options for PV disks Date: Thu, 27 Jun 2013 17:35:24 +0100 Message-ID: <20940.27084.967886.708152@mariner.uk.xensource.com> References: <20940.19076.523978.4704@mariner.uk.xensource.com> <20940.25537.183890.394352@mariner.uk.xensource.com> <1372350299.8976.26.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1372350299.8976.26.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xensource.com, Ian Jackson , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org Ian Campbell writes ("Re: [PATCH v2] introduce a cache options for PV disks"): > On Thu, 2013-06-27 at 17:09 +0100, Ian Jackson wrote: > > diff --git a/xen/include/public/io/blkif.h b/xen/include/public/io/blkif.h > > index b9b9d98..baf0f0a 100644 > > --- a/xen/include/public/io/blkif.h > > +++ b/xen/include/public/io/blkif.h > > @@ -97,6 +97,22 @@ > > * > > * The type of the backing device/object. > > * > > + * > > + * direct-io-safe > > + * Values: 1 > > 0 (==direct-io is unsafe) is explicitly not a valid value? Looking around a bit, the other things in xenstore do this differently and it should be consistent. So I will change this to 0/1, defaulting to 0. Ian.