From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3D60C433FE for ; Wed, 8 Sep 2021 17:50:42 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C32761158 for ; Wed, 8 Sep 2021 17:50:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1C32761158 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5B3A58337C; Wed, 8 Sep 2021 19:50:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="PiSBVjcr"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2B9B483388; Wed, 8 Sep 2021 19:50:39 +0200 (CEST) Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C085182DC1 for ; Wed, 8 Sep 2021 19:50:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1631123431; bh=LJp9r16slBPy1MyWmRIIpZYFcoXWvEOjTeDs+K1OkRE=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=PiSBVjcr0EAmJ2LJ1H8RRFOGbm9sA3kpYI1u25MBLvz5FKpebsskvgyEOjZNkjZBj yBHexrYgApVEd0tKw8e0LRV7bM7ib9Q+RfFKJG+VV9m457tOI+j8AwfTTW4tZlACEc KJYWVQwc+nrQStdL9+KERqOufGM5m4AQHWodFX2g= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.123.55] ([88.152.144.157]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MQMyZ-1mbPhm1tEP-00MM1N; Wed, 08 Sep 2021 19:50:31 +0200 Subject: Re: [PATCH 12/35] efi: Add EFI uclass for media To: Simon Glass Cc: Ilias Apalodimas , Bin Meng , Tom Rini , Christian Melki , Alexander Graf , U-Boot Mailing List References: <20210908133405.696481-1-sjg@chromium.org> <20210908073355.12.I50ca59e389adf282bbff50eecc593f010a89c0f7@changeid> From: Heinrich Schuchardt Message-ID: <2095ab4c-7db7-ecfb-269b-4a91ecd78b8d@gmx.de> Date: Wed, 8 Sep 2021 19:50:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210908073355.12.I50ca59e389adf282bbff50eecc593f010a89c0f7@changeid> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:b10J4O247OaNhJFMpHcks9mTcNGOBilHwfDhCiO5Wzs94VKjoUq WrVYLk54OcUhadk18mVSM7tVi/OAENRHClEuQiN2GTd0neMBl8kBPeFPsk4d3yVfHyuMuF5 1YzW2X2xfTyz+CdrwKMs9S3oAOngEAiXt3nQSy1wy1xfpm/lzAbzsatTgYI8i6aymFy2/Yy PB+xwyiWLwcuA8gZ9XDuA== X-UI-Out-Filterresults: notjunk:1;V03:K0:pbHtsdNda6E=:ChV1p2vAmIkuNQQeX9HpWU +TOVdDlxvLFQqzKrvUxM0JWLL8jGEW7csdWXigZfXgSKu1k59abWlB0HsDbUsBgkAmBVaizkE YAxmePa7VNe0naEmC43/l1TW/xGBewEt8UlbQjP4VgqEFnko7oOzdWHN6N6LpjgEnMm7msgEt RGmTLvs09/c4ffc2/FB/POLTg+PNVxHCe1R0tL56MpKm/ol7PfEcJwnLKXrGLR2vBp3+6LXbJ XqeTImMIZv9ht2bdxKYZmYWqYP0i4Hf6ZU43uPmgBogYyhJ/qKkonFRwgLVADq3Hdkg7jaKkr iLWDEB17whvn+HBgpM/e+nsO96Wz/nBgh3odHQ6zrEmxAD5Ez+fx981L1z9B9w+WAGsyU3l4T vrEsnZvy4rSG25v++fU2fyNIE4f9KnrK3mPX4NbrSxqWIqs7zbh/1PTcbZByioa8n/vWHEGqA T5pDG2Of2Mba1SufbZxpboouai6n6Qk/cA476k5ytSkkL9oNspjYq8LL2pIasUO27OxG8H85D 69Ecb5lj00aDRSeJmf4NZErdKSMzV4dTo9Vy7GTp+U0M141l2j0hsHWe+7JCxtqhys5EtqUUu wsmuvw3hXrvwG9tdTC16n5r0YiCosbdz3NIsgj5FPTSRe3KHSvnnStvrYTtB/UGtPNCtig8YG 9iLUXkXqDiPLh9aIeXwIMOt4nrxYx2G79Vd4GcKVU2+8bqeUoAybAlHfL20Hh5jKtwQw6vQDM In/Crciu6ug3N0EAJbaeRpBu/cY8OmkGL3qp2wYLcqV5j2YfyXqJCBYi+Nh+9X1kWa6XHu/gN dqMmpWoNbfqmqj1zNsTk/djE9A8+tQFSa0/cFleNYWa5kbIBwIhKPpG5yhEouL4K2stJtIZX/ asTVCFdLzRx3PhIy9xWbDxX9TgFDLiO+nMfr8TLuqA8czz94oxf14qhuEVIq1WtD3654wurDV 4bG1EYb0EjcCrtxkrAWPFSe51bt2dSFUDzV3aNWgZku7odLocD1CghxbP7vWBZwJxB0aR4EUj 4bb8TDKTIdOvCdBnaffPkjyCrxAqwwfgOboYRB284TrdmkHs8Mx1GJOx/ntzkJbbzWHot/N/S vg3J7l/bXVASrk= X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 9/8/21 3:33 PM, Simon Glass wrote: > At present UCLASS_EFI is used to represent an EFI filesystem The > description of this uclass is "EFI managed devices" which is pretty vagu= e. > The only driver that uses this uclass is in fact not a real U-Boot drive= r, > since its operations do not include a struct udevice. > > Rather than mess with this, create a new UCLASS_EFI_MEDIA uclass to hand= le > EFI media such as disks. Make this the uclass to use for EFI media. > > The existing implementation using UCLASS_EFI remains as is, for > discussion. UCLASS_EFI is not related to block devices. It is for drivers implementing the EFI_DRIVER_BINDING_PROTOCOL. efi_uclass.c simplifies writing such drivers. So your patch does not make sense to me. Please, separate the series in two: one for U-Boot on EFI, one for the UEFI implementation in U-Boot. Best regards Heinrich > > Signed-off-by: Simon Glass > --- > > arch/sandbox/dts/test.dts | 4 ++++ > drivers/block/Kconfig | 23 +++++++++++++++++++++++ > drivers/block/Makefile | 3 +++ > drivers/block/blk-uclass.c | 2 +- > drivers/block/efi-media-uclass.c | 15 +++++++++++++++ > drivers/block/sb_efi_media.c | 21 +++++++++++++++++++++ > include/dm/uclass-id.h | 1 + > test/dm/Makefile | 1 + > test/dm/efi_media.c | 24 ++++++++++++++++++++++++ > 9 files changed, 93 insertions(+), 1 deletion(-) > create mode 100644 drivers/block/efi-media-uclass.c > create mode 100644 drivers/block/sb_efi_media.c > create mode 100644 test/dm/efi_media.c > > diff --git a/arch/sandbox/dts/test.dts b/arch/sandbox/dts/test.dts > index 962bdbe5567..af88cf681ae 100644 > --- a/arch/sandbox/dts/test.dts > +++ b/arch/sandbox/dts/test.dts > @@ -486,6 +486,10 @@ > compatible =3D "sandbox,clk-ccf"; > }; > > + efi-media { > + compatible =3D "sandbox,efi-media"; > + }; > + > eth@10002000 { > compatible =3D "sandbox,eth"; > reg =3D <0x10002000 0x1000>; > diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig > index 4023332dd98..058956ee8ee 100644 > --- a/drivers/block/Kconfig > +++ b/drivers/block/Kconfig > @@ -63,6 +63,29 @@ config TPL_BLOCK_CACHE > help > This option enables the disk-block cache in TPL > > +config EFI_MEDIA > + bool "Support EFI media drivers" > + default y if EFI || SANDBOX > + help > + Enable this to support media devices on top of UEFI. This enables > + just the uclass so you also need a specific driver to make this do > + anything. > + > + For sandbox there is a test driver. > + > +if EFI_MEDIA > + > +config EFI_MEDIA_SANDBOX > + bool "Sandbox EFI media driver" > + depends on SANDBOX > + default y > + help > + Enables a simple sandbox media driver, used for testing just the > + EFI_MEDIA uclass. It does not do anything useful, since sandbox does > + not actually support running on top of UEFI. > + > +endif # EFI_MEDIA > + > config IDE > bool "Support IDE controllers" > select HAVE_BLOCK_DEVICE > diff --git a/drivers/block/Makefile b/drivers/block/Makefile > index 94ab5c6f906..3778633da1d 100644 > --- a/drivers/block/Makefile > +++ b/drivers/block/Makefile > @@ -14,3 +14,6 @@ obj-$(CONFIG_IDE) +=3D ide.o > endif > obj-$(CONFIG_SANDBOX) +=3D sandbox.o > obj-$(CONFIG_$(SPL_TPL_)BLOCK_CACHE) +=3D blkcache.o > + > +obj-$(CONFIG_EFI_MEDIA) +=3D efi-media-uclass.o > +obj-$(CONFIG_EFI_MEDIA_SANDBOX) +=3D sb_efi_media.o > diff --git a/drivers/block/blk-uclass.c b/drivers/block/blk-uclass.c > index 83682dcc181..2db7ce5de20 100644 > --- a/drivers/block/blk-uclass.c > +++ b/drivers/block/blk-uclass.c > @@ -44,7 +44,7 @@ static enum uclass_id if_type_uclass_id[IF_TYPE_COUNT]= =3D { > [IF_TYPE_SATA] =3D UCLASS_AHCI, > [IF_TYPE_HOST] =3D UCLASS_ROOT, > [IF_TYPE_NVME] =3D UCLASS_NVME, > - [IF_TYPE_EFI] =3D UCLASS_EFI, > + [IF_TYPE_EFI] =3D UCLASS_EFI_MEDIA, > [IF_TYPE_VIRTIO] =3D UCLASS_VIRTIO, > [IF_TYPE_PVBLOCK] =3D UCLASS_PVBLOCK, > }; > diff --git a/drivers/block/efi-media-uclass.c b/drivers/block/efi-media-= uclass.c > new file mode 100644 > index 00000000000..e012f6f2f4c > --- /dev/null > +++ b/drivers/block/efi-media-uclass.c > @@ -0,0 +1,15 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Uclass for EFI media devices > + * > + * Copyright 2021 Google LLC > + */ > + > +#include > +#include > + > +UCLASS_DRIVER(efi_media) =3D { > + .id =3D UCLASS_EFI_MEDIA, > + .name =3D "efi_media", > + .flags =3D DM_UC_FLAG_SEQ_ALIAS, > +}; > diff --git a/drivers/block/sb_efi_media.c b/drivers/block/sb_efi_media.c > new file mode 100644 > index 00000000000..4f242aa13a4 > --- /dev/null > +++ b/drivers/block/sb_efi_media.c > @@ -0,0 +1,21 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * EFI_MEDIA driver for sandbox > + * > + * Copyright 2021 Google LLC > + */ > + > +#include > +#include > + > +static const struct udevice_id sandbox_efi_media_ids[] =3D { > + { .compatible =3D "sandbox,efi-media" }, > + { } > +}; > + > + > +U_BOOT_DRIVER(sandbox_efi_media) =3D { > + .name =3D "sandbox_efi_media", > + .id =3D UCLASS_EFI_MEDIA, > + .of_match =3D sandbox_efi_media_ids, > +}; > diff --git a/include/dm/uclass-id.h b/include/dm/uclass-id.h > index e7edd409f30..4906eb836c2 100644 > --- a/include/dm/uclass-id.h > +++ b/include/dm/uclass-id.h > @@ -49,6 +49,7 @@ enum uclass_id { > UCLASS_DSA, /* Distributed (Ethernet) Switch Architecture */ > UCLASS_ECDSA, /* Elliptic curve cryptographic device */ > UCLASS_EFI, /* EFI managed devices */ > + UCLASS_EFI_MEDIA, /* EFI media (e.g. a disk) */ > UCLASS_ETH, /* Ethernet device */ > UCLASS_ETH_PHY, /* Ethernet PHY device */ > UCLASS_FIRMWARE, /* Firmware */ > diff --git a/test/dm/Makefile b/test/dm/Makefile > index 516f69d61cb..d9bc37d8313 100644 > --- a/test/dm/Makefile > +++ b/test/dm/Makefile > @@ -37,6 +37,7 @@ obj-$(CONFIG_DMA) +=3D dma.o > obj-$(CONFIG_VIDEO_MIPI_DSI) +=3D dsi_host.o > obj-$(CONFIG_DM_DSA) +=3D dsa.o > obj-$(CONFIG_ECDSA_VERIFY) +=3D ecdsa.o > +obj-$(CONFIG_EFI_MEDIA_SANDBOX) +=3D efi_media.o > obj-$(CONFIG_DM_ETH) +=3D eth.o > ifneq ($(CONFIG_EFI_PARTITION),) > obj-$(CONFIG_FASTBOOT_FLASH_MMC) +=3D fastboot.o > diff --git a/test/dm/efi_media.c b/test/dm/efi_media.c > new file mode 100644 > index 00000000000..e343a0e9c85 > --- /dev/null > +++ b/test/dm/efi_media.c > @@ -0,0 +1,24 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Test for EFI_MEDIA uclass > + * > + * Copyright 2021 Google LLC > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > + > +/* Test that we can use the EFI_MEDIA uclass */ > +static int dm_test_efi_media(struct unit_test_state *uts) > +{ > + struct udevice *dev; > + > + ut_assertok(uclass_first_device_err(UCLASS_EFI_MEDIA, &dev)); > + > + return 0; > +} > +DM_TEST(dm_test_efi_media, UT_TESTF_SCAN_PDATA | UT_TESTF_SCAN_FDT); >