From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,URIBL_SBL,URIBL_SBL_A autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3753EC072B5 for ; Fri, 24 May 2019 17:32:24 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 5110920657 for ; Fri, 24 May 2019 17:32:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="G22v6Iaf"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="GOHL5alq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5110920657 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 25F8BA49; Fri, 24 May 2019 19:32:22 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 293211D7 for ; Fri, 24 May 2019 19:32:20 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id BAFF921B7C; Fri, 24 May 2019 13:32:19 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 24 May 2019 13:32:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=KlCYhGjdNt/Tt0tHYlp1SxpG0pD3m/78SICjxjyCW0c=; b=G22v6Iaff4PJ sb8+Z7+0JkWRrwDh6L+MzBHmHWnCU4xS8ph8EzSPLsKprrcB8PwmjwYOK7rjJHND MXiuKha6LoLjjx4MyWbxxvv3prWATv8n6lV9yERRRqBRMxel721sY+d1Qlw9peU/ x2KmHW6dT7mga7Lv8sn1aNqOtg8ezX8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=KlCYhGjdNt/Tt0tHYlp1SxpG0pD3m/78SICjxjyCW 0c=; b=GOHL5alqsEX/cQwqlH1rM2bDpbGURFCKa5knYJPApD2bhr4BGYKgiyw3M zgMUhjdJs+2zr7PAl1vt465zVXqiB3NWMJAUKqQ8aGWmfoV/1Ew7AmUXmxCApMKD IYfr5sSvK8OS+nCE9528fqlOBXwIfrm6vQlhtjwoYNRRE3d1hFts5ioqzl0FYl3+ EHqMBw6zHuQrJgiWaOIBIGvLacJbuN5ihpraA9CLZ+nV7H56ROCZBYD3yIVXQ11H lNkJiO8TdmUTWBaS2C2kpV+hfBFFdhKagty9KrCG4O7g3R4rswyYqz3coIH0+RJc ACB0glg7ZfQV5ploQ7aDo2i781zuA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrudduiedgudduhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc fkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpeht hhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7B4DE80060; Fri, 24 May 2019 13:32:17 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org, Ferruh Yigit , matan@mellanox.com, Stephen Hemminger Date: Fri, 24 May 2019 19:32:14 +0200 Message-ID: <2097372.dQ5myFMioY@xps> In-Reply-To: <20190524101108.574621c8@hermes.lan> References: <20190523220124.18818-1-stephen@networkplumber.org> <2341346.KjBqQsXUje@xps> <20190524101108.574621c8@hermes.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/vdev_netvsc: print warning if Mellanox devices are not configured X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 24/05/2019 19:11, Stephen Hemminger: > On Fri, 24 May 2019 19:05:20 +0200 > Thomas Monjalon wrote: > > > > > > device drivers on Hyper-V/Azure. If the build system supported dependencies > > > > > (like Linux kbuild) this would not be necessary. Meson only does dynamic dependencies > > > > > so that doesn't help. > > > > > > > > > > This is a warning and not fatal only because application will still at > > > > > least run, and somebody may want to run with SR-IOV with Intel NIC's on Hyper-V. > > > > > > > > > > > > > > > The warning is just to give users better immediate feedback rather than > > > > > trying to diagnose poor performance or mystery device not found messages. > > > > > > > > > > > > It really looks strange to me. > > > > What you need is to fail at compilation if requested PMD is not built. > > > > I would advise to work on a script to configure meson. > > > > > > None of the people that ran into this were using meson build. > > > For example, VPP doesn't use meson. > > > > They will use meson when makefile will be removed :) > > > > Anyway, no matter the build system, what we want is a way > > to guide users to a proper DPDK installation. > > Your solution is to add some very specific logs. > > My proposal is to guide the user with a script and some > > specific parameters so it will fail if a required dependency is not met. > > Not familiar enough with meson magic syntax to make vdev_netvsc not build > without MLX. But that would just be pushing the mystery failure further > down the road. I think you did not understand my proposal. Let's take an example. You give this instruction to build DPDK: buildtools/build-require.sh vdev_netvsc mlx4 If mlx4 is not built then it will fail with this message: librte_pmd_mlx4 failed to build So the user knows what went wrong. No mystery. > Another alternative would be to drop vdev_netvsc from the default Linux > build. That way users would have to enable it manually. > > My preferred solution would be to just kill vdev_netvsc and go to only netvsc PMD > but that is a couple releases away.