From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3382D7B for ; Fri, 15 Apr 2022 18:21:38 +0000 (UTC) Received: by mail-ej1-f45.google.com with SMTP id u15so16518492ejf.11 for ; Fri, 15 Apr 2022 11:21:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=aY2i70GcxPM0t2j3zWxTuNc97f9BOBUas6jIJc8m0/0=; b=e2/JQZr5KfImS1MZLgF8x0G8Ugy+IalHb4/nfvLGJljKEkBueU3lYaCB6l++dVJ2T2 ct7bfOhn4kEOMv+637QbdyhS9JUFuWIoT9foyYKwaGCbT9bFqZUYsTnaiKTD9uskqf1j Ek9/HZErQ7IiXqI6RvMJuUn9R8IxNG2NlBjMcwnlzzK17Ov3AF0ti/AzlowENM8JsNq4 pXnobt4hQF+ymQv/PVIbX3kgj1HEiuqYxgu1jMqbL7gO0MGI0zbaxM2B3Q4eqEy79MlW VNgXQHbrgoHdPuzekv1iCnAbGCs3o6x/0wFq/NQm/cRzvlIeNqPwCPoNz/bAoJG8VhuK EsLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=aY2i70GcxPM0t2j3zWxTuNc97f9BOBUas6jIJc8m0/0=; b=1eIFuFeHupLMgQnsfkcYA5I0qHFEthOgPKiIWODxYMEzYFvGVg3aEgkUsRjmJnIysH zchBIW86MGELMAzrm6vMlsQqmUejk0o0Nhymp7j+8anin/FMane/s2WM+ObmKKra6X1N uvT5bCflMlMz36QcyVdfnZJR4F3U+ymUN/mDJhZiBI1CcLZ+I1qtPNfQkp39XXkvrcMX E+AZF4JG2yxQubjVtXZtweZRp3fkD48h0OT1ug/QS+jQqdEIaLbL+Hg2HgFktC1tHUm2 qnnacsLeb8gINu+8KZKnnEff1uBKA1450BqehgM7qjkLGVBCqNs5DHBvrYa80rJC7Yga uVbQ== X-Gm-Message-State: AOAM530EC32YZlJZjmEXyBmwxnsuE2cx6hqmZ/lFXjmczowWcrjL3FQG jAZNKwV4wbsQS+loD8IlMhY= X-Google-Smtp-Source: ABdhPJzCq6JERosCiAk6D1rln8EykVMZGfAoAS2LM2VBpWXvpllvzlCPidoEpqmP3Q4iCLXYpm4R5w== X-Received: by 2002:a17:907:168a:b0:6e8:d125:1d24 with SMTP id hc10-20020a170907168a00b006e8d1251d24mr273806ejc.508.1650046896395; Fri, 15 Apr 2022 11:21:36 -0700 (PDT) Received: from jernej-laptop.localnet (89-212-118-115.static.t-2.net. [89.212.118.115]) by smtp.gmail.com with ESMTPSA id lb4-20020a170907784400b006e0d13f65e5sm1910608ejc.167.2022.04.15.11.21.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Apr 2022 11:21:36 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Dmitry Torokhov , Hans de Goede , Samuel Holland Cc: Samuel Holland , Maxime Ripard , Rob Herring , Chen-Yu Tsai , Krzysztof Kozlowski , Maxime Ripard , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v2 3/3] Input: sun4i-lradc-keys: Add support for R329 and D1 Date: Fri, 15 Apr 2022 20:21:34 +0200 Message-ID: <2097461.irdbgypaU6@jernej-laptop> In-Reply-To: <20220414002349.24332-3-samuel@sholland.org> References: <20220414002349.24332-1-samuel@sholland.org> <20220414002349.24332-3-samuel@sholland.org> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Dne =C4=8Detrtek, 14. april 2022 ob 02:23:48 CEST je Samuel Holland napisal= (a): > This LRADC variant uses the same 3/4*AVCC reference voltage as the A83T > variant. The R329 and D1 LRADCs appear to be identical, so D1 support is > accomplished through having the R329 LRADC as a fallback compatible. >=20 > Signed-off-by: Samuel Holland Acked-by: Jernej Skrabec Best regards, Jernej > --- >=20 > Changes in v2: > - Set the new flag for the R329 variant. >=20 > drivers/input/keyboard/sun4i-lradc-keys.c | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/drivers/input/keyboard/sun4i-lradc-keys.c > b/drivers/input/keyboard/sun4i-lradc-keys.c index > 5630334a6c09..8f9bfb05244d 100644 > --- a/drivers/input/keyboard/sun4i-lradc-keys.c > +++ b/drivers/input/keyboard/sun4i-lradc-keys.c > @@ -78,6 +78,12 @@ static const struct lradc_variant r_lradc_variant_a83t= =3D > { .divisor_denominator =3D 4 > }; >=20 > +static const struct lradc_variant lradc_variant_r329 =3D { > + .divisor_numerator =3D 3, > + .divisor_denominator =3D 4, > + .has_clock_reset =3D true, > +}; > + > struct sun4i_lradc_keymap { > u32 voltage; > u32 keycode; > @@ -323,6 +329,8 @@ static const struct of_device_id sun4i_lradc_of_match= [] > =3D { .data =3D &lradc_variant_a10 }, > { .compatible =3D "allwinner,sun8i-a83t-r-lradc", > .data =3D &r_lradc_variant_a83t }, > + { .compatible =3D "allwinner,sun50i-r329-lradc", > + .data =3D &lradc_variant_r329 }, > { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(of, sun4i_lradc_of_match); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41613C433FE for ; Fri, 15 Apr 2022 18:23:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lr0Ud5sRLHLsVuAT7x4LlZMVmuqHDr2i1pvmGCzONos=; b=iww7IuJp7JVSE+ lykg1TTCdkuTUzuwyUZ90YOH695Vw3Jjw8kKnBNw3s0QrwNRCKSCY6E0BNKRqOAoSeyRGrNeU1rMT SKb4VQXgoPE13OotogUlcnMWhoTo+U/ZgjLAdEiztY7q1fRiyyA8DUBfEjna+FT1zEuCsTvKpPcDO SwZQxA04dcVh3IsOHEsQyBxSWiicGGNoZ4V5N9DAGsGD4vKNKv6vk/wcFk93M/qHUy2BicT9PXEWk xU5pqDwEASPRhjDA7o/Czcy/ZFs12asFNaB0+CSefcl11X84gunfqr6RNKZMyT8M/9jiJ2yNf5HL2 spHVyIEXJhYs3fOS+q2A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nfQZh-00B5FG-VS; Fri, 15 Apr 2022 18:21:42 +0000 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nfQZe-00B5Cc-Ru for linux-arm-kernel@lists.infradead.org; Fri, 15 Apr 2022 18:21:40 +0000 Received: by mail-ej1-x635.google.com with SMTP id bg10so16593806ejb.4 for ; Fri, 15 Apr 2022 11:21:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=aY2i70GcxPM0t2j3zWxTuNc97f9BOBUas6jIJc8m0/0=; b=e2/JQZr5KfImS1MZLgF8x0G8Ugy+IalHb4/nfvLGJljKEkBueU3lYaCB6l++dVJ2T2 ct7bfOhn4kEOMv+637QbdyhS9JUFuWIoT9foyYKwaGCbT9bFqZUYsTnaiKTD9uskqf1j Ek9/HZErQ7IiXqI6RvMJuUn9R8IxNG2NlBjMcwnlzzK17Ov3AF0ti/AzlowENM8JsNq4 pXnobt4hQF+ymQv/PVIbX3kgj1HEiuqYxgu1jMqbL7gO0MGI0zbaxM2B3Q4eqEy79MlW VNgXQHbrgoHdPuzekv1iCnAbGCs3o6x/0wFq/NQm/cRzvlIeNqPwCPoNz/bAoJG8VhuK EsLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=aY2i70GcxPM0t2j3zWxTuNc97f9BOBUas6jIJc8m0/0=; b=JGs3eoDEeJBmXSTMR5RQ3qGBQVtBWG+CqCcbsv76BmdyImoCUUF6UbAvRaHxqkGLdi 08Dra9T/ibRZJJfCaZ59eD+WkvkNmFsyHyjiZeMX7YK2Wn+2rkh+A54BoWLlcEBLJVcP X/i+VIodBus21thVhfTfnpgN4ttEWefm3KHvG6V/2cq07NKUoYpDagZUyQ/JeYbylF/N g+WGWXacS9lXAld1dXW4nwAnIEYeVHciL923v//YPe7c3caItprzSgp3mnDOryBMfIxj ICUmiIGa+6W/o4asnqTYrBBAYOAE6/vC/YMBA3/fkYTYMbpK1IvPXx1o4WktuIRZzY+d xBxQ== X-Gm-Message-State: AOAM532wZBarJZoF+wdbKW9mdytSnMkiqxP91VHDsl17gBKECeHhhc8G tuhk8RHGJ1LLgZJpvKsfdgY= X-Google-Smtp-Source: ABdhPJzCq6JERosCiAk6D1rln8EykVMZGfAoAS2LM2VBpWXvpllvzlCPidoEpqmP3Q4iCLXYpm4R5w== X-Received: by 2002:a17:907:168a:b0:6e8:d125:1d24 with SMTP id hc10-20020a170907168a00b006e8d1251d24mr273806ejc.508.1650046896395; Fri, 15 Apr 2022 11:21:36 -0700 (PDT) Received: from jernej-laptop.localnet (89-212-118-115.static.t-2.net. [89.212.118.115]) by smtp.gmail.com with ESMTPSA id lb4-20020a170907784400b006e0d13f65e5sm1910608ejc.167.2022.04.15.11.21.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Apr 2022 11:21:36 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Dmitry Torokhov , Hans de Goede , Samuel Holland Cc: Samuel Holland , Maxime Ripard , Rob Herring , Chen-Yu Tsai , Krzysztof Kozlowski , Maxime Ripard , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v2 3/3] Input: sun4i-lradc-keys: Add support for R329 and D1 Date: Fri, 15 Apr 2022 20:21:34 +0200 Message-ID: <2097461.irdbgypaU6@jernej-laptop> In-Reply-To: <20220414002349.24332-3-samuel@sholland.org> References: <20220414002349.24332-1-samuel@sholland.org> <20220414002349.24332-3-samuel@sholland.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220415_112138_937954_7715BB87 X-CRM114-Status: GOOD ( 18.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RG5lIMSNZXRydGVrLCAxNC4gYXByaWwgMjAyMiBvYiAwMjoyMzo0OCBDRVNUIGplIFNhbXVlbCBI b2xsYW5kIG5hcGlzYWwoYSk6Cj4gVGhpcyBMUkFEQyB2YXJpYW50IHVzZXMgdGhlIHNhbWUgMy80 KkFWQ0MgcmVmZXJlbmNlIHZvbHRhZ2UgYXMgdGhlIEE4M1QKPiB2YXJpYW50LiBUaGUgUjMyOSBh bmQgRDEgTFJBRENzIGFwcGVhciB0byBiZSBpZGVudGljYWwsIHNvIEQxIHN1cHBvcnQgaXMKPiBh Y2NvbXBsaXNoZWQgdGhyb3VnaCBoYXZpbmcgdGhlIFIzMjkgTFJBREMgYXMgYSBmYWxsYmFjayBj b21wYXRpYmxlLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFNhbXVlbCBIb2xsYW5kIDxzYW11ZWxAc2hv bGxhbmQub3JnPgoKQWNrZWQtYnk6IEplcm5laiBTa3JhYmVjIDxqZXJuZWouc2tyYWJlY0BnbWFp bC5jb20+CgpCZXN0IHJlZ2FyZHMsCkplcm5lagoKPiAtLS0KPiAKPiBDaGFuZ2VzIGluIHYyOgo+ ICAtIFNldCB0aGUgbmV3IGZsYWcgZm9yIHRoZSBSMzI5IHZhcmlhbnQuCj4gCj4gIGRyaXZlcnMv aW5wdXQva2V5Ym9hcmQvc3VuNGktbHJhZGMta2V5cy5jIHwgOCArKysrKysrKwo+ICAxIGZpbGUg Y2hhbmdlZCwgOCBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvaW5wdXQv a2V5Ym9hcmQvc3VuNGktbHJhZGMta2V5cy5jCj4gYi9kcml2ZXJzL2lucHV0L2tleWJvYXJkL3N1 bjRpLWxyYWRjLWtleXMuYyBpbmRleAo+IDU2MzAzMzRhNmMwOS4uOGY5YmZiMDUyNDRkIDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvaW5wdXQva2V5Ym9hcmQvc3VuNGktbHJhZGMta2V5cy5jCj4gKysr IGIvZHJpdmVycy9pbnB1dC9rZXlib2FyZC9zdW40aS1scmFkYy1rZXlzLmMKPiBAQCAtNzgsNiAr NzgsMTIgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBscmFkY192YXJpYW50IHJfbHJhZGNfdmFyaWFu dF9hODN0ID0KPiB7IC5kaXZpc29yX2Rlbm9taW5hdG9yID0gNAo+ICB9Owo+IAo+ICtzdGF0aWMg Y29uc3Qgc3RydWN0IGxyYWRjX3ZhcmlhbnQgbHJhZGNfdmFyaWFudF9yMzI5ID0gewo+ICsJLmRp dmlzb3JfbnVtZXJhdG9yID0gMywKPiArCS5kaXZpc29yX2Rlbm9taW5hdG9yID0gNCwKPiArCS5o YXNfY2xvY2tfcmVzZXQgPSB0cnVlLAo+ICt9Owo+ICsKPiAgc3RydWN0IHN1bjRpX2xyYWRjX2tl eW1hcCB7Cj4gIAl1MzIgdm9sdGFnZTsKPiAgCXUzMiBrZXljb2RlOwo+IEBAIC0zMjMsNiArMzI5 LDggQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBvZl9kZXZpY2VfaWQgc3VuNGlfbHJhZGNfb2ZfbWF0 Y2hbXQo+ID0geyAuZGF0YSA9ICZscmFkY192YXJpYW50X2ExMCB9LAo+ICAJeyAuY29tcGF0aWJs ZSA9ICJhbGx3aW5uZXIsc3VuOGktYTgzdC1yLWxyYWRjIiwKPiAgCQkuZGF0YSA9ICZyX2xyYWRj X3ZhcmlhbnRfYTgzdCB9LAo+ICsJeyAuY29tcGF0aWJsZSA9ICJhbGx3aW5uZXIsc3VuNTBpLXIz MjktbHJhZGMiLAo+ICsJCS5kYXRhID0gJmxyYWRjX3ZhcmlhbnRfcjMyOSB9LAo+ICAJeyAvKiBz ZW50aW5lbCAqLyB9Cj4gIH07Cj4gIE1PRFVMRV9ERVZJQ0VfVEFCTEUob2YsIHN1bjRpX2xyYWRj X29mX21hdGNoKTsKCgoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxp c3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9saW51eC1hcm0ta2VybmVsCg==