From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gupta, Pekon" Subject: RE: support DUAL and QUAD[patch v1] Date: Tue, 16 Jul 2013 09:11:25 +0000 Message-ID: <20980858CB6D3A4BAE95CA194937D5E73E9E851E@DBDE04.ent.ti.com> References: <20980858CB6D3A4BAE95CA194937D5E73E9E84D2@DBDE04.ent.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: linux-mtd , Mark Brown , "linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" , "Poddar, Sourav" To: yuhang wang Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org > > Hi, Gupta > > > > [Pekon]: Instead of adding new fields you can use existing 'mode' field to > > pass on the platform specific configurations. And if 'u8 mode' does not > > suffice you can increase it to 'u32'. > > #define QSPI_MODE 1 << 5; // just check which bit-fields are un-used > > spi_board_info->mode |= QSPI_MODE; > > > > well, can dual and quad be regarded as a spi mode? if so, your comment > seems > to be right. Yes, Quad and Dual modes should be regarded as extension of SPI protocol. - They follow the same basic principle of synchronous data transfer. Right ? - These modes are not adding any extra side-band | In-band signaling or controls to modify the protocol. They are just increasing the width of data-channel for better throughput. with regards, pekon ------------------------------------------------------------------------------ See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gupta, Pekon" To: yuhang wang Subject: RE: support DUAL and QUAD[patch v1] Date: Tue, 16 Jul 2013 09:11:25 +0000 Message-ID: <20980858CB6D3A4BAE95CA194937D5E73E9E851E@DBDE04.ent.ti.com> References: <20980858CB6D3A4BAE95CA194937D5E73E9E84D2@DBDE04.ent.ti.com> In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: linux-mtd , Grant Likely , Mark Brown , "linux-mtd@lists.infradead.org" , "spi-devel-general@lists.sourceforge.net" , "Poddar, Sourav" List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , >=20 > Hi, Gupta >=20 >=20 > > [Pekon]: Instead of adding new fields you can use existing 'mode' field= to > > pass on the platform specific configurations. And if 'u8 mode' does not > > suffice you can increase it to 'u32'. > > #define QSPI_MODE 1 << 5; // just check which bit-fields are un-u= sed > > spi_board_info->mode |=3D QSPI_MODE; > > >=20 > well, can dual and quad be regarded as a spi mode? if so, your comment > seems > to be right. Yes, Quad and Dual modes should be regarded as extension of SPI protocol. - They follow the same basic principle of synchronous data transfer. Right = ? - These modes are not adding any extra side-band | In-band signaling or=20 controls to modify the protocol. They are just increasing the width of data-channel for better throughput. with regards, pekon